mprobst marked an inline comment as done.

================
Comment at: lib/Format/FormatTokenLexer.cpp:245
@@ -241,1 +244,3 @@
       ++Offset; // Skip the escaped character.
+    if (Offset + 1 < Lex->getBuffer().end() && *Offset == '$' &&
+        *(Offset + 1) == '{') {
----------------
ygao wrote:
> What happens if the '${' is immediately after a backslash (the if statement 
> above), should the '${' get escaped?
Sorry, I accidentally included this in the wrong diff – the template string 
thing is in D22431. I'll answer there.


https://reviews.llvm.org/D23761



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to