Author: omtcyfz
Date: Wed Aug 3 01:54:24 2016
New Revision: 277577
URL: http://llvm.org/viewvc/llvm-project?rev=277577&view=rev
Log:
[clang-tidy] address concerns with rL277340
alexfh raised a concern with https://reviews.llvm.org/rL277340
After retabbing indentation of .. code-block:: was incr
Author: etienneb
Date: Wed Aug 3 01:59:46 2016
New Revision: 277578
URL: http://llvm.org/viewvc/llvm-project?rev=277578&view=rev
Log:
[extra-tools] Fix extra tools build bot warnings due to incorrect doc
/home/llvmbb/llvm-build-dir/clang-x86_64-debian-fast/llvm.src/tools/clang/tools/extra/clang-
bader added inline comments.
Comment at: test/CodeGenOpenCL/cl20-device-side-enqueue.cl:12
@@ -11,3 +11,3 @@
unsigned flags = 0;
- // CHECK: %ndrange = alloca %opencl.ndrange_t*
+ // CHECK: %ndrange = alloca %ndrange_t
ndrange_t ndrange;
Could you also add
omtcyfz added inline comments.
Comment at:
test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:2
@@ +1,3 @@
+// RUN: cat %s > %t.cpp
+// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
al
omtcyfz added inline comments.
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
// RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i --
// RUN
xazax.hun updated this revision to Diff 66632.
xazax.hun marked 4 inline comments as done.
xazax.hun added a comment.
- Improvements according to review comments.
https://reviews.llvm.org/D23014
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/Store.h
lib/StaticAnalyzer/Core/CallEvent
omtcyfz updated this revision to Diff 66634.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/clang-rename/ComplexFunctionOverride.cpp
test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp
test/clang-rename/TemplateClas
xazax.hun created this revision.
xazax.hun added reviewers: zaks.anna, dcoughlin, NoQ.
xazax.hun added a subscriber: cfe-commits.
Right now due to a missing brace error the assumptions that an index is inbound
in case we are under constrained is not added.
https://reviews.llvm.org/D23112
Files:
Anastasia added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D23071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
omtcyfz updated this revision to Diff 66642.
omtcyfz added a comment.
Removed `dump()` call used for debugging purposes.
Removed unneeded header inclusion in `USRFindingAction.cpp`.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/cl
hiraditya added a comment.
In https://reviews.llvm.org/D22782#504416, @EricWF wrote:
> The change itself LGTM, although we probably want to inline the forward/input
> iterator __init's as well.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please
hiraditya added a comment.
In https://reviews.llvm.org/D22834#504425, @EricWF wrote:
> LGTM.
>
> However I would like to see a small benchmark that demonstrates the
> performance change. Please try and write the benchmark using Google Benchmark.
> Some helpful links:
>
> http://libcxx.llvm.org/
klimek created this revision.
klimek added reviewers: djasper, bkramer, ioeric.
klimek added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D23119
Files:
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/Re
klimek updated this revision to Diff 66651.
klimek added a comment.
Remove re-implementation of overlaps check.
https://reviews.llvm.org/D23119
Files:
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/RefactoringTest.cpp
===
alexfh added inline comments.
Comment at: test/clang-rename/TemplateClassInstantiationFindByDeclaration.cpp:2
@@ -1,3 +1,3 @@
// RUN: cat %s > %t.cpp
-// RUN: clang-rename -offset=287 -new-name=Bar %t.cpp -i --
+// RUN: clang-rename -offset=159 -new-name=Bar %t.cpp -i --
// RUN:
bader created this revision.
bader added reviewers: Anastasia, yaxunl.
bader added a subscriber: cfe-commits.
In order to re-define OpenCL built-in functions
'to_{private,local,global}' in OpenCL run-time library LLVM names must
be different from the clang built-in function names.
https://reviews
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
https://reviews.llvm.org/D23120
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
kparzysz added a comment.
Ping?
Repository:
rL LLVM
https://reviews.llvm.org/D22766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman requested changes to this revision.
This revision now requires changes to proceed.
Comment at: clang-tidy/modernize/UseAlgorithmCheck.cpp:25
@@ +24,3 @@
+
+static QualType getStrippedType(QualType T) {
+ while (const auto *PtrType = T->getAs())
I'd
klimek updated this revision to Diff 1.
klimek added a comment.
Fix bugs around marker replacements that neither insert nor delete anything.
https://reviews.llvm.org/D23119
Files:
lib/Tooling/Core/Replacement.cpp
unittests/Tooling/RefactoringTest.cpp
Index: unittests/Tooling/Refactorin
akuegel added a subscriber: akuegel.
akuegel added a comment.
lg
Comment at: lib/Tooling/Core/Replacement.cpp:163
@@ +162,3 @@
+ // Find the first entry that starts after the end of R.
+ // We cannot use upper_bound for that, as there might an element equal to
+ // AtEnd in R
Author: klimek
Date: Wed Aug 3 09:12:17 2016
New Revision: 277597
URL: http://llvm.org/viewvc/llvm-project?rev=277597&view=rev
Log:
Fix quadratic runtime when adding items to tooling::Replacements.
Previously, we would search through all replacements when inserting a
new one to check for overlap
NoQ added a comment.
Nice catch!
Now, this needs a test. How about this one:
// enable the debug.ExprInspection checker?
void clang_analyzer_eval(int);
void test_asume_after_access(unsigned long x) {
char buf[100];
buf[x] = 1;
clang_analyzer_eval(x <= 99); // expected-warnin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277597: Fix quadratic runtime when adding items to
tooling::Replacements. (authored by klimek).
Changed prior to commit:
https://reviews.llvm.org/D23119?vs=1&id=3#toc
Repository:
rL LLVM
htt
ioeric added inline comments.
Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:169
@@ +168,3 @@
+ // starts after R is (I+1).
+ if (I != Replaces.end() && *I == R)
+++I;
I think we should ignore replacement text when checking equality between `*I`
and
yaxunl added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:43
@@ +42,3 @@
+
+ return llvm::StructType::create(EleTypes, "ndrange_t");
+}
yaxunl wrote:
> struct name should be "struct.ndrange_t" to allow library code to access it.
Sorry, should be "
klimek added inline comments.
Comment at: cfe/trunk/lib/Tooling/Core/Replacement.cpp:169
@@ +168,3 @@
+ // starts after R is (I+1).
+ if (I != Replaces.end() && *I == R)
+++I;
ioeric wrote:
> I think we should ignore replacement text when checking equality b
NoQ accepted this revision.
This revision is now accepted and ready to land.
Comment at: lib/Analysis/CloneDetection.cpp:99
@@ +98,3 @@
+ /// Every item in this list is unique.
+ std::vector Variables;
+
NoQ wrote:
> I've a feeling this is essentially a `map`, b
baloghadamsoftware added a comment.
I agree with you. Do I have to modify the checker (in a separate patch), or
someone else can do it? I do not know how difficult it is to unpack the store
of a LazyCompoundVal (it probably has to be done recursively).
https://reviews.llvm.org/D22374
__
v.g.vassilev accepted this revision.
v.g.vassilev added a comment.
LGTM. My comments were clarified in a Skype chat.
https://reviews.llvm.org/D22982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
Author: klimek
Date: Wed Aug 3 10:12:00 2016
New Revision: 277603
URL: http://llvm.org/viewvc/llvm-project?rev=277603&view=rev
Log:
Fix bug in conflict check for Replacements::add().
We would not detect conflicts when inserting insertions at the same
offset as previously contained replacements.
NoQ added a comment.
Like!
Do you think that if we rename the ~~bike shed~~ option to
`-analyzer-list-enabled-checkers` it'd be more natural and easy to remember? (i
barely remember how to spell `-analyzer-checker-help`, it'd be much easier if
it was called `-analyzer-list-checkers`).
==
omtcyfz updated this revision to Diff 66670.
omtcyfz added a comment.
Merged multiple identical tests into a single test with multiple `clang-rename`
invocations.
https://reviews.llvm.org/D23058
Files:
clang-rename/USRFinder.cpp
clang-rename/USRFindingAction.cpp
test/clang-rename/Complex
omtcyfz marked 2 inline comments as done.
Comment at:
test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:3
@@ +2,3 @@
+// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i --
+// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s
+
alexfh wrote:
rnk added a comment.
Thanks! lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D23105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
xazax.hun added a comment.
In https://reviews.llvm.org/D23060#504832, @NoQ wrote:
> Like!
>
> Do you think that if we rename the ~~bike shed~~ option to
> `-analyzer-list-enabled-checkers` it'd be more natural and easy to remember?
> (i barely remember how to spell `-analyzer-checker-help`, it'
NoQ added a comment.
Hmm. I suggest:
1. Change this test's constructor so that it was no longer almost-trivial.
Because it isn't significant for this test if the constructor is almost-trivial
or not. The test would pass.
2. Add a FIXME-test for this checker, in which a completely undefined str
ahatanak added a subscriber: ahatanak.
ahatanak added a comment.
I'm wondering what the status of this patch is since someone has asked us to
add support for this attribute in clang. Are you still waiting for review?
Comment at: test/CodeGenCXX/alloc-size.cpp:66
@@ +65,3 @@
+
ahatanak added a comment.
ping
https://reviews.llvm.org/D21453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren created this revision.
manmanren added a reviewer: benlangmuir.
manmanren added a subscriber: cfe-commits.
We add -fmodules-use-prebuilt-modules to support using prebuilt modules. In
this mode, there is no need to load any module map and the programmer can
simply use "@import" syntax t
george.burgess.iv added a comment.
> I'm wondering what the status of this patch is since someone has asked us to
> add support for this attribute in clang. Are you still waiting for review?
Waiting for an LGTM from Richard, though this patch currently doesn't pass all
tests. One of the change
sepavloff added inline comments.
Comment at: test/SemaTemplate/default-expr-arguments-3.cpp:20
@@ +19,2 @@
+ }
+}
Please add the following test to the patch:
```
template void f1() {
enum class foo { a, b };
struct S {
int g1(foo n = foo::a);
};
}
temp
manmanren added inline comments.
Comment at: lib/Driver/Tools.cpp:5416
@@ -5408,1 +5415,3 @@
+ if (Args.getLastArg(options::OPT_fmodules_use_prebuilt_modules)) {
+// When using prebuilt modules, we disable module hash.
benlangmuir wrote:
> ```
> if (IsPrebu
benlangmuir added a comment.
How about -fmodules-use-prebuilt-**module-cache** for the flag name? Saying
"prebuilt-modules" is confusing to me, since -fmodule-file can also be used to
load a prebuilt module, but doesn't use a cache.
Comment at: lib/Driver/Tools.cpp:5416
@@ -5
Author: omtcyfz
Date: Wed Aug 3 13:15:07 2016
New Revision: 277623
URL: http://llvm.org/viewvc/llvm-project?rev=277623&view=rev
Log:
[docs] fix typo in clang-rename docs
clang-rename is a refactoring tool, not "linter" tool. Fix typo in docs.
Modified:
clang-tools-extra/trunk/docs/clang-ren
ahatanak added a comment.
OK, I'll add the test.
When I apply this patch and compile your test, I see DependentScopeDeclRefExpr
gets converted to DeclRefExpr when the function is instantiated. This doesn't
happen without this patch, but somehow clang still manages to emit the same
code.
Also,
JDevlieghere updated this revision to Diff 66688.
JDevlieghere marked 21 inline comments as done.
JDevlieghere added a comment.
Addresses comments from Aaron Ballman
@aaron.ballman Thanks for the thorough review! Can you check whether the tests
I added address your concerns? Could you also elabo
bkramer created this revision.
bkramer added a reviewer: alexfh.
bkramer added a subscriber: cfe-commits.
This is prone to ODR violations and generally frowned upon in many
codebases (e.g. LLVM). The checker flags definitions, variables and
classes in the global namespace. Common false positives l
ahatanak added inline comments.
Comment at: test/CodeGenCXX/alloc-size.cpp:66
@@ +65,3 @@
+ // CHECK: ret i32 122
+ return __builtin_object_size(my_malloc(), 0) +
+ __builtin_object_size(my_calloc(5), 0) +
george.burgess.iv wrote:
> ahatanak wrote:
> > I
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Please mention this check in docs/ReleaseNotes.rst (in alphabetical order).
https://reviews.llvm.org/D23130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
jfb added a comment.
@EricWF ran this on configuration `cxx_under_test=g++-4.9`. It generates the
following error:
libcxx/test/libcxx/atomics/atomics.align/align.pass.sh.cpp:32:
atomic_test::atomic_test() [with T = std::nullptr_t]: Assertion
`alignof(this->__a_) >= sizeof(this->__a_) && "exp
Author: yaxunl
Date: Wed Aug 3 15:38:06 2016
New Revision: 277647
URL: http://llvm.org/viewvc/llvm-project?rev=277647&view=rev
Log:
[OpenCL] Fix size of image type
The size of image type is reported incorrectly as size of a pointer to address
space 0, which causes error when casting image type
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277647: [OpenCL] Fix size of image type (authored by yaxunl).
Changed prior to commit:
https://reviews.llvm.org/D22927?vs=65964&id=66705#toc
Repository:
rL LLVM
https://reviews.llvm.org/D22927
Files
george.burgess.iv added inline comments.
Comment at: test/CodeGenCXX/alloc-size.cpp:66
@@ +65,3 @@
+ // CHECK: ret i32 122
+ return __builtin_object_size(my_malloc(), 0) +
+ __builtin_object_size(my_calloc(5), 0) +
ahatanak wrote:
> george.burgess.iv wro
Hi Eric,
After we upgraded our green dragon bots to El Captain (10.11), the
test below started to fail on some of our machines:
--
test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp
TEST_CASE(hard_link_count_for_directory)
{
uintmax_t DirExpect = 3;
alexfh created this revision.
alexfh added a reviewer: hokein.
alexfh added a subscriber: cfe-commits.
The misc-argument-comment check now ignores leading and trailing underscores and
case. The new `StrictMode` local/global option can be used to switch back to
strict checking.
Add getLocalOrGloba
bkramer updated this revision to Diff 66716.
bkramer added a comment.
Add relnote.
https://reviews.llvm.org/D23130
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/GlobalNamespaceCheck.cpp
clang-tidy/misc/GlobalNamespaceCheck.h
clang-tidy/misc/MiscTidyModule.cpp
docs/ReleaseNotes
alexfh added a comment.
Do we want to merge this check with google/GlobalNamesInHeadersCheck.cpp that
targets a similar set of issues?
Repository:
rL LLVM
https://reviews.llvm.org/D23130
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
On Wed, Aug 3, 2016 at 5:17 PM, Alexander Kornienko wrote:
> alexfh added a comment.
>
> Do we want to merge this check with google/GlobalNamesInHeadersCheck.cpp that
> targets a similar set of issues?
We also have misc/DefinitionsInHeadersCheck.cpp which is likely similar.
~Aaron
>
>
> Reposi
bkramer added a comment.
DefinitionsInHeaders is tackling a different problem. IMO DefinitionsInHeaders
is something that should be on by default everywhere, while this check for
definitions in the global namespace is more of a coding style issue.
GlobalNamesInHeaders is a bit of a misnomer, it
jfb added a comment.
I wrote a quick test, and I think this is technically OK for x86 because
alignment "Just Works", but I think it's borked on GCC+ARM (I don't have a
system to test that here):
https://github.com/jfbastien/atomic_nullptr/blob/master/atomic_nullptr.cc
https://reviews.llvm.or
Author: hubert.reinterpretcast
Date: Wed Aug 3 17:07:50 2016
New Revision: 277658
URL: http://llvm.org/viewvc/llvm-project?rev=277658&view=rev
Log:
[Concepts] remove default argument for RequiresClause; NFC
Modified:
cfe/trunk/include/clang/AST/DeclTemplate.h
Modified: cfe/trunk/include/cla
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D23058
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh added a comment.
In https://reviews.llvm.org/D23130#505242, @bkramer wrote:
> DefinitionsInHeaders is tackling a different problem. IMO
> DefinitionsInHeaders is something that should be on by default everywhere,
> while this check for definitions in the global namespace is more of a cod
Author: omtcyfz
Date: Wed Aug 3 18:00:32 2016
New Revision: 277663
URL: http://llvm.org/viewvc/llvm-project?rev=277663&view=rev
Log:
[clang-rename] improve USRFindingAction
1. Improve templated class renaming, namely add capabilities of finding partial
and full specializations. Every class parti
This revision was automatically updated to reflect the committed changes.
omtcyfz marked an inline comment as done.
Closed by commit rL277663: [clang-rename] improve USRFindingAction (authored by
omtcyfz).
Changed prior to commit:
https://reviews.llvm.org/D23058?vs=66670&id=66728#toc
Repositor
cdavis5x updated this revision to Diff 66729.
cdavis5x added a comment.
Update for merge conflicts.
- Add a blurb to the docs advising against using this attribute with
`__forceinline`, `always_inline`, or `naked`.
https://reviews.llvm.org/D19909
Files:
include/clang/Basic/Attr.td
include
cdavis5x marked an inline comment as done.
Comment at: include/clang/Basic/AttrDocs.td:560
@@ +559,3 @@
+
+This attribute cannot be used in conjunction with the ``naked``,
+``always_inline``, or ``__forceinline`` attributes.
Done.
https://reviews.llvm.org/D19909
Author: alexfh
Date: Wed Aug 3 18:06:03 2016
New Revision: 277677
URL: http://llvm.org/viewvc/llvm-project?rev=277677&view=rev
Log:
[clang-tidy] Inefficient string operation
Patch by Bittner Barni!
Differential revision: https://reviews.llvm.org/D20196
Added:
clang-tools-extra/trunk/clang
This revision was automatically updated to reflect the committed changes.
Closed by commit rL277677: [clang-tidy] Inefficient string operation (authored
by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D20196?vs=66492&id=66730#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
ahatanak added a comment.
In each of these cases, "foo::a" is a non-dependent type, so it seems that
clang shouldn't use DependentScopeDeclRefExpr or CXXDependentScopeMemberExpr in
the AST when the template definitions are parsed.
https://reviews.llvm.org/D23096
timshen created this revision.
timshen added reviewers: dblaikie, chandlerc.
timshen added a subscriber: cfe-commits.
The corresponding LLVM change is D23146.
https://reviews.llvm.org/D23147
Files:
include/clang/AST/StmtGraphTraits.h
include/clang/Analysis/Analyses/Dominators.h
include/cla
Eugene.Zelenko added a comment.
Please see PR28836. In some cases check should recommend to use insert().
Repository:
rL LLVM
https://reviews.llvm.org/D20196
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
Prazek added a comment.
In https://reviews.llvm.org/D22725#505020, @JDevlieghere wrote:
> Addresses comments from Aaron Ballman
>
> @aaron.ballman Thanks for the thorough review! Can you check whether the
> tests I added address your concerns? Could you also elaborate on the case
> with the C-f
Prazek added a subscriber: Prazek.
Prazek added a comment.
LG(TM)
https://reviews.llvm.org/D23135
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added inline comments.
Comment at: clang-tidy/misc/GlobalNamespaceCheck.cpp:46
@@ +45,3 @@
+// extern "C" globals need to be in the global namespace.
+if (VDecl->isExternC())
+ return;
I think it would be better to check it in matcher.
I see th
echristo added a comment.
You haven't removed the custom handling?
-eric
Repository:
rL LLVM
https://reviews.llvm.org/D22766
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Alexander_Droste marked 3 inline comments as done.
Alexander_Droste added a comment.
https://reviews.llvm.org/D22729
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: echristo
Date: Thu Aug 4 01:02:50 2016
New Revision: 277696
URL: http://llvm.org/viewvc/llvm-project?rev=277696&view=rev
Log:
After PR28761 use -Wall with -Werror in builtins tests to identify
possible problems in headers.
Modified:
cfe/trunk/test/CodeGen/3dnow-builtins.c
cfe/tru
Alexander_Droste updated this revision to Diff 66760.
Alexander_Droste added a comment.
- clarify lambda argument with comment
- explicit cast to `int` for the number of indirections in for loop
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/Buffer
Alexander_Droste updated this revision to Diff 66761.
Alexander_Droste added a comment.
- add needed extra line for docs
https://reviews.llvm.org/D22729
Files:
clang-tidy/mpi/BufferDerefCheck.cpp
clang-tidy/mpi/BufferDerefCheck.h
clang-tidy/mpi/CMakeLists.txt
clang-tidy/mpi/MPITidyModul
echristo added a comment.
Seems reasonable to fix the tests?
https://reviews.llvm.org/D22943
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK, please go back and document in ToolChain.h the difference between the
Triple and the EffectiveTriple - at length, as a follow on patch.
-eric
https://reviews.llvm.org/D22944
_
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
OK.
-eric
https://reviews.llvm.org/D22945
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
84 matches
Mail list logo
