omtcyfz added inline comments. ================ Comment at: test/clang-rename/TemplateClassInstantiationFindByUninstantiatedType.cpp:2 @@ +1,3 @@ +// RUN: cat %s > %t.cpp +// RUN: clang-rename -offset=440 -new-name=Bar %t.cpp -i -- +// RUN: sed 's,//.*,,' %t.cpp | FileCheck %s ---------------- alexfh wrote: > This test looks exactly as the one above except for the offset. Instead of > duplicating tests, we can run clang-rename multiple times and use different > -check-prefix with FileCheck. In this case moving the RUN lines to the bottom > makes even more sense. > > Also, instructions for updating -offset are incorrect, if you have multiple > different offsets. Will it work if I add multiple invocations while not adding different `-check-prefix`? The replacements are the same across the runs.
https://reviews.llvm.org/D23058 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
