manmanren added inline comments.
================
Comment at: lib/Driver/Tools.cpp:5416
@@ -5408,1 +5415,3 @@
+ if (Args.getLastArg(options::OPT_fmodules_use_prebuilt_modules)) {
+ // When using prebuilt modules, we disable module hash.
----------------
benlangmuir wrote:
> ```
> if (IsPrebuilt) {
> ```
Will do.
================
Comment at: lib/Frontend/CompilerInstance.cpp:1491
@@ +1490,3 @@
+ false/*IsExplicit*/).first;
+ Module->IsSystem = true;
+ Module->IsFromModuleFile = true;
----------------
benlangmuir wrote:
> Why do we assume this?
Thanks for reviewing so quickly!
I was not sure about what value we should set IsSystem. Since we are mostly
prebuilding system modules, I assumed "true". Do you have any suggestion here?
https://reviews.llvm.org/D23125
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
