craig.topper added a comment.
This change seems consistent with similar being done in r250158 when the other
xsave intrinsics were added. intrin.h includes x86intrin.h which in turn
includes xsaveintrin.h. So this just makes xgetbv/xsetbv available on
non-microsoft platforms.
Thanks! This is really handy interface. Would it make sense adding the
same for NamespaceDecl for consistency?
On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote:
Author: akirtzidis
Date: Fri Jul 15 13:11:33 2016
New Revision: 275590
URL: http://llvm.org/viewvc/llvm-project?rev=275590&
(forgot to click "reply all")
Thanks! This is really handy interface. Would it make sense adding the
same for NamespaceDecl for consistency?
On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote:
Author: akirtzidis
Date: Fri Jul 15 13:11:33 2016
New Revision: 275590
URL: http://llvm.org/
Yes please :)
On 25 Jul 2016 10:13 p.m., "Vassil Vassilev via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
> It could, it fixes a set of issues wrt to modules.
> On 25/07/16 22:39, Hans Wennborg wrote:
>
>> Should this be merged to 3.9?
>>
>> On Fri, Jul 22, 2016 at 2:08 PM, Vassil Vassilev
NoQ added a comment.
Thanks for working on this!
While i probably won't be of much help (no expert in temporaries yet), i notice
that this code piece (with `getReferenceInitTemporaryType()`) seems to be
duplicated at least three times in this file, with slight variations and
FIXMEs. So i guess
mboehme updated this revision to Diff 65484.
mboehme marked an inline comment as done.
mboehme added a comment.
Changes in response to reviewer comments
https://reviews.llvm.org/D0
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/MiscTidyModule.cpp
clang-tidy/misc/MoveForwardingR
mboehme marked 13 inline comments as done.
Comment at: clang-tidy/misc/MoveForwardingReferenceCheck.cpp:20
@@ +19,3 @@
+
+static void ReplaceMoveWithForward(const UnresolvedLookupExpr *Callee,
+ const TemplateTypeParmType *TypeParmType,
--
Anastasia added inline comments.
Comment at: lib/Sema/SemaInit.cpp:6945
@@ +6944,3 @@
+ // get the integer literal.
+ Init = cast(const_cast(
+Var->getInit()))->getSubExpr();
Could you please take a look at the new diagnostics you are
zlei updated this revision to Diff 65497.
zlei added a comment.
Herald added subscribers: srhines, danalbert, tberghammer.
Support a new option `-rtlib=platform` for internal use, and fix tests that
previously failed when configured with `CLANG_DEFAULT_RTLIB=compiler-rt`.
https://reviews.llvm.o
zlei added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
I think the original code for resetting `CLANG_DEFAULT_CXX_STDLIB` do
Hahnfeld added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
zlei wrote:
> I think the original code for resetting `CLANG_DEFA
hokein created this revision.
hokein added reviewers: alexfh, djasper.
hokein added a subscriber: cfe-commits.
The check doesn't mark the template argument as used when the template
argument is a template.
https://reviews.llvm.org/D22803
Files:
clang-tidy/misc/UnusedUsingDeclsCheck.cpp
test/
NoQ added inline comments.
Comment at: lib/Analysis/CloneDetection.cpp:148
@@ +147,3 @@
+
+// FIXME: This function has quadratic runtime right now. Check if skipping
+// this function for too long CompoundStmts is an option.
I've a feeling this comment was
zlei added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
Hahnfeld wrote:
> zlei wrote:
> > I think the original code for reset
honggyu.kim added a comment.
In https://reviews.llvm.org/D22666#493708, @rjmccall wrote:
> Note that the presence of the mcount call itself will significantly impact
> inlining and, really, the entire optimization pipeline. Having this be a
> late pass seems more in keeping with what I assume
massberg created this revision.
massberg added reviewers: bkramer, hokein.
massberg added a subscriber: cfe-commits.
[clang-include-fixer] Added Emacs integration for clang-include-fixer.
https://reviews.llvm.org/D22805
Files:
include-fixer/tool/clang-include-fixer.el
Index: include-fixer/too
teemperor updated this revision to Diff 65506.
teemperor added a comment.
- Now passing ChildSignatures by const reference.
https://reviews.llvm.org/D20795
Files:
include/clang/Analysis/CloneDetection.h
include/clang/StaticAnalyzer/Checkers/Checkers.td
lib/Analysis/CMakeLists.txt
lib/An
honggyu.kim added a comment.
One more problem is that -finstrument-functions has the same inlining problem.
The code in `llvm/tools/clang/lib/CodeGen/CodeGenFunction.cpp` shows that.
void CodeGenFunction::StartFunction(GlobalDecl GD,
QualType RetTy,
CrisCristescu updated this revision to Diff 65508.
CrisCristescu marked an inline comment as done.
CrisCristescu added a comment.
Some more cosmetics.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
l
hokein added a comment.
Nice! Thanks very much for making emacs integration. I'm not familiar with
elisp, but it looks almost good to me. Just a few nits.
Comment at: include-fixer/tool/clang-include-fixer.el:8
@@ +7,3 @@
+
+;; This package allows to envoke the 'clnag-include-f
Author: mboehme
Date: Tue Jul 26 09:01:48 2016
New Revision: 276746
URL: http://llvm.org/viewvc/llvm-project?rev=276746&view=rev
Log:
Test commit -- adding a newline
Modified:
clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp
Modified: clang-tools-extra/trunk/clang-tidy/m
Hahnfeld added a comment.
There is also the other way round: `CLANG_DEFAULT_RTLIB=libgcc` shows that
Darwin doesn't support that and gets a `SIGSEGV` (because it doesn't expect it
to be `libgcc` without an option to be set, hehe)
Based on some `GetCXXStdlibType` for toolchains that only support
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
[Tooling] skip anonymous namespaces when checking if typeLoc
references a type decl from a different canonical namespace.
https://reviews.llvm.org/D22808
Fil
klimek added inline comments.
Comment at: unittests/Tooling/RefactoringTest.cpp:112
@@ -111,4 +111,3 @@
-TEST_F(ReplacementTest, CanApplyReplacements) {
- FileID ID = Context.createInMemoryFile("input.cpp",
- "line1\nline2\nline3\nline4")
sylvestre.ledru created this revision.
sylvestre.ledru added reviewers: zaks.anna, rizsotto.mailinglist.
sylvestre.ledru added a subscriber: cfe-commits.
This patch adds an option //--show-description// to add the defect description
to the list of defect. This helps to get a better understanding
Author: marshall
Date: Tue Jul 26 09:28:34 2016
New Revision: 276750
URL: http://llvm.org/viewvc/llvm-project?rev=276750&view=rev
Log:
Implement LCM and GCD for Library Fundamentals. Reviewed as
https://reviews.llvm.org/D21343.
Added:
libcxx/trunk/include/experimental/numeric
libcxx/trun
Author: marshall
Date: Tue Jul 26 09:29:45 2016
New Revision: 276751
URL: http://llvm.org/viewvc/llvm-project?rev=276751&view=rev
Log:
Implement LCM and GCD for C++17. Same code as for Library Fundamentals TS.
Added:
libcxx/trunk/test/std/numerics/numeric.ops/numeric.ops.gcd/
libcxx/trun
Author: mboehme
Date: Tue Jul 26 09:37:39 2016
New Revision: 276752
URL: http://llvm.org/viewvc/llvm-project?rev=276752&view=rev
Log:
Revert test commit
This reverts rL276746.
Modified:
clang-tools-extra/trunk/clang-tidy/misc/MoveConstantArgumentCheck.cpp
Modified: clang-tools-extra/trunk/c
Author: ioeric
Date: Tue Jul 26 09:53:05 2016
New Revision: 276754
URL: http://llvm.org/viewvc/llvm-project?rev=276754&view=rev
Log:
[Tooling] skip anonymous namespaces when checking if typeLoc references a type
decl from a different canonical namespace.
Summary:
[Tooling] skip anonymous namespa
massberg updated this revision to Diff 65521.
massberg added a comment.
Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs
integration for clang-include-fixer.
- Fixed typo
- Added documentation how to setup tools within emacs
- Removed unnecessary yes-no question
http
ayartsev added inline comments.
Comment at: test/Analysis/PR12421.c:11
@@ +10,2 @@
+
+// CHECK: warning: Path diagnostic report is not generated. HTMLDiagnostics
does not support diagnostics that cross file boundaries.
zaks.anna wrote:
> We should use the name of
ayartsev updated this revision to Diff 65519.
ayartsev marked 2 inline comments as done.
https://reviews.llvm.org/D22494
Files:
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
test/Analysis/diagnostics/diag-cross-file-boundaries.c
test/Analysis/diagnostics/diag-cross-file-boundaries.h
Index: te
bkramer added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.el:8
@@ +7,3 @@
+
+;; This package allows to invoke the 'clnag-include-fixer' within Emacs.
+;; 'clang-include-fixer' provides an automated way of adding #include
clnag is another ty
massberg updated this revision to Diff 65524.
massberg added a comment.
Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs
integration for clang-include-fixer.
-Fixed documentation
https://reviews.llvm.org/D22805
Files:
docs/include-fixer.rst
include-fixer/tool/cl
massberg updated this revision to Diff 65525.
massberg added a comment.
Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs
integration for clang-include-fixer.
- Fixed typo
https://reviews.llvm.org/D22805
Files:
docs/include-fixer.rst
include-fixer/tool/clang-incl
massberg marked 3 inline comments as done.
massberg added a comment.
Thanks for the comments. I fixed the typos and wrote a (short) documentation.
https://reviews.llvm.org/D22805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
v.g.vassilev requested changes to this revision.
v.g.vassilev added a reviewer: v.g.vassilev.
This revision now requires changes to proceed.
Comment at: lib/Lex/Preprocessor.cpp:748
@@ +747,3 @@
+ if (Result.is(tok::code_completion))
+ setCodeCompletionIdentifierInfo(Result.
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276754: [Tooling] skip anonymous namespaces when checking if
typeLoc references a… (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D22808?vs=65511&id=65520#toc
Repository:
rL
klimek added a reviewer: rnk.
klimek added a comment.
+Reid for a windows reviewer
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: majnemer
Date: Tue Jul 26 10:21:18 2016
New Revision: 276756
URL: http://llvm.org/viewvc/llvm-project?rev=276756&view=rev
Log:
Update for LLVM changes
InstSimplify has gained the ability to remove needless bitcasts which
perturbed some clang codegen tests.
Modified:
cfe/trunk/test/Co
beanz added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
Hahnfeld wrote:
> zlei wrote:
> > Hahnfeld wrote:
> > > zlei wrote:
Author: mboehme
Date: Tue Jul 26 10:19:10 2016
New Revision: 276755
URL: http://llvm.org/viewvc/llvm-project?rev=276755&view=rev
Log:
Make RecursiveASTVisitor visit lambda capture initialization expressions
Summary:
Lambda capture initializations are part of the explicit source code and
therefor
Anastasia added inline comments.
Comment at: test/Misc/amdgcn.languageOptsOpenCL.cl:188
@@ +187,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
ashi1 wrote:
> yaxunl wrote:
> > Anastasia wrote:
> > > Ca
CrisCristescu updated this revision to Diff 65528.
CrisCristescu added a comment.
Wrong indentation update.
Repository:
rL LLVM
https://reviews.llvm.org/D17820
Files:
include/clang/Lex/Preprocessor.h
include/clang/Sema/CodeCompleteConsumer.h
lib/Lex/Lexer.cpp
lib/Lex/Preprocessor.cpp
hokein created this revision.
hokein added a reviewer: bkramer.
hokein added a subscriber: cfe-commits.
In missing complete type cases, we don't know where to add the qualifiers.
https://reviews.llvm.org/D22812
Files:
include-fixer/IncludeFixer.cpp
unittests/include-fixer/IncludeFixerTest.cp
Anastasia added inline comments.
Comment at: test/SemaOpenCL/extension-version.cl:228
@@ +227,3 @@
+#endif
+// expected-warning@+6{{unsupported OpenCL extension 'cl_khr_mipmap_image' -
ignoring}}
+#else
Anastasia wrote:
> ashi1 wrote:
> > Anastasia wrote:
> > > C
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276755: Make RecursiveASTVisitor visit lambda capture
initialization expressions (authored by mboehme).
Changed prior to commit:
https://reviews.llvm.org/D22566?vs=64665&id=65526#toc
Repository:
rL L
klimek added a comment.
Kirill, are your specific concerns addressed?
https://reviews.llvm.org/D21814
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.el:126
@@ +125,3 @@
+ (setq header-infos (plist-get include-fixer-context :HeaderInfos))
+ (setq symbol (plist-get include-fixer-context :SymbolIdentifier))
+ (setq symbol-offset (plist-get (plist-
Merged to 3.9 in r276757.
Cheers,
Hans
On Tue, Jul 26, 2016 at 2:01 AM, Richard Smith wrote:
> Yes please :)
>
>
> On 25 Jul 2016 10:13 p.m., "Vassil Vassilev via cfe-commits"
> wrote:
>>
>> It could, it fixes a set of issues wrt to modules.
>> On 25/07/16 22:39, Hans Wennborg wrote:
>>>
>>> Sh
yaxunl created this revision.
yaxunl added reviewers: tstellarAMD, arsenm, nhaustov, Anastasia, rsmith.
yaxunl added a subscriber: cfe-commits.
Herald added a subscriber: kzhuravl.
Adjust target features for amdgcn target when -cl-denorms-are-zero is set.
Denormal support is controlled by feature
Author: mboehme
Date: Tue Jul 26 11:01:55 2016
New Revision: 276759
URL: http://llvm.org/viewvc/llvm-project?rev=276759&view=rev
Log:
Revert "Make RecursiveASTVisitor visit lambda capture initialization
expressions"
This reverts commit r276755.
(Broke clang-tidy check modernize-loop-convert.)
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
Silence another occurrence of MSVC's spurious unused warning.
Again, I'm sorry about this one (VSO#188582 tracks the need to fix the
compiler), but this targeted suppression h
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
This is optional, but I think it would be convenient if we could upstream the
ignoring of env.lst and keep.lst files that our test harness automatically
generates.
https://re
hfinkel added a comment.
In https://reviews.llvm.org/D22666#495978, @honggyu.kim wrote:
> In https://reviews.llvm.org/D22666#493708, @rjmccall wrote:
>
> > Note that the presence of the mcount call itself will significantly impact
> > inlining and, really, the entire optimization pipeline. Havi
majnemer added a subscriber: majnemer.
majnemer added a comment.
Do we have a way to keep track of this change so we can remove it when MSVC
gets fixed?
https://reviews.llvm.org/D22818
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
I've added a note to myself (in the list of "bugs I need fixes for") that these
two suppressions should be removed when the compiler bug is finally fixed.
JonCaves actually marked this as Fix Available on July 20, so a fix may be
forthcoming in the near future.
STL
-Original Message-
F
benlangmuir accepted this revision.
benlangmuir added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D22773
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
hiraditya added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
We are looking at the libcxx testsuite, it seems there are only
correctness/functionality tests. Do you have any pointers on how to add tests
to
Author: hokein
Date: Tue Jul 26 11:32:42 2016
New Revision: 276761
URL: http://llvm.org/viewvc/llvm-project?rev=276761&view=rev
Log:
[include-fixer] Don't add qualifiers in missing complete type cases.
Summary: In missing complete type cases, we don't know where to add the
qualifiers.
Reviewers
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276761: [include-fixer] Don't add qualifiers in missing
complete type cases. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D22812?vs=65531&id=65544#toc
Repository:
rL LLVM
nandor updated this revision to Diff 65545.
nandor marked an inline comment as done.
nandor added a comment.
removed redundant checks
https://reviews.llvm.org/D22419
Files:
lib/Analysis/CFG.cpp
test/SemaCXX/warn-thread-safety-analysis.cpp
Index: test/SemaCXX/warn-thread-safety-analysis.cpp
nandor added a comment.
I'm not an expert in temporaries either, I think for a proper fix a lot more
work is required.
It seems that the problem is with locating destructors in destructor calls. I
get the impression that currently a destructor node pointing to the declaration
is added and the
Yes, I think so.
> On Jul 26, 2016, at 1:37 AM, Vassil Vassilev wrote:
>
> (forgot to click "reply all")
> Thanks! This is really handy interface. Would it make sense adding the same
> for NamespaceDecl for consistency?
> On 15/07/16 20:11, Argyrios Kyrtzidis via cfe-commits wrote:
>> Author: a
massberg updated this revision to Diff 65546.
massberg added a comment.
Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs
integration for clang-include-fixer.
Now working with the newest clang-include-fixer input/output format.
https://reviews.llvm.org/D22805
Files:
massberg marked an inline comment as done.
massberg added a comment.
Thanks, now supporting the new format.
https://reviews.llvm.org/D22805
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
hokein added inline comments.
Comment at: include-fixer/tool/clang-include-fixer.el:32
@@ +31,3 @@
+ "google3"
+
"/usr/local/google/home/massberg/Emacs_Lisp/include-fixer/clang-include-fixer
input format."
+ :group 'clang-include-fixer
You forgot to remove th
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276769: Modules: add command line option
fmodules-disable-diagnostic-validation (authored by mren).
Changed prior to commit:
https://reviews.llvm.org/D22773?vs=65449&id=65548#toc
Repository:
rL LLVM
Author: mren
Date: Tue Jul 26 12:12:17 2016
New Revision: 276769
URL: http://llvm.org/viewvc/llvm-project?rev=276769&view=rev
Log:
Modules: add command line option fmodules-disable-diagnostic-validation
With PCH+Module, sometimes compiler gives a hard error:
Module file ‘.pcm' is out of date and
aaboud added reviewers: erichkeane, bwyma.
aaboud updated this revision to Diff 65551.
aaboud added a comment.
Updated patch to top of trunk (r276746) - Thanks to Ranjeet Singh.
Please, provide your feedback.
https://reviews.llvm.org/D16135
Files:
include/clang/AST/ASTConsumer.h
lib/AST/AS
NoQ accepted this revision.
NoQ added a reviewer: NoQ.
NoQ added a comment.
Great! Will commit.
https://reviews.llvm.org/D20795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hubert.reinterpretcast created this revision.
hubert.reinterpretcast added reviewers: aaron.ballman, faisalv, rsmith.
hubert.reinterpretcast added a subscriber: cfe-commits.
This change adds `LLVM_CONSTEXPR` to functions selected as follows:
- the body is already valid under C++11 for a `constexpr
hfinkel added a comment.
In https://reviews.llvm.org/D22666#496218, @hfinkel wrote:
> In https://reviews.llvm.org/D22666#495978, @honggyu.kim wrote:
>
> > In https://reviews.llvm.org/D22666#493708, @rjmccall wrote:
> >
> > > Note that the presence of the mcount call itself will significantly
> >
massberg updated this revision to Diff 65562.
massberg added a comment.
Updating https://reviews.llvm.org/D22805: [clang-include-fixer] Added Emacs
integration for clang-include-fixer.
- fixed private path
- removed debug message
https://reviews.llvm.org/D22805
Files:
docs/include-fixer.rst
massberg marked 2 inline comments as done.
massberg added a comment.
Thanks for the comments!
Comment at: include-fixer/tool/clang-include-fixer.el:125
@@ +124,3 @@
+ ;; The header-infos is already sorted by include-fixer.
+ (setq header-infos (plist-get include-fixer-context
This revision was automatically updated to reflect the committed changes.
Closed by commit rL276782: [analyzer] Add basic capabilities to detect source
code clones. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D20795?vs=65506&id=65563#toc
Repository:
rL LLVM
ht
vsk accepted this revision.
vsk added a comment.
This revision is now accepted and ready to land.
LGTM.
Let me know if you'd like me to commit this for you.
Repository:
rL LLVM
https://reviews.llvm.org/D22798
___
cfe-commits mailing list
cfe-com
Author: dergachev
Date: Tue Jul 26 13:13:12 2016
New Revision: 276782
URL: http://llvm.org/viewvc/llvm-project?rev=276782&view=rev
Log:
[analyzer] Add basic capabilities to detect source code clones.
This patch adds the CloneDetector class which allows searching source code
for clones.
For every
Prazek added inline comments.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:115
@@ -95,1 +114,3 @@
+ auto CtorCallSourceRange = CharSourceRange::getTokenRange(
+ InnerCtorCall->getExprLoc(), CallParensRange.getBegin());
alexfh wrote:
> This doesn't
Artem,
I think you broke the build. Could you take a look please?
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/11051
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/11051/steps/build%20clang/logs/stdio
[80/140] Building CXX object
tools/clang/lib/
Author: dergachev
Date: Tue Jul 26 14:05:22 2016
New Revision: 276791
URL: http://llvm.org/viewvc/llvm-project?rev=276791&view=rev
Log:
[analyzer] Hotfix for build failure due to declaration shadowing in r276782.
CloneDetector member variable is shadowing the class with the same name,
which cause
Yep, sorry, should be fixed in r276791.
On 26.07.2016 22:13, Mike Aizatsky wrote:
Artem,
I think you broke the build. Could you take a look please?
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/builds/11051
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fuzzer/build
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D21385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
Author: mren
Date: Tue Jul 26 14:56:12 2016
New Revision: 276797
URL: http://llvm.org/viewvc/llvm-project?rev=276797&view=rev
Log:
Modules: follow up to r276769.
In r276769, I forgot to forward the driver option, add that here.
rdar://26675801
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modif
ashi1 updated this revision to Diff 65582.
ashi1 added a comment.
Revised based on Anastasia's comments. Restructured the if statements in test
cases.
Repository:
rL LLVM
https://reviews.llvm.org/D22637
Files:
include/clang/Basic/OpenCLExtensions.def
lib/Basic/Targets.cpp
test/Misc/am
Hi Justin,
Could you take a look at this code coverage fix?
It skips visiting decls if they would require context from system headers to
present properly. This prevents us from writing out an empty coverage mapping
for the lambda in `assert([] { return true; }());`.
I think it would be a good id
yaxunl updated this revision to Diff 65588.
yaxunl marked an inline comment as done.
yaxunl added a comment.
Add more sema tests. Eliminate redundant diagnostic messages.
https://reviews.llvm.org/D21567
Files:
include/clang/AST/OperationKinds.def
include/clang/Basic/DiagnosticGroups.td
in
Vedant Kumar via cfe-commits writes:
> Hi Justin,
>
> Could you take a look at this code coverage fix?
>
> It skips visiting decls if they would require context from system headers to
> present properly. This prevents us from writing out an empty coverage mapping
> for the lambda in `assert([] { r
Thanks Justin!
@Hans, could we take this for llvm 3.9 also?
best,
vedant
> On Jul 26, 2016, at 1:39 PM, Justin Bogner wrote:
>
> Vedant Kumar via cfe-commits writes:
>> Hi Justin,
>>
>> Could you take a look at this code coverage fix?
>>
>> It skips visiting decls if they would require cont
Sure, r276801.
Thanks,
Hans
On Tue, Jul 26, 2016 at 1:41 PM, Vedant Kumar wrote:
> Thanks Justin!
>
> @Hans, could we take this for llvm 3.9 also?
>
> best,
> vedant
>
>> On Jul 26, 2016, at 1:39 PM, Justin Bogner wrote:
>>
>> Vedant Kumar via cfe-commits writes:
>>> Hi Justin,
>>>
>>> Could y
erik.pilkington updated this revision to Diff 65595.
erik.pilkington added a comment.
Thanks for taking a look!
This new patch makes a `getCurContextVersion` (now `getVersionForDecl`) take a
parameter, which is the declaration that needs to be considered. This is so
that we can later reuse it t
echristo added a comment.
Why isn't the existing +long-calls handling good enough (other than making it a
generic option rather than arm specific)? You don't seem to be using any of the
code in Targets.cpp to do anything.
Also a couple of random comments inline on the patch.
-eric
==
bittnerbarni updated this revision to Diff 65606.
https://reviews.llvm.org/D20196
Files:
clang-tidy/performance/CMakeLists.txt
clang-tidy/performance/InefficientStringConcatenationCheck.cpp
clang-tidy/performance/InefficientStringConcatenationCheck.h
clang-tidy/performance/PerformanceTidy
One of the reasons we added the minimum was because these nodes added
overhead to the matching that was not unnecessary when they only had a
single node.
On the current implementation we could actually get rid of the node
completely for the one argument calls.
I would be ok with removing the lower
We could also just add nothing() matcher, so debugging would be much
easier, just add anything() or nothing() matcher as extra argument.
The other pros of it is that new developers won't send the patches that
uses those variadic matchers with only one argument.
2016-07-26 16:02 GMT-07:00 Zac Hans
I was wondering if there is any objection to removing the 2-element minimum
on the eachOf, anyOf and allOf matchers.
It is frustrating when playing with matchers to have to edit significant
amounts of code to be able to temporarily go from 2 to 1 matcher inside an
any- or allOf matcher.
And overa
laxmansole created this revision.
laxmansole added reviewers: mclow.lists, howard.hinnant.
laxmansole added subscribers: cfe-commits, sebpop, hiraditya, evandro,
flyingforyou.
Currently basic_string's destructor is not getting inlined. So adding 'inline'
attribute to ~basic_string().
Worked i
Even if it still did add overhead, it seems perfectly reasonable, from a
user's perspective (namely mine), that if I introduce unnecessary narrowing
matchers to my chain that there may be a performance penalty.
The ability to do the following easily outweighs any performance issues for
me:
anyOf
laxmansole added a comment.
In https://reviews.llvm.org/D22782#495436, @mclow.lists wrote:
> Do we have a test for the problem that this is solving?
$ cat foo.cpp
int foo(const std::string name);
int main(){
return foo("bar");
}
$clang++ -S -O3 -fno-exceptions foo.cpp
Assembly ou
DaveBartolomeo updated this revision to Diff 65633.
DaveBartolomeo added a comment.
Herald added a subscriber: samparker.
Updated the selection algorithm based on review feedback. Now, if clang.exe
itself is x64-hosted, we'll look for the x64-hosted MSVC toolset if it exists.
If clang.exe is not
1 - 100 of 116 matches
Mail list logo
