Hahnfeld added inline comments.
================
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
----------------
zlei wrote:
> I think the original code for resetting `CLANG_DEFAULT_CXX_STDLIB` doesn't
> work as expected, as beanz pointed out.
>
> In this revision, I just disable invalid values for both
> `CLANG_DEFAULT_CXX_STDLIB` and `CLANG_DEFAULT_RTLIB`. Users will get a error
> message when assigning unsupported values to them.
I tested it this morning and it works as (at least I) expected: It will
temporarily reset the value and warn the user that the parameter is not valid.
I'm against erroring out here because there actually is a sane default value...
https://reviews.llvm.org/D22663
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
