Re: [PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

2016-03-19 Thread David Blaikie via cfe-commits
On Fri, Mar 18, 2016 at 11:08 AM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rnk added a comment. > > I'm not sure your example is in scope for -Wshadow, though. Any function > call that takes a non-const reference to the parameter could modify it. Sure - my argument is

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

2016-03-19 Thread Steve Downey via cfe-commits
sdowney updated this revision to Diff 51000. sdowney added a comment. Add tests for FixIts http://reviews.llvm.org/D18191 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ConstRefBuiltinCheck.cpp clang-tidy/misc/ConstRefBuiltinCheck.h clang-tidy/misc/MiscTidyModule.cpp docs/clang

[PATCH] D18294: clang-format: [JS] no space in union and intersection types.

2016-03-19 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. | and & in types, as opposed to the bitwise operators, should not have whitespace around them (e.g. `Foo`). http://reviews.llvm.org/D18294 Files: lib/Fo

r263794 - Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers

2016-03-19 Thread Mike Spertus via cfe-commits
Author: mps Date: Fri Mar 18 11:38:34 2016 New Revision: 263794 URL: http://llvm.org/viewvc/llvm-project?rev=263794&view=rev Log: Show members of DeclContexts (i.e., class members) in Visual Studio native visualizers This change shows members of DeclContext objects in the Visual Studio debugger.

r263732 - Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops

2016-03-19 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Thu Mar 17 13:28:16 2016 New Revision: 263732 URL: http://llvm.org/viewvc/llvm-project?rev=263732&view=rev Log: Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops (addresses MSVC build error, since MSVC 2013 can't gen

r263748 - Reapply [VFS] Add 'overlay-relative' field to YAML files

2016-03-19 Thread Bruno Cardoso Lopes via cfe-commits
Author: bruno Date: Thu Mar 17 16:11:23 2016 New Revision: 263748 URL: http://llvm.org/viewvc/llvm-project?rev=263748&view=rev Log: Reapply [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552. The VFS overlay mapping between virtual paths and real paths is done through the 'e

Re: [PATCH] D17951: Implement is_always_lock_free

2016-03-19 Thread JF Bastien via cfe-commits
jfb added a comment. In http://reviews.llvm.org/D17951#376546, @bcraig wrote: > Visual Studio has a flag, /Zc:wchar_t-, that turns wchar_t into a short. > This flag is for people that need to maintain ABI compatibility with ancient > Visual Studios (MSVC6? MSVC5?). It is definitely non-confor

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

2016-03-19 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 50843. hintonda added a comment. Added FIXME comment, and reformated with clang-format. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-03-19 Thread Serge Pavlov via cfe-commits
Ping. Thanks, --Serge 2016-02-26 12:20 GMT+06:00 Serge Pavlov : > Could someone provide a feedback? > > Thanks, > --Serge > > 2016-01-26 20:55 GMT+06:00 Serge Pavlov : > >> sepavloff created this revision. >> sepavloff added a subscriber: cfe-commits. >> >> Declaration of friend function may dep

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread Ben Craig via cfe-commits
bcraig added a subscriber: bcraig. Comment at: lib/Frontend/InitPreprocessor.cpp:305 @@ +304,3 @@ +if (TypeWidth == TypeAlign && (TypeWidth & (TypeWidth - 1)) == 0 && +TypeWidth <= InlineWidth) + return Always; On some targets (like Hexagon), 4-by

r263738 - For MS ABI, emit dllexport friend functions defined inline in class

2016-03-19 Thread Reid Kleckner via cfe-commits
Author: rnk Date: Thu Mar 17 14:52:20 2016 New Revision: 263738 URL: http://llvm.org/viewvc/llvm-project?rev=263738&view=rev Log: For MS ABI, emit dllexport friend functions defined inline in class Summary: ...as that is apparently what MSVC does Reviewers: rnk Patch by Stephan Bergmann Differ

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-03-19 Thread Eric Fiselier via cfe-commits
On Wed, Mar 16, 2016 at 1:31 PM, Duncan P. N. Exon Smith < dexonsm...@apple.com> wrote: > > > On 2016-Mar-16, at 12:20, Eric Fiselier wrote: > > > > EricWF added a comment. > > > > Adding inline comments for the implementation. Comments on the tests to > follow shortly. > > > > > > ==

Re: [PATCH] D17299: [ASTReader] Report error when accessing corrupt record data

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. Have you done any performance testing on this code? In modules-heavy builds, bitcode reading is *very* hot. http://reviews.llvm.org/D17299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[clang-tools-extra] r263822 - [clang-tidy] Use hasAnyName() instead of matchesName().

2016-03-19 Thread Samuel Benzaquen via cfe-commits
Author: sbenza Date: Fri Mar 18 15:14:35 2016 New Revision: 263822 URL: http://llvm.org/viewvc/llvm-project?rev=263822&view=rev Log: [clang-tidy] Use hasAnyName() instead of matchesName(). matchesName() uses regular expressions and it is very slow. hasAnyName() gives the same result and it is muc

r263795 - Add -fnative-half-arguments-and-returns

2016-03-19 Thread Pirama Arumuga Nainar via cfe-commits
Author: pirama Date: Fri Mar 18 11:58:36 2016 New Revision: 263795 URL: http://llvm.org/viewvc/llvm-project?rev=263795&view=rev Log: Add -fnative-half-arguments-and-returns Summary: r246764 handled __fp16 arguments and returns for AAPCS, but skipped this handling for OpenCL. Simlar to OpenCL, Re

Re: r263732 - Remove defaulted move ops, the type is zero-cost copyable anyway, so there's no need for specific move ops

2016-03-19 Thread don hinton via cfe-commits
Dave: Won't this prevent UnresolvedSet from being movable? I was under the impression that all subobjects (base class in this case) had to be movable in order for the compiler to generate implicit move ops. Is that not the case? thanks... don On Thu, Mar 17, 2016 at 2:28 PM, David Blaikie via c

Re: [PATCH] D18163: Add visualizers for more clang types. Create more C++-like visualizations for existing Clang types

2016-03-19 Thread Mike Spertus via cfe-commits
mspertus closed this revision. mspertus added a comment. Forgot to close the revision http://reviews.llvm.org/D18163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread Logan Chien via cfe-commits
logan added a subscriber: logan. logan added a comment. The simple replacement from `throw()` to `_NOEXCEPT` looks fine. But, why are you adding adding some copy constructors and assignment operators? May you briefly explain the reason? Besides, I have some concern with the `= default` specifi

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread don hinton via cfe-commits
hintonda added a comment. Implicit copy ctor's and and assignment operators are deprecated in c++11, which is why I added them as = default, but you raise a good point. Perhaps it would be better to wrap them in #ifdef's. http://reviews.llvm.org/D18217 _

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread don hinton via cfe-commits
Just to clarify, they are deprecated with an explicit dtor's are provided. On Sat, Mar 19, 2016 at 11:26 AM, don hinton wrote: > hintonda added a comment. > > Implicit copy ctor's and and assignment operators are deprecated in c++11, > which is why I added them as = default, but you raise a good

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

2016-03-19 Thread Serge Pavlov via cfe-commits
sepavloff added a comment. The last changes didn't help. AST generated in `ImportGNUNullExpr` is: TranslationUnitDecl 0xc46238 <> … | `-BuiltinType 0xc46290 'char' `-FunctionDecl 0xc468a0 col:6 declToImport 'void (void)' `-CompoundStmt 0xc46948 `-GNUNullExpr 0xc46938 'in

r263706 - [OPENMP 4.5] Allow to use private data members in 'copyprivate' clause.

2016-03-19 Thread Alexey Bataev via cfe-commits
Author: abataev Date: Thu Mar 17 05:50:17 2016 New Revision: 263706 URL: http://llvm.org/viewvc/llvm-project?rev=263706&view=rev Log: [OPENMP 4.5] Allow to use private data members in 'copyprivate' clause. OpenMP 4.5 allows privatization of non-static data members in non-static member functions.

r263818 - [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo.

2016-03-19 Thread Akira Hatanaka via cfe-commits
Author: ahatanak Date: Fri Mar 18 14:03:50 2016 New Revision: 263818 URL: http://llvm.org/viewvc/llvm-project?rev=263818&view=rev Log: [Objective-c] Fix a crash in WeakObjectProfileTy::getBaseInfo. The crash occurs in WeakObjectProfileTy::getBaseInfo when getBase() is called on an ObjCPropertyRef

r263639 - Fix destructor definition of invalid classes

2016-03-19 Thread Olivier Goffart via cfe-commits
Author: ogoffart Date: Wed Mar 16 09:36:11 2016 New Revision: 263639 URL: http://llvm.org/viewvc/llvm-project?rev=263639&view=rev Log: Fix destructor definition of invalid classes The declaration of the destructor of an invalid class was not properly marked as noexcept. As a result, the definitio

Re: r249655 - Stop messing with the 'g' group of options in CompilerInvocation.

2016-03-19 Thread Dimitry Andric via cfe-commits
> On 08 Oct 2015, at 06:24, Douglas Katzman via cfe-commits > wrote: > > Author: dougk > Date: Wed Oct 7 23:24:12 2015 > New Revision: 249655 > > URL: http://llvm.org/viewvc/llvm-project?rev=249655&view=rev > Log: > Stop messing with the 'g' group of options in CompilerInvocation. > > With t

Re: [PATCH] D17407: [Sema] PR25755 Fix crash when initializing out-of-order struct references

2016-03-19 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 51114. hintonda added a comment. Address additional comments. Always maintain SeenFields, not just when designators are seen which simplies the logic. Note that there is no getNumFields() method, so we still need to determine the total FieldSize to initiali

Re: [PATCH] D17746: Fix PR26741 -- __builtin_object_size is not consistently conservative with C++ inheritance

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. Can you explain a bit more about the problem? It seems to me that if I have: struct Base { char k[1]; }; struct Derived : Base {}; ... then the 'k' subobject of a `Derived` object is known to be exactly 1 byte long -- it doesn't seem obviously appropriate for o

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

2016-03-19 Thread don hinton via cfe-commits
hintonda updated this revision to Diff 50823. hintonda added a comment. Address FIXME now that Sema::LookupInlineAsmField() has been fixed. http://reviews.llvm.org/D18123 Files: include/clang/AST/UnresolvedSet.h include/clang/Sema/Lookup.h Index: include/clang/Sema/Lookup.h ===

Re: r263687 - Add an optional named argument (replacement = "xxx") to AvailabilityAttr.

2016-03-19 Thread Manman Ren via cfe-commits
Sorry, working on it. Manman On Thu, Mar 17, 2016 at 12:45 PM, Kostya Serebryany wrote: > This change is causing ubsan bot to complain > > . > Please fix or revert. > > Most likely

Re: [PATCH] D17951: Implement is_always_lock_free

2016-03-19 Thread JF Bastien via cfe-commits
jfb updated this revision to Diff 50846. jfb added a comment. - Split up tests. http://reviews.llvm.org/D17951 Files: include/atomic test/std/atomics/atomics.lockfree/isalwayslockfree.pass.cpp test/std/atomics/atomics.lockfree/lockfree.pass.cpp Index: test/std/atomics/atomics.lockfree/lo

r263689 - [index] Make sure that declarations of builtin functions are indexed.

2016-03-19 Thread Argyrios Kyrtzidis via cfe-commits
Author: akirtzidis Date: Wed Mar 16 23:28:19 2016 New Revision: 263689 URL: http://llvm.org/viewvc/llvm-project?rev=263689&view=rev Log: [index] Make sure that declarations of builtin functions are indexed. rdar://25154630 Modified: cfe/trunk/lib/Index/IndexingContext.cpp cfe/trunk/test/

Re: [PATCH] D17392: Embed bitcode in object file (clang cc1 part)

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. From a code standpoint, this looks fine to me, but I'd like to understand a bit more about what you aim to achieve with the various parts here. Comment at: include/clang/Frontend/CodeGenOptions.def:57 @@ -56,1 +56,3 @@ +CODEGENOPT(EmbedBitcode , 1,

Re: [PATCH] D18123: Fix implicit copy ctor and copy assignment operator warnings when -Wdeprecated passed.

2016-03-19 Thread David Blaikie via cfe-commits
On Wed, Mar 16, 2016 at 11:38 AM, don hinton via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hintonda updated this revision to Diff 50843. > hintonda added a comment. > > Added FIXME comment, and reformated with clang-format. > > > http://reviews.llvm.org/D18123 > > Files: > include/clang

Re: [PATCH] D18262: [clang-tidy] Skip reporting of not applicable fixes.

2016-03-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Thank you, Etienne! Please add a regression test. Comment at: ClangTidy.cpp:144 @@ -138,1 +143,3 @@ + +Diag << FixItHint::CreateReplacement(Range, Fix.getReplacementText()); ++TotalFixes; aaron.ballman wrote: > Is

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread Ben Craig via cfe-commits
bcraig added a comment. > C++ atomics are explicitly designed to avoid problems with touching adjacent > bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte `cmpxchg` then > it's up to the frontend to make sure `sizeof> >= 4` (or something > equivalent such as making it non-lock-free).

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-03-19 Thread Duncan P. N. Exon Smith via cfe-commits
dexonsmith updated this revision to Diff 50883. dexonsmith added a comment. Eric sent me his preferred tests, which look fine to me. I've applied them to this patch. http://reviews.llvm.org/D16360 Files: include/__hash_table test/libcxx/containers/unord/unord.set/insert_dup_alloc.pass.cpp

Re: [PATCH] D18139: [Cxx1z] Implement Lambda Capture of *this by Value as [=, *this] (P0018R3)

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. Couple more things: 1. Please add some testing to tests/CXX/expr/expr.prim/expr.prim.lambda 2. Please update cxx_status.html http://reviews.llvm.org/D18139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: r263785 - Make LookupResult movable again.

2016-03-19 Thread David Blaikie via cfe-commits
On Fri, Mar 18, 2016 at 6:31 AM, Benjamin Kramer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: d0k > Date: Fri Mar 18 08:31:00 2016 > New Revision: 263785 > > URL: http://llvm.org/viewvc/llvm-project?rev=263785&view=rev > Log: > Make LookupResult movable again. > This shouldn't'v

[PATCH] D18274: [clang-tidy] Add boost module

2016-03-19 Thread Piotr Padlewski via cfe-commits
Prazek created this revision. Prazek added reviewers: alexfh, mclow.lists. Prazek added a subscriber: cfe-commits. http://reviews.llvm.org/D18274 Files: clang-tidy/CMakeLists.txt clang-tidy/boost/BoostTidyModule.cpp clang-tidy/boost/CMakeLists.txt clang-tidy/tool/CMakeLists.txt clang-ti

Re: [PATCH] Canonicalize UnaryTransformType types when they don't have a known underlying type

2016-03-19 Thread Vassil Vassilev via cfe-commits
ping... On 10/03/16 15:33, Vassil Vassilev wrote: Would this one more reasonable to commit. As you suggested if the base type is dependent, create a unique canonical UnaryTransformType with the canonical form of the base type as its base type and with DependentTy as its underlying type, then us

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-19 Thread Mehdi AMINI via cfe-commits
joker.eph added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4999 @@ +4998,3 @@ +return; + } + joker.eph wrote: > Isn't this correct by the loop which starts with `DC = InnermostExternalDC`? `s/correct/already covered/` http://reviews.llvm.org/D178

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-19 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. Attribute side of things looks good, but I leave it to others to decide if the ABI functionality makes sense (it does to me, but I'm no ABI expert). http://reviews.llvm.org/D17893 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D17988: Fix destructor definition of invalid classes

2016-03-19 Thread Olivier Goffart via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263639: Fix destructor definition of invalid classes (authored by ogoffart). Changed prior to commit: http://reviews.llvm.org/D17988?vs=50124&id=50822#toc Repository: rL LLVM http://reviews.llvm.org

Re: [PATCH] D18205: [libcxxabi] Disable cxa_thread_atexit_test if unavailable

2016-03-19 Thread Jonas Hahnfeld via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263699: [libcxxabi] Disable cxa_thread_atexit_test if unavailable (authored by Hahnfeld). Changed prior to commit: http://reviews.llvm.org/D18205?vs=50805&id=50916#toc Repository: rL LLVM http://rev

Re: [PATCH] D18149: Add check for unneeded copies of locals

2016-03-19 Thread Matt Kulukundis via cfe-commits
fowles updated this revision to Diff 50879. http://reviews.llvm.org/D18149 Files: clang-tidy/performance/UnnecessaryCopyInitialization.cpp clang-tidy/performance/UnnecessaryCopyInitialization.h docs/clang-tidy/checks/performance-unnecessary-copy-initialization.rst test/clang-tidy/performa

Re: [PATCH] D18274: [clang-tidy] Add boost module

2016-03-19 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think you also need to add new module to clang-tidy/plugin/CMakeLists.txt. http://reviews.llvm.org/D18274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [PATCH] D18203: [OPENMP] Implementation of codegen for firstprivate clause of target directive

2016-03-19 Thread Carlo Bertolli via cfe-commits
carlo.bertolli marked 2 inline comments as done. Comment at: lib/Sema/SemaOpenMP.cpp:9782-9783 @@ +9781,4 @@ +Diag(ELoc, diag::err_omp_variable_in_map_and_dsa) +<< getOpenMPClauseName(DSAStack->isFirstPrivate(VD) ? + OMPC_first

r263783 - [OpenMP] Base support for target directive codegen on NVPTX device.

2016-03-19 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Fri Mar 18 06:47:43 2016 New Revision: 263783 URL: http://llvm.org/viewvc/llvm-project?rev=263783&view=rev Log: [OpenMP] Base support for target directive codegen on NVPTX device. Summary: Reworked test case after buildbot failure on windows. This patch adds base support for

Re: [PATCH] D16965: Fix for Bug 14644 - clang confuses scope operator for global namespace giving extra qualification on member

2016-03-19 Thread Ryan Yee via cfe-commits
ryee88 added inline comments. Comment at: lib/Sema/SemaDecl.cpp:3803 @@ +3802,3 @@ + +// Per C++ standard [n3485] 3.4.4 Elaborated type specifiers, section 3: +// "Cannot introduce an qualified". aaron.ballman wrote: > Can drop the N-paper reference, a

Re: [PATCH] D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS

2016-03-19 Thread Nathan Wilson via cfe-commits
nwilson added inline comments. Comment at: lib/Sema/SemaDecl.cpp:7837 @@ -7819,1 +7836,3 @@ +NewFD->setInvalidDecl(true); +return NewFD; } Please let me know if there are thoughts about better error recovery here. I did this because we don'

Re: [PATCH] D18105: [OPENMP] Support for codegen of private clause of target, host side

2016-03-19 Thread Carlo Bertolli via cfe-commits
carlo.bertolli closed this revision. carlo.bertolli added a comment. Committed revision 263654. Repository: rL LLVM http://reviews.llvm.org/D18105 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

Re: [PATCH] D18270: Typesafe visualization of PointerIntPairs in Visual Studio

2016-03-19 Thread Aaron Ballman via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! > Note to Reviewers: I will continue to make frequent changes to the MSVC > visualizers. While these are worthwhile, I don't want to overwhelm the > reviewers. Is it OK fo

Re: [PATCH] D13419: Fix several problems at the intersection of template instantiations and visibility

2016-03-19 Thread Reid Kleckner via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rL LLVM http://reviews.llvm.org/D13419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D18270: Typesafe visualization of PointerIntPairs in Visual Studio

2016-03-19 Thread Mike Spertus via cfe-commits
mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. In the `` of `PointerIntPair` , I cast the pointer to the actual type, so VS can leverage it while visualizing, not unlike the recent change to `PointerUnion` vis

[PATCH] D18272: Add AMDGPU specific target options: -mamdgpu-tools-insert-nops and -mamdgpu-tools-reserve-trap-vgprs + add test

2016-03-19 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD created this revision. kzhuravl-AMD added reviewers: arsenm, tstellarAMD. kzhuravl-AMD added subscribers: bpurnomo, cfe-commits. http://reviews.llvm.org/D18272 Files: include/clang/Driver/Options.td lib/Driver/Tools.cpp test/Driver/amdgpu-features.c Index: test/Driver/amdgpu-f

[PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

2016-03-19 Thread Bruno Cardoso Lopes via cfe-commits
bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is unprint

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

2016-03-19 Thread Peter Collingbourne via cfe-commits
pcc added a comment. There's a correctness issue with this change that I'll need to resolve before this goes in; see http://lists.llvm.org/pipermail/cfe-dev/2016-March/048025.html http://reviews.llvm.org/D18199 ___ cfe-commits mailing list cfe-comm

Re: [PATCH] D9888: [OPENMP] Driver support for OpenMP offloading

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. @echristo, you asked for time to review this; if you still want to, please can you do so? @tra, it looks like you're happy with this design (and with moving the CUDA offloading support in this direction), please let us know if not! Comment at: include/c

[PATCH] D18286: [OPENMP] private and firstprivate clauses of teams code generation for nvptx

2016-03-19 Thread Carlo Bertolli via cfe-commits
carlo.bertolli created this revision. carlo.bertolli added reviewers: ABataev, kkwli0, Hahnfeld. carlo.bertolli added subscribers: sfantao, caomhin, arpith-jacob, cfe-commits. carlo.bertolli set the repository for this revision to rL LLVM. Herald added a subscriber: jholewinski. This patch adds in

Re: [PATCH] D16579: Warn if friend function depends on template parameters.

2016-03-19 Thread Serge Pavlov via cfe-commits
sepavloff updated this revision to Diff 51017. sepavloff added a comment. Do not emit warning on class methods. http://reviews.llvm.org/D16579 Files: include/clang/Basic/DiagnosticGroups.td include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaDecl.cpp test/CXX/drs/dr3xx.cpp test/CX

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread Joerg Sonnenberger via cfe-commits
On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote: > C++ atomics are explicitly designed to avoid problems with touching > adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte > `cmpxchg` then it's up to the frontend to make sure `sizeof> >= 4` > (or somethi

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-03-19 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. LGTM after change in inline comment. Comment at: include/__hash_table:114 @@ +113,3 @@ +template +struct __can_extract_key<_Pair, _Key, pair<_First, _Second>> +: conditio

[PATCH] D18297: Visualizer for clang::FunctionProtoType

2016-03-19 Thread Mike Spertus via cfe-commits
mspertus created this revision. mspertus added reviewers: aaron.ballman, zturner, aemerson. mspertus added a subscriber: cfe-commits. Visualizer for clang::FunctionProtoType Displays return type and parameters for the Function Protoype object in the Locals window. For example, the prototype `int

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread JF Bastien via cfe-commits
On Fri, Mar 18, 2016 at 7:30 AM, Craig, Ben via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On 3/18/2016 1:50 AM, Joerg Sonnenberger via cfe-commits wrote: > >> On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits >> wrote: >> >>> C++ atomics are explicitly designed to avoid

Re: [PATCH] D16749: [OpenMP] Map clause codegeneration.

2016-03-19 Thread Alexey Bataev via cfe-commits
ABataev added a comment. Samuel, this will be captured. But foo() will use original A. This cannot be changed. But Inside the region all reference to this->A will be replaced by the CapturedDecl A. It will allow proper codegen for inner captured contexts. For example, such code won't be handled

Re: [PATCH] D18219: Add -cuda-relaxed-constexpr, which lets CUDA device code call constexpr functions.

2016-03-19 Thread Justin Lebar via cfe-commits
jlebar added a comment. Actually, this isn't enough. It works fine for std::complex, but it screws with our existing std math business, because some of the host functions that we're trying to override are constexpr, and now they're treated as constexpr host-device. http://reviews.llvm.org/D1

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread JF Bastien via cfe-commits
jfb added a comment. In http://reviews.llvm.org/D17950#376965, @jfb wrote: > In http://reviews.llvm.org/D17950#376349, @jyknight wrote: > > > This conflicts with http://reviews.llvm.org/D17933. Most of this change > > also seems unnecessary. > > > > - I think the `is_always_lock_free` function s

Re: [PATCH] D18263: [clang-tools-extra] Add release notes documentation

2016-03-19 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. Looks good with one comment. Thank you, Richard! Comment at: docs/clang-tidy/checks/list.rst:91 @@ -90,2 +90,3 @@ performance-implicit-cast-in-loop + performance-unnecessary-copy-initialization.rst readability-braces-around-statements --

Re: [PATCH] D15267: For MS ABI, emit dllexport friend functions defined inline in class

2016-03-19 Thread Reid Kleckner via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263738: For MS ABI, emit dllexport friend functions defined inline in class (authored by rnk). Changed prior to commit: http://reviews.llvm.org/D15267?vs=46227&id=50968#toc Repository: rL LLVM http:

r263747 - Re-add (user defined) move ops to UnresolvedSetImpl to allow UnresolvedSet to be implicitly movable

2016-03-19 Thread David Blaikie via cfe-commits
Author: dblaikie Date: Thu Mar 17 15:45:38 2016 New Revision: 263747 URL: http://llvm.org/viewvc/llvm-project?rev=263747&view=rev Log: Re-add (user defined) move ops to UnresolvedSetImpl to allow UnresolvedSet to be implicitly movable Modified: cfe/trunk/include/clang/AST/UnresolvedSet.h Mo

[PATCH] D18221: [Concepts] Implement subsection [dcl.spec.concept]p7 of the Concepts TS

2016-03-19 Thread Nathan Wilson via cfe-commits
nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, faisalv, aaron.ballman. nwilson added a subscriber: cfe-commits. A program shall not declare an explicit instantiation (14.8.2), an explicit specialization (14.8.3), or a partial specialization of a concept de

[PATCH] D18219: Add -cuda-relaxed-constexpr, which lets CUDA device code call constexpr functions.

2016-03-19 Thread Justin Lebar via cfe-commits
jlebar created this revision. jlebar added a reviewer: tra. jlebar added a subscriber: cfe-commits. In particular, this lets device code call most std::complex functions. http://reviews.llvm.org/D18219 Files: include/clang/Basic/LangOptions.def include/clang/Driver/CC1Options.td include/cl

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread Marshall Clow via cfe-commits
mclow.lists added inline comments. Comment at: include/__bit_reference:75 @@ -73,1 +74,3 @@ +_LIBCPP_INLINE_VISIBILITY +__bit_reference(const __bit_reference&) _NOEXCEPT = default; private: Sadly, we don't get to say '=default', because we have clients th

Re: [PATCH] D18191: [clang-tidy] Add check for function parameters that are const& to builtin types

2016-03-19 Thread Steve Downey via cfe-commits
sdowney updated this revision to Diff 50986. sdowney added a comment. Add tests with functions generated with MACROS http://reviews.llvm.org/D18191 Files: clang-tidy/misc/CMakeLists.txt clang-tidy/misc/ConstRefBuiltinCheck.cpp clang-tidy/misc/ConstRefBuiltinCheck.h clang-tidy/misc/MiscT

Re: [PATCH] D17950: Implement is_always_lock_free

2016-03-19 Thread Craig, Ben via cfe-commits
On 3/18/2016 1:50 AM, Joerg Sonnenberger via cfe-commits wrote: On Thu, Mar 17, 2016 at 05:56:17PM +, JF Bastien via cfe-commits wrote: C++ atomics are explicitly designed to avoid problems with touching adjacent bytes: if `atomic` where `sizeof(T) == 1` requires a 4-byte `cmpxchg` then it's

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread don hinton via cfe-commits
hintonda added a comment. Okay, but should I fix the 146 cases of " = default;" that were already there? That's a lot of churn, so I don't want to step on anyone... http://reviews.llvm.org/D18217 ___ cfe-commits mailing list cfe-commits@lists.llvm

Re: [PATCH] D16360: unordered_map: Avoid unnecessary mallocs when no insert occurs

2016-03-19 Thread Duncan P. N. Exon Smith via cfe-commits
> On 2016-Mar-16, at 15:41, Eric Fiselier wrote: > > EricWF accepted this revision. > EricWF added a comment. > This revision is now accepted and ready to land. > > LGTM after change in inline comment. > > > > Comment at: include/__hash_table:114 > @@ +113,3 @@ > +template >

Re: [PATCH] D17701: [Sema] Teach SemaCast to allow reinterpret_casts of overloaded functions with only one addressable candidate

2016-03-19 Thread George Burgess IV via cfe-commits
george.burgess.iv marked an inline comment as done. Comment at: lib/Sema/SemaCast.cpp:1771-1782 @@ +1770,14 @@ + + DeclAccessPair DAP; + FunctionDecl *Found = Self.resolveAddressOfOnlyViableOverloadCandidate(E, DAP); + if (!Found) +return false; + + Self.CheckAddressOfMem

r263887 - [Sema] Allow casting of some overloaded functions

2016-03-19 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Sat Mar 19 16:36:10 2016 New Revision: 263887 URL: http://llvm.org/viewvc/llvm-project?rev=263887&view=rev Log: [Sema] Allow casting of some overloaded functions Some functions can't have their address taken. If we encounter an overload set where only one of the candidates can

Re: [PATCH] D17701: [Sema] Teach SemaCast to allow reinterpret_casts of overloaded functions with only one addressable candidate

2016-03-19 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263887: [Sema] Allow casting of some overloaded functions (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D17701?vs=49334&id=51119#toc Repository: rL LLVM http://reviews.llvm.or

r263837 - [OPENMP] Implementation of codegen for firstprivate clause of target directive

2016-03-19 Thread Carlo Bertolli via cfe-commits
Author: cbertol Date: Fri Mar 18 16:43:32 2016 New Revision: 263837 URL: http://llvm.org/viewvc/llvm-project?rev=263837&view=rev Log: [OPENMP] Implementation of codegen for firstprivate clause of target directive This patch implements the following aspects: It extends sema to check that a variab

r263888 - [Sema] Make type deduction work with some overloadable functions

2016-03-19 Thread George Burgess IV via cfe-commits
Author: gbiv Date: Sat Mar 19 16:51:45 2016 New Revision: 263888 URL: http://llvm.org/viewvc/llvm-project?rev=263888&view=rev Log: [Sema] Make type deduction work with some overloadable functions Some functions can't have their address taken. If we encounter an overload set where only one of the

Re: [PATCH] D15591: [Bugfix] Make type deduction work more nicely with unaddressable functions

2016-03-19 Thread George Burgess IV via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263888: [Sema] Make type deduction work with some overloadable functions (authored by gbiv). Changed prior to commit: http://reviews.llvm.org/D15591?vs=49337&id=51120#toc Repository: rL LLVM http://

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

2016-03-19 Thread Aleksei Sidorin via cfe-commits
a.sidorin updated this revision to Diff 51027. a.sidorin added a comment. Serge, thank you for help! GNUNullExpr was 'long' on my platform. I weakened a matcher to check only if it has integer type. ParenListExpr issue was also successfully reproduced with 'fdelayed-template-parsing' and fixed.

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. > Okay, but should I fix the 146 cases of " = default;" that were already there? If there are `= default` in code that can be used from C++03, then they ought to be fixed. Note that many of the ones that turn up in a text search are in the synopsis - not in the cod

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread Marshall Clow via cfe-commits
mclow.lists added a comment. One idea is to do this in two steps - do the `throw()` stuff in one patch, and the defaulted fns in a second one. http://reviews.llvm.org/D18217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

r263713 - clang-format: [JS] Make requoting of JavaScript string literals only

2016-03-19 Thread Daniel Jasper via cfe-commits
Author: djasper Date: Thu Mar 17 08:03:41 2016 New Revision: 263713 URL: http://llvm.org/viewvc/llvm-project?rev=263713&view=rev Log: clang-format: [JS] Make requoting of JavaScript string literals only change affected ranges. Modified: cfe/trunk/lib/Format/Format.cpp cfe/trunk/unittests/

Re: [PATCH] D17951: Implement is_always_lock_free

2016-03-19 Thread Eric Fiselier via cfe-commits
EricWF added a comment. @jfb: Actually I changed my mind about guarding the new tests. Can you move the new tests (other than the missing additions) to a new test file? Then add `// UNSUPPORTED: c++98, c++03, c++11, c++14` to the top of it? http://reviews.llvm.org/D17951 ___

r263836 - Fix printing of anonymous struct typedefs.

2016-03-19 Thread Steven Watanabe via cfe-commits
Author: steven_watanabe Date: Fri Mar 18 16:35:59 2016 New Revision: 263836 URL: http://llvm.org/viewvc/llvm-project?rev=263836&view=rev Log: Fix printing of anonymous struct typedefs. clang -cc1 -ast-print put the struct definition in the wrong place, like this: struct {} typedef S; The reas

Re: [PATCH] D18217: [libcxx] Fix -Wdeprecated warnings

2016-03-19 Thread don hinton via cfe-commits
hintonda added a comment. Yes, those were mostly in comments. I'd just done a simple find/grep that didn't take context into account. I agree that multiple checkins would be best which will make it much easy to review. http://reviews.llvm.org/D18217 ___

Re: [PATCH] D18289: Attach profile summary information to module

2016-03-19 Thread Vedant Kumar via cfe-commits
vsk added a comment. Thanks! Some inline comments -- Comment at: lib/CodeGen/CodeGenModule.cpp:399 @@ -398,1 +398,3 @@ getModule().setMaximumFunctionCount(PGOReader->getMaximumFunctionCount()); +auto *SummaryMD = PGOReader->getSummary().getMD(getModule().getContext());

Re: [PATCH] D18231: [Clang-tools-extra] Fix Clang-tidy modernize-deprecated-headers warnings; other minor fixes

2016-03-19 Thread Etienne Bergeron via cfe-commits
etienneb added a subscriber: etienneb. etienneb added a comment. lgtm Repository: rL LLVM http://reviews.llvm.org/D18231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r263784 - Revert r263783 as buildbot failure is being investigated.

2016-03-19 Thread Arpith Chacko Jacob via cfe-commits
Author: arpith Date: Fri Mar 18 07:39:40 2016 New Revision: 263784 URL: http://llvm.org/viewvc/llvm-project?rev=263784&view=rev Log: Revert r263783 as buildbot failure is being investigated. Removed: cfe/trunk/test/OpenMP/nvptx_target_codegen.cpp Modified: cfe/trunk/lib/CodeGen/CGOpenMPR

Re: [PATCH] D16989: Change interpretation of function definition in friend declaration of template class.

2016-03-19 Thread Richard Smith via cfe-commits
rsmith added a comment. Can we instead not add the function to the redeclaration chain until it's instantiated (like we do if it's dependent)? http://reviews.llvm.org/D16989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

Re: [PATCH] D17893: Sema: Add semantic analysis for the C++ ABI stability attributes and whitelist.

2016-03-19 Thread Peter Collingbourne via cfe-commits
pcc added inline comments. Comment at: lib/Sema/SemaDeclCXX.cpp:4935-4943 @@ +4934,11 @@ + + bool HasStableAttr = Record->hasAttr(); + bool HasUnstableAttr = Record->hasAttr(); + if (HasStableAttr && HasUnstableAttr) { +Diag(Record->getLocation(), diag::err_abi_mismatch) <<

Re: [PATCH] D17784: Check if LLVM_PREFIX is defined before using it.

2016-03-19 Thread Chaoren Lin via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL263766: Remove usage of LLVM_PREFIX. (authored by chaoren). Changed prior to commit: http://reviews.llvm.org/D17784?vs=50993&id=50994#toc Repository: rL LLVM http://reviews.llvm.org/D17784 Files:

Re: [PATCH] D18199: CodeGen: Implement IR generation for the relative vtable ABI (PR26723).

2016-03-19 Thread Peter Collingbourne via cfe-commits
pcc updated this revision to Diff 50905. pcc added a comment. - Do not set virtual index in debug info for relative-ABI virtual functions http://reviews.llvm.org/D18199 Files: docs/UsersManual.rst lib/CodeGen/CGDebugInfo.cpp lib/CodeGen/CGVTables.cpp lib/CodeGen/CGVTables.h lib/CodeGe

[PATCH] D18253: Switch AMDGPU Linker to amdphdrs + update test

2016-03-19 Thread Konstantin Zhuravlyov via cfe-commits
kzhuravl-AMD created this revision. kzhuravl-AMD added a reviewer: tstellarAMD. kzhuravl-AMD added a subscriber: cfe-commits. http://reviews.llvm.org/D18253 Files: lib/Driver/Tools.cpp lib/Driver/Tools.h test/Driver/amdgpu-toolchain.c Index: test/Driver/amdgpu-toolchain.c =

[PATCH] D18271: Avoid -Wshadow warnings about constructor parameters named after fields

2016-03-19 Thread Reid Kleckner via cfe-commits
rnk created this revision. rnk added reviewers: rsmith, rtrieu. rnk added a subscriber: cfe-commits. Emit a new warning if such parameters are modified in the body of the constructor. Fixes PR16088. http://reviews.llvm.org/D18271 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/Se

Re: [PATCH] D18263: [clang-tools-extra] Add release notes documentation

2016-03-19 Thread Richard via cfe-commits
LegalizeAdulthood updated this revision to Diff 51013. LegalizeAdulthood added a comment. Sort check names in list http://reviews.llvm.org/D18263 Files: docs/ReleaseNotes.rst docs/clang-tidy/checks/list.rst docs/index.rst Index: docs/index.rst

<    1   2   3   >