logan added a subscriber: logan.
logan added a comment.

The simple replacement from `throw()` to `_NOEXCEPT` looks fine.

But, why are you adding adding some copy constructors and assignment operators? 
 May you briefly explain the reason?

Besides, I have some concern with the `= default` specifier in some C++98 
headers, e.g. `<typeinfo>`.  What will happen if the user is compiling with 
`-std=c++98`?

And, unfortunately, I am not familiar with libc++ code base.  I think you will 
need approvals from @mclow.lists or @EricWF.


http://reviews.llvm.org/D18217



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to