hokein added inline comments.
Comment at: clang-tidy/tool/ClangTidyMain.cpp:78
@@ +77,3 @@
+static cl::opt
+HeaderFileExtensions("header-file-extensions",
+ cl::desc("File extensions that regard as header file.\n"
alexfh wrote:
> We don't need
nwilson added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:375
@@ +374,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
hubert.reinterpretcast wrote:
> The parameter is
On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Following Louis' suggestion, how about __pack_nth?
>
Maybe just __pack_element, to mirror its intended use to implement things
like tuple_element? (I'm not completely happy about using this gene
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:375
@@ +374,3 @@
+ bool isConcept() const { return TemplatedDecl.getInt(); }
+ void setConcept(bool IC) { TemplatedDecl.setInt(true); }
+
nwilson wrote:
> hubert.reinterpr
alexfh added a subscriber: jroelofs.
alexfh added a comment.
In http://reviews.llvm.org/D15528#326031, @jroelofs wrote:
> Hmm. There's no "close revision" button. Abandoning it in lieu of closing it.
Weird. That's probably because I've not marked it "Accepted". Now I tried a few
other actions
On Wed, Jan 13, 2016 at 6:48 PM, Richard Smith
wrote:
> On Wed, Jan 13, 2016 at 3:41 PM, Arthur O'Dwyer via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Following Louis' suggestion, how about __pack_nth?
>>
>
> Maybe just __pack_element, to mirror its intended use to implement things
>
hubert.reinterpretcast added a comment.
Please add tests for `const bool` for both the function and variable cases
(should get the error).
Comment at: test/CXX/concepts-ts/dcl.dcl/dcl.spec/dcl.spec.concept/p5.cpp:22
@@ +21,3 @@
+template
+concept auto fcrta(void) -> bool { retu
nwilson added inline comments.
Comment at: include/clang/AST/DeclTemplate.h:377
@@ -376,3 +376,3 @@
NamedDecl *TemplatedDecl;
TemplateParameterList* TemplateParams;
I can't seem to follow the link properly, but I'm assuming it's supposed to be
where Richa
rjmccall added a comment.
Yes, this seems to be exactly what I wanted, thanks! LGTM.
http://reviews.llvm.org/D15686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
weimingz created this revision.
weimingz added a reviewer: nicholas.
weimingz added a subscriber: cfe-commits.
r255371 errors on redeclaring with a conflicting asm label.
This patch changes errors to warnings to prevent breaking existing codes.
http://reviews.llvm.org/D16171
Files:
include/cla
jlebar updated this revision to Diff 44823.
jlebar added a comment.
Address tra's review comments.
http://reviews.llvm.org/D16080
Files:
test/Preprocessor/cuda-preprocess.cu
Index: test/Preprocessor/cuda-preprocess.cu
===
--- /d
jlebar marked 2 inline comments as done.
Comment at: test/Driver/cuda-preprocess.cu:13-16
@@ +12,6 @@
+
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu-arch=sm_20 %s 2>&1 \
+// RUN: | FileCheck -check-prefix NOARCH %s
+// RUN: %clang -E -target x86_64-linux-gnu --cuda-gpu
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review, Artem.
http://reviews.llvm.org/D16080
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: pcc
Date: Wed Jan 13 20:49:48 2016
New Revision: 257738
URL: http://llvm.org/viewvc/llvm-project?rev=257738&view=rev
Log:
CodeGen: Only emit CFI unrelated cast checks for bit casts.
We were previously emitting them for no-op casts (e.g. implicit casts
to const).
Modified:
cfe/trunk/l
Author: pcc
Date: Wed Jan 13 20:49:51 2016
New Revision: 257739
URL: http://llvm.org/viewvc/llvm-project?rev=257739&view=rev
Log:
Driver: Remove SanitizerArgs::clear() function and SanitizerSet ctor,
replace with in-class initializers.
Modified:
cfe/trunk/include/clang/Basic/Sanitizers.h
hubert.reinterpretcast added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:550
@@ -548,1 +549,3 @@
case BuiltinType::Double:
+// FIXME: For targets where lond double and __float128 have the same size,
+// they are currently indistinguishable in the debugger w
pxli168 updated this revision to Diff 44826.
pxli168 added a comment.
Fix format of diag err string, remove useless ':' after expecting.
http://reviews.llvm.org/D15914
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
include/clang/Basic/DiagnosticSemaKinds.td
lib/B
pcc created this revision.
pcc added reviewers: kcc, eugenis.
pcc added a subscriber: cfe-commits.
This is part of a new statistics gathering feature for the sanitizers.
See clang/docs/SanitizerStats.rst for further info and docs.
http://reviews.llvm.org/D16175
Files:
docs/SanitizerStats.rst
kromanova added a subscriber: cfe-commits.
kromanova added a comment.
Adding cfe-commits as a subscriber.
Repository:
rL LLVM
http://reviews.llvm.org/D16177
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mai
Author: djasper
Date: Wed Jan 13 23:37:52 2016
New Revision: 257741
URL: http://llvm.org/viewvc/llvm-project?rev=257741&view=rev
Log:
clang-format: [JS] Fix incorrect line break leading to semicolon insertion.
clang-format only works for JavaScript code, if all the semicolons are
present anyway,
rjmccall added inline comments.
Comment at: include/clang/Basic/TargetInfo.h:385
@@ +384,3 @@
+ unsigned getFloat128Width() const { return Float128Width; }
+ unsigned getFloat128Align() const { return Float128Align; }
+ const llvm::fltSemantics &getFloat128Format() const {
ABataev removed a subscriber: rsmith.
ABataev updated this revision to Diff 44833.
ABataev added a comment.
Updated to latest version
http://reviews.llvm.org/D10599
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticParseKinds.td
include/cla
Thanks for the clarification.
On Thursday, January 14, 2016, Laszlo Nagy
wrote:
> yes, it is just an initial drop. improvements are planed to make a full
> replacement of the one written in Perl.
>
> On Thu, Jan 14, 2016 at 12:14 AM, Ismail Donmez > wrote:
>
>> Hi,
>>
>> On Wed, Jan 13, 2016 at
101 - 123 of 123 matches
Mail list logo
