This revision was automatically updated to reflect the committed changes.
Closed by commit rL256491: Refactor: Simplify boolean conditional return
statements in… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D10021?vs=38311&id=43677#toc
Repository:
rL LLVM
http://re
alexfh added a comment.
> Do you need me to commit the patch for you?
Assuming "yes", since I don't recall any patches committed by you. Actually, it
might be a good idea for you to request commit access at this point.
http://reviews.llvm.org/D15737
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256492: [clang-tidy] Preserve comments and preprocessor
directives when simplifying… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D15737?vs=43647&id=43678#toc
Repository:
rL
Author: alexfh
Date: Mon Dec 28 07:21:22 2015
New Revision: 256492
URL: http://llvm.org/viewvc/llvm-project?rev=256492&view=rev
Log:
[clang-tidy] Preserve comments and preprocessor directives when simplifying
boolean expressions
This changeset still emits the diagnostic that the expression could
pekka.jaaskelainen added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+PipeTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+ }
I'm not sure if touching the bui
alexfh added a subscriber: alexfh.
alexfh added a comment.
Found this accidentally, since I don't read all of cfe-commits normally. Would
be nice if you could add me to reviewers on clang-tidy-related patches. Thanks!
In http://reviews.llvm.org/D15121#300837, @dblaikie wrote:
> (tangential: Sho
Author: mkuper
Date: Mon Dec 28 08:39:54 2015
New Revision: 256495
URL: http://llvm.org/viewvc/llvm-project?rev=256495&view=rev
Log:
[X86] Better support for the MCU psABI (clang part)
This adds support for the MCU psABI in a way different from r251223 and r251224,
basically reverting most of the
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256495: [X86] Better support for the MCU psABI (clang part)
(authored by mkuper).
Changed prior to commit:
http://reviews.llvm.org/D15055?vs=41348&id=43685#toc
Repository:
rL LLVM
http://reviews.llv
pekka.jaaskelainen added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+PipeTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+ }
pxli168 wrote:
> pekka.jaaskelai
NoQ updated this revision to Diff 43683.
NoQ marked an inline comment as done.
NoQ added a comment.
An attempt on the .def-files.
The next step would probably be the `VisitChildren()` thing, and I'll see if it
allows to refactor and simplify some code.
__
Forgot to answer: I guess there ar
alexfh added a subscriber: alexfh.
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D10016
___
cfe-commits mailing list
cfe-commits@li
hokein updated this revision to Diff 43686.
hokein added a comment.
Address aaron's comments.
http://reviews.llvm.org/D15710
Files:
clang-tidy/misc/CMakeLists.txt
clang-tidy/misc/DefinitionsInHeadersCheck.cpp
clang-tidy/misc/DefinitionsInHeadersCheck.h
clang-tidy/misc/MiscTidyModule.cpp
alexfh added a subscriber: alexfh.
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D10023
___
cfe-commits mailing list
cfe-commits@li
Author: alexfh
Date: Mon Dec 28 09:15:16 2015
New Revision: 256496
URL: http://llvm.org/viewvc/llvm-project?rev=256496&view=rev
Log:
Refactor: Simplify boolean conditional return statements in lib/Frontend
Summary: Use clang-tidy to simplify boolean conditional return statements
Reviewers: alexf
alexfh added a subscriber: alexfh.
alexfh accepted this revision.
alexfh added a reviewer: alexfh.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
http://reviews.llvm.org/D10024
___
cfe-commits mailing list
cfe-commits@li
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256497: Refactor: Simplify boolean conditional return
statements in… (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D10023?vs=38312&id=43689#toc
Repository:
rL LLVM
http://re
Author: alexfh
Date: Mon Dec 28 09:19:39 2015
New Revision: 256497
URL: http://llvm.org/viewvc/llvm-project?rev=256497&view=rev
Log:
Refactor: Simplify boolean conditional return statements in
lib/StaticAnalyzer/Frontend
Summary: Use clang-tidy to simplify boolean conditional return statements
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256496: Refactor: Simplify boolean conditional return
statements in lib/Frontend (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D10016?vs=38309&id=43687#toc
Repository:
rL LLV
a.sidorin created this revision.
a.sidorin added reviewers: zaks.anna, xazax.hun, dcoughlin.
a.sidorin added a subscriber: cfe-commits.
a.sidorin set the repository for this revision to rL LLVM.
Use getRedeclContext() instead of a manually written loop; fix a comment.
Repository:
rL LLVM
http:
hokein marked 6 inline comments as done.
Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:18
@@ +17,3 @@
+ int c = 2; // ok
+ }
+
Yeah, it's not a good practice to define an an unnamed namespace in header file
(Google cpp code style also
Author: alexfh
Date: Mon Dec 28 09:24:08 2015
New Revision: 256498
URL: http://llvm.org/viewvc/llvm-project?rev=256498&view=rev
Log:
Refactor: Simplify boolean conditional return statements in tools/libclang
Summary: Use clang-tidy to simplify boolean conditional return statements.
Reviewers: al
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256498: Refactor: Simplify boolean conditional return
statements in tools/libclang (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D10024?vs=38315&id=43691#toc
Repository:
rL L
alexfh added a subscriber: alexfh.
alexfh added a comment.
David, have your comments been addressed completely?
http://reviews.llvm.org/D10019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
Author: alexfh
Date: Mon Dec 28 09:30:42 2015
New Revision: 256499
URL: http://llvm.org/viewvc/llvm-project?rev=256499&view=rev
Log:
Refactor: Simplify boolean conditional return statements in lib/Lex
Summary: Use clang-tidy to simplify boolean conditional return statements
Reviewers: dblaikie
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256499: Refactor: Simplify boolean conditional return
statements in lib/Lex (authored by alexfh).
Changed prior to commit:
http://reviews.llvm.org/D10017?vs=38322&id=43693#toc
Repository:
rL LLVM
ht
alexfh added a subscriber: alexfh.
alexfh added a comment.
The patch doesn't apply cleanly. You need to rebase it again.
http://reviews.llvm.org/D10011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
myatsina created this revision.
myatsina added reviewers: ehsan, rnk.
myatsina added subscribers: llvm-commits, cfe-commits.
myatsina set the repository for this revision to rL LLVM.
In MS inline asm syntax a label with '$' char produces an error, while in AT&T
it does not.
In AT&T inline asm syn
anadolskiy added a comment.
ping
http://reviews.llvm.org/D15647
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pxli168 added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+PipeTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+ }
pekka.jaaskelainen wrote:
> I'm not sure if
pxli168 added inline comments.
Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108
@@ +107,3 @@
+PipeTy = llvm::PointerType::get(llvm::StructType::create(
+ CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc);
+ }
pekka.jaaskelainen wrote:
> pxli168 wrote:
Author: aaronballman
Date: Mon Dec 28 09:52:46 2015
New Revision: 256501
URL: http://llvm.org/viewvc/llvm-project?rev=256501&view=rev
Log:
Silence enumeral and non-enumeral type in conditional expression warning; NFC.
Modified:
cfe/trunk/lib/Parse/ParseOpenMP.cpp
Modified: cfe/trunk/lib/Pars
aaron.ballman added a reviewer: aaron.ballman.
Comment at: docs/clang-tidy/checks/misc-definitions-in-headers.rst:18
@@ +17,3 @@
+ int c = 2; // ok
+ }
+
hokein wrote:
> Yeah, it's not a good practice to define an an unnamed namespace in header
> file (Goo
ehsan accepted this revision.
ehsan added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D15795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
aaron.ballman added inline comments.
Comment at: include/clang/Basic/Attr.td:1531
@@ -1529,1 +1530,3 @@
+def IAInterrupt : InheritableAttr, TargetSpecificAttr {
+ // NOTE: If you add any additional spellings, ARMInterrupt's,
Maybe this (and IAInterruptDocs) sho
Author: sepavloff
Date: Mon Dec 28 11:19:12 2015
New Revision: 256503
URL: http://llvm.org/viewvc/llvm-project?rev=256503&view=rev
Log:
Avoid crash when dumping LocInfoType.
LocInfoType is a helper type used internally inside Sema and Parser, it
does not exist in valid AST. LocInfoType uses code
Author: xazax
Date: Mon Dec 28 11:20:33 2015
New Revision: 256504
URL: http://llvm.org/viewvc/llvm-project?rev=256504&view=rev
Log:
[clang-tidy] Fix a false positive case in ContainerSizeEmpty check.
Modified:
clang-tools-extra/trunk/clang-tidy/readability/ContainerSizeEmptyCheck.cpp
clan
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
Some of our checkers are registered under multiple different check names. This
works well in terms of command line arguments, but does not work well for
documentatio
Author: echristo
Date: Mon Dec 28 13:07:46 2015
New Revision: 256508
URL: http://llvm.org/viewvc/llvm-project?rev=256508&view=rev
Log:
Fix up comment in header.
Modified:
cfe/trunk/lib/Headers/altivec.h
Modified: cfe/trunk/lib/Headers/altivec.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/t
Author: echristo
Date: Mon Dec 28 13:07:48 2015
New Revision: 256509
URL: http://llvm.org/viewvc/llvm-project?rev=256509&view=rev
Log:
Comment and reorganize some of the target feature option sets.
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/O
faisalv added a comment.
*ping*
http://reviews.llvm.org/D15005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sepavloff
Date: Mon Dec 28 13:40:14 2015
New Revision: 256511
URL: http://llvm.org/viewvc/llvm-project?rev=256511&view=rev
Log:
Do not crash if class is defined in wrong scope.
This patch fixes PR16677. The latter represents the case when due to
misprinted character class definition occur
Author: echristo
Date: Mon Dec 28 13:58:44 2015
New Revision: 256516
URL: http://llvm.org/viewvc/llvm-project?rev=256516&view=rev
Log:
We check for dwarf 5 in the backend, so go ahead and pass it along via
the front end as well.
Note that DWARF5 isn't finalized and any feature support is subject
Author: aaronballman
Date: Mon Dec 28 13:59:15 2015
New Revision: 256517
URL: http://llvm.org/viewvc/llvm-project?rev=256517&view=rev
Log:
Orphaning these RST files; each one is retained only for link backwards
compatibility.
Modified:
clang-tools-extra/trunk/docs/clang-modernize.rst
cla
ayartsev added a comment.
Ping.
http://reviews.llvm.org/D14629
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM. I'll commit. Thanks Aleksei!
Repository:
rL LLVM
http://reviews.llvm.org/D15794
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: dcoughlin
Date: Mon Dec 28 15:47:51 2015
New Revision: 256524
URL: http://llvm.org/viewvc/llvm-project?rev=256524&view=rev
Log:
Small refactoring in CheckerContext::isCLibraryFunction(). NFC.
Use getRedeclContext() instead of a manually-written loop and fix a comment.
A patch by Aleksei
This revision was automatically updated to reflect the committed changes.
Closed by commit rL256524: Small refactoring in
CheckerContext::isCLibraryFunction(). NFC. (authored by dcoughlin).
Changed prior to commit:
http://reviews.llvm.org/D15794?vs=43688&id=43706#toc
Repository:
rL LLVM
htt
Author: echristo
Date: Mon Dec 28 15:57:05 2015
New Revision: 256525
URL: http://llvm.org/viewvc/llvm-project?rev=256525&view=rev
Log:
Fix up a comment and a bit of trailing whitespace.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Driver/Tools.cpp
URL:
http://llvm.org/vi
Author: rsmith
Date: Mon Dec 28 19:02:53 2015
New Revision: 256529
URL: http://llvm.org/viewvc/llvm-project?rev=256529&view=rev
Log:
Revert r93378, which is incorrect but currently unobservable (because the
underlying declaration of a NamedDecl happens to always have the same name
and identifier n
Author: jyknight
Date: Mon Dec 28 22:34:11 2015
New Revision: 256534
URL: http://llvm.org/viewvc/llvm-project?rev=256534&view=rev
Log:
[TrailingObjects] Use a different technique to determine if a getDecl
member function exists on a class.
The previous trick depended on inheriting from the class
Author: jyknight
Date: Mon Dec 28 22:46:43 2015
New Revision: 256535
URL: http://llvm.org/viewvc/llvm-project?rev=256535&view=rev
Log:
Revert "[TrailingObjects] Use a different technique to determine if a getDecl"
This reverts commit r256534.
Failed to build on MSVC with error:
clang/ASTMatchers
James, if this wasn't already done, please file a bug against MSVC so this
can be fixed in future releases.
On Mon, Dec 28, 2015 at 8:46 PM, James Y Knight via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jyknight
> Date: Mon Dec 28 22:46:43 2015
> New Revision: 256535
>
> URL: http
alexfh added a comment.
Please add a test that crashes without the patch and passes with it.
Repository:
rL LLVM
http://reviews.llvm.org/D15797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
zaks.anna added a comment.
Anton,
Have you investigated if we can reuse code from clang-tidy?
Also, the hope is that the python rewrite of scan-build will replace the
current scan-build in the near future. Of cause, it still needs to be tested on
Windows. I would really appreciate if you could
ABataev marked 8 inline comments as done.
ABataev added a comment.
Aaron, thanks for the review!
Comment at: include/clang/Basic/AttrDocs.td:1867
@@ +1866,3 @@
+Clang supports the GNU style ``__attribute__((interrupt))`` attribute on
+x86 targets. This attribute may be attached
ABataev marked 9 inline comments as done.
ABataev added a comment.
John, thanks for the review!
Comment at: include/clang/Basic/Attr.td:255
@@ -254,2 +254,3 @@
def TargetX86 : TargetArch<["x86"]>;
+def TargetIA : TargetArch<["x86", "x86_64"]>;
def TargetWindows : TargetArch<["
a.sidorin updated this revision to Diff 43674.
a.sidorin marked an inline comment as done.
a.sidorin added a comment.
Canonicalize the inserted declarations in a single place; honor ObjCMethodDecls.
Repository:
rL LLVM
http://reviews.llvm.org/D15410
Files:
lib/StaticAnalyzer/Frontend/Analy
ABataev updated this revision to Diff 43676.
ABataev marked 3 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D15709
Files:
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/Ta
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thanks!
Looks good with one nit. Do you need me to commit the patch for you?
Comment at: clang-tidy/readability/SimplifyBooleanExprCheck.cpp:519
@@ +518,3 @@
+
+ DiagnosticB
alexfh added a subscriber: alexfh.
alexfh added a comment.
I assume, Richard doesn't have svn commit access yet. I'll commit the patch for
him.
http://reviews.llvm.org/D10021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
Author: alexfh
Date: Mon Dec 28 07:06:58 2015
New Revision: 256491
URL: http://llvm.org/viewvc/llvm-project?rev=256491&view=rev
Log:
Refactor: Simplify boolean conditional return statements in
lib/StaticAnalyzer/Checkers
Summary: Use clang-tidy to simplify boolean conditional return values
Revi
61 matches
Mail list logo
