xazax.hun added a comment.
Thank you for the review!
Before committing this I would like to have a policy regarding future changes
and document it inside the IssueHash header.
My proposed policy is the following:
- Do not change the calculation of issue hash unless we have a very good reason
t
ABataev created this revision.
ABataev added a reviewer: aaron.ballman.
ABataev added a subscriber: cfe-commits.
Automatically insert line feed after pretty printing of all pragma-like
attributes.
http://reviews.llvm.org/D13546
Files:
include/clang/Basic/Attr.td
utils/TableGen/ClangAttrEmit
Hahnfeld added a comment.
In http://reviews.llvm.org/D9888#262389, @sfantao wrote:
> [...]
>
> I assume you were trying this using the diff in
> http://reviews.llvm.org/D12614. There was an inconsistency in the names of
> the ELF sections and symbols defined by the linker script in these two
>
Author: majnemer
Date: Thu Oct 8 02:45:35 2015
New Revision: 249667
URL: http://llvm.org/viewvc/llvm-project?rev=249667&view=rev
Log:
[Sema] Tweak incomplete enum types on MSVC ABI targets
Enums without an explicit, fixed, underlying type are implicitly given a
fixed 'int' type for ABI compatibi
kromanova updated this revision to Diff 36829.
kromanova added a comment.
Few more changes:
(1) There was a bug, where the PS4 driver didn't add input filename in the call
to external assembler.
Filipe fixed this problem in Tools.cpp
(2) A new testcase no-integrated-as.s was added for testing
Author: majnemer
Date: Thu Oct 8 03:28:09 2015
New Revision: 249670
URL: http://llvm.org/viewvc/llvm-project?rev=249670&view=rev
Log:
Update a few more tests in response to the MS ABI enum semantics
Our self hosting buildbots found a few more tests which weren't updated
to reflect that the enum
RedX2501 added a subscriber: klimek.
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10834
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
RedX2501 added a reviewer: klimek.
RedX2501 added a comment.
Ping
http://reviews.llvm.org/D10833
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: abataev
Date: Thu Oct 8 04:10:53 2015
New Revision: 249672
URL: http://llvm.org/viewvc/llvm-project?rev=249672&view=rev
Log:
[OPENMP 4.1] Codegen for array sections/subscripts in 'reduction' clause.
OpenMP 4.1 adds support for array sections/subscripts in 'reduction' clause.
Patch adds c
Author: majnemer
Date: Thu Oct 8 05:04:46 2015
New Revision: 249674
URL: http://llvm.org/viewvc/llvm-project?rev=249674&view=rev
Log:
[MSVC Compat] Try to treat an implicit, fixed enum as an unfixed enum
consider the following:
enum E *p;
enum E { e };
The above snippet is not ANSI C because 'e
djasper added a comment.
Please always add cfe-commits as "subscriber" so that the email also goes to
the list.
Repository:
rL LLVM
http://reviews.llvm.org/D13549
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
Author: d0k
Date: Thu Oct 8 05:31:17 2015
New Revision: 249676
URL: http://llvm.org/viewvc/llvm-project?rev=249676&view=rev
Log:
[Driver] Use Twine instead of itostr. NFC.
No need to construct temporary std::strings here.
Modified:
cfe/trunk/lib/Driver/Tools.cpp
Modified: cfe/trunk/lib/Dri
seaneveson updated this revision to Diff 36845.
seaneveson added a comment.
Move PR21606 test into const-method-call.cpp.
Added test for const calls on member objects.
Added tests for inherited const methods.
Changed TK_PreserveContents to be set for the base region. This is so memory is
still pr
hintonda added a comment.
Installed cmake 2.8.12 and was able to reproduce error.
I'll look into it, but I'm tempted to only support newer versions of cmake, and
let older versions maintain current behavior.
http://reviews.llvm.org/D13453
___
cfe-
xazax.hun added a comment.
In http://reviews.llvm.org/D13099#260531, @seaneveson wrote:
> There is an issue where pointers to the object (this) should cause it to be
> invalidated, but don't since TK_PreserveContents has been set.
>
> For example:
>
> class B;
> class A {
> B b;
> co
evgeny777 added a comment.
Can someone look at it, please?
http://reviews.llvm.org/D13383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! If you would be so kind as to add a test for #pragma
init_seg("bss"), that would be great -- it seems its printPrettyPragma never
put a newline in there for that at
curdeius updated this revision to Diff 36849.
curdeius added a comment.
Escape XML-reserved characters.
http://reviews.llvm.org/D13549
Files:
tools/clang-format-vs/ClangFormat/ClangFormatPackage.cs
tools/clang-format-vs/ClangFormat/Properties/AssemblyInfo.cs
tools/clang-format/ClangFormat
Ok, will do
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
08.10.2015 16:02, Aaron Ballman пишет:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks! If you would be so kind as to a
On Wed, Oct 7, 2015 at 2:38 PM, Richard Smith wrote:
> Marshall: ping, does the below satisfy your concerns about the direction
> here?
>
No, not really, because I'm worried about behavior changes with this
approach.
#include
isdigit(c);
will call different code before and after this p
ABataev retitled this revision from "[ATTR] Automatic line feed after
pragma-like attribute, NFC." to "[ATTR] Automatic line feed after pragma-like
attribute.".
ABataev updated this revision to Diff 36850.
ABataev added a comment.
Printing of pragma-like attributes for declarations did not worke
(Removing llvm-commits, adding cfe-commits)
On Wed, Oct 7, 2015 at 8:07 PM, Adrian Zgorzalek via llvm-commits
wrote:
> Hey,
>
> Here is an attempt to fix https://llvm.org/bugs/show_bug.cgi?id=25067.
Thank you for working on this!
>
> Summary:
>
> After introducing no_sanitize, we try to map no_
Forwarding to cfe-commits
Forwarded Message
Subject:[modules] PR24954
Date: Thu, 8 Oct 2015 15:53:55 +0200
From: Vassil Vassilev
To: Richard Smith , cfe-...@cs.uiuc.edu
CC: Ben Langmuir
Hi Richard,
I started working on https://llvm.org/bugs/show_bug.c
filcab accepted this revision.
filcab added a comment.
This revision is now accepted and ready to land.
LGTM. But let's wait for a !Sony dev to say something too.
Repository:
rL LLVM
http://reviews.llvm.org/D13482
___
cfe-commits mailing list
cfe
aaron.ballman added a comment.
Wow, good catch on the fact that this didn't work at all! Thank you for
tackling it.
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D
Author: dougk
Date: Thu Oct 8 09:18:02 2015
New Revision: 249692
URL: http://llvm.org/viewvc/llvm-project?rev=249692&view=rev
Log:
[Myriad]: default the Dwarf version to 2
Modified:
cfe/trunk/lib/Driver/ToolChains.h
cfe/trunk/test/Driver/myriad-toolchain.c
Modified: cfe/trunk/lib/Driver
Author: d0k
Date: Thu Oct 8 09:20:14 2015
New Revision: 249693
URL: http://llvm.org/viewvc/llvm-project?rev=249693&view=rev
Log:
[VFS] Use VFS instead of virtual files in PPCallbacks test.
Modified:
cfe/trunk/unittests/Lex/PPCallbacksTest.cpp
Modified: cfe/trunk/unittests/Lex/PPCallbacksTes
On Tue, Oct 6, 2015 at 3:36 PM, Richard Smith wrote:
> Split out of . This is a big change, but the same pattern
> as the prior ones.
>
> In this patch, you replicate the #ifdef XXX, __libcpp_XXX, #undef XXX
dance for all the isXXX functions. Is that because they're not required to
be actual fun
On Tue, Oct 6, 2015 at 3:42 PM, Richard Smith wrote:
> , an easy one. We guarantee a setjmp macro exists even if this
> header is somehow included from C (the C standard allows that, so it's not
> worth checking for __cplusplus).
>
> This looks fine to me.
-- Marshall
___
mkuper created this revision.
mkuper added reviewers: rafael, rnk.
mkuper added a subscriber: cfe-commits.
The Intel MCU psABI is a new soft-float ABI, based on the IA32 psABI.
The document describing the ABI can be found here:
https://github.com/hjl-tools/x86-psABI/wiki/iamcu-psABI-0.7.pdf
Pe
On Oct 8, 2015 7:19 AM, "Douglas Katzman via cfe-commits" <
cfe-commits@lists.llvm.org> wrote:
>
> Author: dougk
> Date: Thu Oct 8 09:18:02 2015
> New Revision: 249692
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249692&view=rev
> Log:
> [Myriad]: default the Dwarf version to 2
Just out of cu
pgousseau added a comment.
In http://reviews.llvm.org/D12901#262270, @zaks.anna wrote:
> I agree with Gabor. We should investigate how we can model the overflow on a
> cast correctly.
Yes I agree with Gabor too. I meant this change as a temporary workaround only,
I will investigate the modell
vkalintiris created this revision.
vkalintiris added a reviewer: mclow.lists.
vkalintiris added a subscriber: cfe-commits.
Most of the #ifdefs in the locale code would check for the existence of
GLIBC or for operating systems other than Linux. This patch considers the
case where GLIBC isn't availa
vkalintiris added a subscriber: vkalintiris.
Comment at: include/CMakeLists.txt:9
@@ -7,2 +8,3 @@
PATTERN ".svn" EXCLUDE
+ PATTERN "__config_site.in" EXCLUDE
${LIBCXX_SUPPORT_HEADER_PATTERN}
Kind of silly but I believe that the files used for auto-generated
jroelofs added a subscriber: jroelofs.
jroelofs added a comment.
I don't think it's correct to say that `!defined(__GLIBC__) &&
defined(__linux__) ==> Musl` (nor is the converse true). Unfortunately, Musl
intentionally doesn't provide that sort of macro [1], so to provide support for
Musl in l
Great! I did not notice, that we already have exactly the same logic in
SemaDeclAttr.cpp.
Maybe it would be possible even to refactor it in such a way that this code is
written only once.
Adrian
> On Oct 8, 2015, at 6:53 AM, Aaron Ballman wrote:
>
> (Removing llvm-commits, adding cfe-commits)
Author: chapuni
Date: Thu Oct 8 11:41:42 2015
New Revision: 249698
URL: http://llvm.org/viewvc/llvm-project?rev=249698&view=rev
Log:
CGStmtOpenMP.cpp: Prune redundant \param. [-Wdocumentation]
Modified:
cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
Modified: cfe/trunk/lib/CodeGen/CGStmtOpenMP.cpp
vkalintiris abandoned this revision.
vkalintiris added a comment.
In http://reviews.llvm.org/D13557#262801, @jroelofs wrote:
> Unfortunately, Musl intentionally doesn't provide that sort of macro [1], so
> to provide support for Musl in libc++, we need to make note of it at
> configure-time via
Feedback applied, new patch in the attachment.
Adrian
> On Oct 8, 2015, at 8:48 AM, Adrian Zgorzalek wrote:
>
> Great! I did not notice, that we already have exactly the same logic in
> SemaDeclAttr.cpp.
> Maybe it would be possible even to refactor it in such a way that this code
> is writte
Author: rengolin
Date: Thu Oct 8 11:43:26 2015
New Revision: 249699
URL: http://llvm.org/viewvc/llvm-project?rev=249699&view=rev
Log:
Simplify DefaultCPU in ARMTargetInfo
Simplifying the convoluted CPU handling in ARMTargetInfo.
The default base CPU on ARM is ARM7TDMI, arch ARMv4T, and
ARMTarge
> I think this actually makes it less general. You would presumably perform
> different inlining for:
>
> throw f(x, y);
>
> versus
>
> auto k = f(x, y);
> throw k;
We need to differentiate between these two. For the second case, we should
not add any attribute because its not invoked in th
rnk added a comment.
Looks like this got committed. Sorry for the delay, I was travelling.
http://reviews.llvm.org/D12832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: rnk
Date: Thu Oct 8 12:29:07 2015
New Revision: 249704
URL: http://llvm.org/viewvc/llvm-project?rev=249704&view=rev
Log:
[clang-cl] Make /EHs turn on C++ EH once again
C++ exceptions are still off by default, which is similar to how C++
cleanups are off by default in MSVC.
If you use cl
zaks.anna added a comment.
> Even if you do not deal with this case I think it would be great to have an
> XFAIL test with a fixme that describes this limitation.
Yes! Every time we have a test case that shows known limitations, we should add
it to the regression tests with a TODO explaining t
rnk added a comment.
I added this conditional check in r221415, with this message:
cmake: Only export targets in the standalone build
Trying to fix bots that didn't like the fact that I exported targets
that depended on LLVM without exporting targets from LLVM.
I assume this has already
beanz added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
samsonov wrote:
> So, that's the target that you can invoke manually to clean compi
aaron.ballman created this revision.
aaron.ballman added reviewers: alexfh, sbenza.
aaron.ballman added a subscriber: cfe-commits.
setjmp and longjmp facilities in C++ are unsafe due to the likelihood of
triggering undefined behavior with nontrivial type destruction, etc. Instead,
exception hand
sfantao updated this revision to Diff 36880.
sfantao added a comment.
Use class instead of structs if aggregate have private or protected fields.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/Lang
sfantao added a comment.
Thanks for the comments!
Comment at: lib/CodeGen/CGOpenMPRuntime.h:323
@@ +322,3 @@
+ /// far.
+ struct OffloadEntriesInfoManagerTy {
+CodeGenModule &CGM;
ABataev wrote:
> Maybe it is better to make it a class if it has some non-pu
On Thu, Oct 8, 2015 at 12:46 PM, Adrian Zgorzalek wrote:
> Feedback applied, new patch in the attachment.
Thank you for working on this! A few comments:
> From 13f4df6def5f26768f9ea048e013f779bb4a7814 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Adrian=20Zgorza=C5=82ek?=
> Date: Wed, 7 Oct 2015 1
On Thu, Oct 8, 2015 at 2:33 PM, Adrian Zgorzalek wrote:
> I so much like this fast review cycle :)
I aim to please. ;-)
>
> Comments applied.
LGTM with one nit:
+static bool normalizeName(StringRef& AttrName) {
Should be (StringRef &AttrName) per style guidelines. A good idea is
to run clang-
I so much like this fast review cycle :)
Comments applied.
Adrian
> On Oct 8, 2015, at 11:24 AM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 12:46 PM, Adrian Zgorzalek wrote:
>> Feedback applied, new patch in the attachment.
>
> Thank you for working on this! A few comments:
>
>> From 13f
On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith wrote:
> . This one is tricky:
>
> 1) There's an (undocumented) interface between the C standard library and
> this header, where the macros __need_ptrdiff_t, __need_size_t,
> __need_wchar_t, __need_NULL, __need_wint_t request just a piece of this
> h
ahatanak updated this revision to Diff 36886.
ahatanak added a comment.
Changed CodeGenModule::SetLLVMFunctionAttributesForDefinition to use early
return.
I'll first commit the NFC patch to fix
CodeGenModule::SetLLVMFunctionAttributesForDefinition and commit the rest after
that.
http://revie
hintonda updated this revision to Diff 36889.
hintonda added a comment.
- add back check for standalone and add cmake version
http://reviews.llvm.org/D13453
Files:
CMakeLists.txt
Index: CMakeLists.txt
===
--- CMakeLists.txt
+++
Run clang-format, diff is in SVN format.
Please, can you commit on behalf of me unless you are willing to grant me write
permission to the repo ;-)
Adrian
> On Oct 8, 2015, at 11:40 AM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 2:33 PM, Adrian Zgorzalek wrote:
>> I so much like this fa
Author: aaronballman
Date: Thu Oct 8 14:24:08 2015
New Revision: 249721
URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
Log:
When mapping no_sanitize_* attributes to no_sanitize attributes, handle
GNU-style formatting that involves prefix and suffix underscores. Cleans up
other usa
On Thu, Oct 8, 2015 at 2:50 PM, Adrian Zgorzalek wrote:
> Run clang-format, diff is in SVN format.
>
> Please, can you commit on behalf of me unless you are willing to grant me
> write permission to the repo ;-)
Thanks! I've commit in r249721. As for repo permissions, if you are
intending to cont
Author: ahatanak
Date: Thu Oct 8 14:30:57 2015
New Revision: 249722
URL: http://llvm.org/viewvc/llvm-project?rev=249722&view=rev
Log:
[CodeGen] Check if the Decl pointer passed is null, and if so, return
early.
This is needed in a patch I plan to commit later, in which a null Decl
pointer is pas
sbenza added inline comments.
Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
@@ +30,3 @@
+public:
+ explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
+ : PP(PP), Check(Check) {}
Why do you pass one as a pointer and one as a referenc
On Thu, Oct 8, 2015 at 3:47 PM, Samuel Benzaquen wrote:
> sbenza added inline comments.
>
>
> Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
> @@ +30,3 @@
> +public:
> + explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
> + : PP(PP), Check(Check) {}
aaron.ballman updated this revision to Diff 36890.
aaron.ballman marked an inline comment as done.
aaron.ballman added a comment.
Corrected a simple copy-paste error.
http://reviews.llvm.org/D13567
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/cert/CMakeLists.txt
clang-tidy/cert/Se
aaron.ballman closed this revision.
aaron.ballman added a comment.
Thank you for the fast turn-around! I've commit in r249727.
~Aaron
http://reviews.llvm.org/D13567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-b
Author: aaronballman
Date: Thu Oct 8 14:54:43 2015
New Revision: 249727
URL: http://llvm.org/viewvc/llvm-project?rev=249727&view=rev
Log:
Adding a checker (cert-err52-cpp) that detects use of setjmp or longjmp in C++
code. Corresponds to the CERT C++ secure coding rule:
https://www.securecoding
Author: echristo
Date: Thu Oct 8 15:10:18 2015
New Revision: 249733
URL: http://llvm.org/viewvc/llvm-project?rev=249733&view=rev
Log:
Handle sse turning on mmx, but no -mmx not turning off SSE.
Rationale :
// sse3
__m128d test_mm_addsub_pd(__m128d A, __m128d B) {
return _mm_addsub_pd(A, B);
}
Author: echristo
Date: Thu Oct 8 15:10:14 2015
New Revision: 249732
URL: http://llvm.org/viewvc/llvm-project?rev=249732&view=rev
Log:
Migrate most feature map inclusion to initFeatureMap for the x86 target so
that we can build up an accurate set of features rather than relying on
TargetInfo initi
On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: aaronballman
> Date: Thu Oct 8 14:24:08 2015
> New Revision: 249721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
> Log:
> When mapping no_sanitize_* attributes to no_s
On Thu, Oct 8, 2015 at 6:27 AM, Marshall Clow wrote:
> On Wed, Oct 7, 2015 at 2:38 PM, Richard Smith
> wrote:
>
>> Marshall: ping, does the below satisfy your concerns about the direction
>> here?
>>
>
> No, not really, because I'm worried about behavior changes with this
> approach.
>
> #in
On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
> wrote:
>>
>> Author: aaronballman
>> Date: Thu Oct 8 14:24:08 2015
>> New Revision: 249721
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249721&view=rev
>> Log:
>> When ma
Author: ahatanak
Date: Thu Oct 8 15:26:34 2015
New Revision: 249735
URL: http://llvm.org/viewvc/llvm-project?rev=249735&view=rev
Log:
[CodeGen] [CodeGen] Attach function attributes to functions created in
CGBlocks.cpp.
This commit fixes a bug in clang's code-gen where it creates the
following fu
This revision was automatically updated to reflect the committed changes.
Closed by commit rL249735: [CodeGen] [CodeGen] Attach function attributes to
functions created in (authored by ahatanak).
Changed prior to commit:
http://reviews.llvm.org/D13525?vs=36886&id=36891#toc
Repository:
rL LLV
On Thu, Oct 8, 2015 at 7:23 AM, Marshall Clow wrote:
> On Tue, Oct 6, 2015 at 3:36 PM, Richard Smith
> wrote:
>
>> Split out of . This is a big change, but the same pattern
>> as the prior ones.
>>
>> In this patch, you replicate the #ifdef XXX, __libcpp_XXX, #undef XXX
> dance for all the isXX
Author: rsmith
Date: Thu Oct 8 15:34:11 2015
New Revision: 249737
URL: http://llvm.org/viewvc/llvm-project?rev=249737&view=rev
Log:
Factor definition of std::nullptr_t out of into a header that can
also be used by .
Added:
libcxx/trunk/include/__nullptr
- copied, changed from r249736
Author: rsmith
Date: Thu Oct 8 15:36:30 2015
New Revision: 249738
URL: http://llvm.org/viewvc/llvm-project?rev=249738&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/ctype.h
- copied, changed from r249736, libcxx/trunk/include/cctype
Modified:
libcxx/trunk/include/cctype
Author: rsmith
Date: Thu Oct 8 15:37:44 2015
New Revision: 249740
URL: http://llvm.org/viewvc/llvm-project?rev=249740&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/float.h
- copied, changed from r249736, libcxx/trunk/include/cfloat
Modified:
libcxx/trunk/include/cfloat
Author: rsmith
Date: Thu Oct 8 15:37:11 2015
New Revision: 249739
URL: http://llvm.org/viewvc/llvm-project?rev=249739&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/errno.h
- copied, changed from r249736, libcxx/trunk/include/cerrno
Modified:
libcxx/trunk/include/cerrno
Author: rsmith
Date: Thu Oct 8 15:38:53 2015
New Revision: 249741
URL: http://llvm.org/viewvc/llvm-project?rev=249741&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/inttypes.h
- copied, changed from r249736, libcxx/trunk/include/cinttypes
Modified:
libcxx/trunk/include/c
eugenis created this revision.
eugenis added a reviewer: echristo.
eugenis added a subscriber: cfe-commits.
eugenis set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
Depends on http://reviews.llvm.org/D13571
Repository:
rL LLVM
http://r
Hey!
I think you are right. This will not regress any of the cases, because previous
behaviour either checked str.size() >= 4 OR didn’t check it at all, but then
called .substr(2, str.size() - 4), which would crash. I think, though, that
explicitly checking str.size() >= 4 makes sense. See comm
Author: rsmith
Date: Thu Oct 8 15:41:26 2015
New Revision: 249743
URL: http://llvm.org/viewvc/llvm-project?rev=249743&view=rev
Log:
Split out of .
Added:
libcxx/trunk/include/setjmp.h
- copied, changed from r249736, libcxx/trunk/include/csetjmp
Modified:
libcxx/trunk/include/csetj
On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
wrote:
> On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith
> wrote:
> > On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
> > wrote:
> >>
> >> Author: aaronballman
> >> Date: Thu Oct 8 14:24:08 2015
> >> New Revision: 249721
> >>
> >> URL:
On Thu, Oct 8, 2015 at 4:49 PM, Richard Smith wrote:
> On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
> wrote:
>>
>> On Thu, Oct 8, 2015 at 4:16 PM, Richard Smith
>> wrote:
>> > On Thu, Oct 8, 2015 at 12:24 PM, Aaron Ballman via cfe-commits
>> > wrote:
>> >>
>> >> Author: aaronballman
>> >> Date
ABataev marked 2 inline comments as done.
Comment at: lib/AST/DeclPrinter.cpp:197
@@ -196,3 +196,3 @@
-void DeclPrinter::prettyPrintAttributes(Decl *D) {
+void DeclPrinter::prettyPrintAttributes(Decl *D, bool PrintPragmas) {
if (Policy.PolishForDeclaration)
a
srhines added a comment.
LGTM
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Pending naming from llvm review, LGTM.
On Thu, Oct 8, 2015 at 1:55 PM Stephen Hines wrote:
> srhines added a comment.
>
> LGTM
>
>
> Repository:
> rL LLVM
>
> http://reviews.llvm.org/D13572
>
>
>
>
___
cfe-commits mailing list
cfe-commits@lists.llvm.
echristo added a subscriber: echristo.
echristo added a comment.
Pending naming from llvm review, LGTM.
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
On Thu, Oct 8, 2015 at 9:54 AM, wrote:
> > I think this actually makes it less general. You would presumably perform
> > different inlining for:
> >
> > throw f(x, y);
> >
> > versus
> >
> > auto k = f(x, y);
> > throw k;
>
> We need to differentiate between these two. For the second case,
You are right, my bad, I thought this if covers all the cases, but part
could be empty.
Here is the fix:
Adrian
> On Oct 8, 2015, at 1:52 PM, Aaron Ballman wrote:
>
> On Thu, Oct 8, 2015 at 4:49 PM, Richard Smith wrote:
>> On Thu, Oct 8, 2015 at 1:21 PM, Aaron Ballman
>> wrote:
>>>
>>> On
Author: rnk
Date: Thu Oct 8 16:14:56 2015
New Revision: 249748
URL: http://llvm.org/viewvc/llvm-project?rev=249748&view=rev
Log:
[WinEH] Push cleanupendpad scopes around exceptional cleanups
We were only doing this for SEH as a special case. Generalize it to all
cleanups.
Modified:
cfe/trun
On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> You are right, my bad, I thought this if covers all the cases, but
> part could be empty.
>
> Here is the fix
>
Please add a testcase ("__attribute__((ownership_takes(__))) void f();"
maybe?).
Author: rsmith
Date: Thu Oct 8 16:17:21 2015
New Revision: 249749
URL: http://llvm.org/viewvc/llvm-project?rev=249749&view=rev
Log:
Fix incorrect file header. This is not .
Modified:
libcxx/trunk/include/cfenv
Modified: libcxx/trunk/include/cfenv
URL:
http://llvm.org/viewvc/llvm-project/l
Author: eugenis
Date: Thu Oct 8 16:21:44 2015
New Revision: 249751
URL: http://llvm.org/viewvc/llvm-project?rev=249751&view=rev
Log:
Use Triple.isAndroid() where possible.
Modified:
cfe/trunk/lib/Basic/Targets.cpp
cfe/trunk/lib/Driver/SanitizerArgs.cpp
cfe/trunk/lib/Driver/ToolChain.
eugenis closed this revision.
eugenis added a comment.
r249751
Repository:
rL LLVM
http://reviews.llvm.org/D13572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna added a comment.
Now that we have a way to test symbol reaper, please, add more coverage to the
symbol-reaper.c test, including the test that Jordan mentioned. Even if it is
not fixed, it's good to include it with a FIXME note.
What is the performance impact of this change?
The chang
There are some other open problems in this area:
- RecursiveASTVisitor on nested InitListExprs is currently worst-case
exponential time because it walks the syntactic and semantic forms
separately
- Tools such as "find all references to this function" need the semantic
form of every initializer, w
george.burgess.iv added a comment.
Friendly Ping™
http://reviews.llvm.org/D12821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
On Oct 8, 2015, at 2:17 PM, Richard Smith
mailto:rich...@metafoo.co.uk>> wrote:
On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits
mailto:cfe-commits@lists.llvm.org>> wrote:
You are right, my bad, I thought this if covers all the cases, but part
could be empty.
Here is the fix
On Thu, Oct 8, 2015 at 2:45 PM, Adrian Zgorzalek wrote:
>
> On Oct 8, 2015, at 2:17 PM, Richard Smith wrote:
>
> On Thu, Oct 8, 2015 at 2:10 PM, Adrian Zgorzalek via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> You are right, my bad, I thought this if covers all the cases, but
>> par
beanz updated this revision to Diff 36897.
beanz added a comment.
Updates to fix dependency mapping.
Compiler-rt will be cleaned and rebuilt if clang changes and reconfigured if
llvm-config or clang changes.
http://reviews.llvm.org/D13399
Files:
runtime/CMakeLists.txt
Index: runtime/CMakeL
Yes, these are functionally equivalent. However, the difference between
these two is that the call to f() in 1st is in sub-expression of throw
statement, while the call in 2nd is not.
If the call is in the sub-expression of throw statements, we can guarantee
that the call is only invoked to be thr
1 - 100 of 132 matches
Mail list logo
