On Thu, Oct 8, 2015 at 3:47 PM, Samuel Benzaquen <sbe...@google.com> wrote:
> sbenza added inline comments.
>
> ================
> Comment at: clang-tidy/cert/SetLongJmpCheck.cpp:31
> @@ +30,3 @@
> +public:
> +  explicit SetJmpMacroCallbacks(Preprocessor *PP, SetLongJmpCheck &Check)
> +      : PP(PP), Check(Check) {}
> ----------------
> Why do you pass one as a pointer and one as a reference?

Bad copy-pasta. I don't even need PP. Good catch! I will remove that.

~Aaron

>
>
> http://reviews.llvm.org/D13567
>
>
>
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to