rsmith added a comment.
Sorry, this is not OK; we need to eagerly instantiate within a `decltype`
expression in some cases, and we should not be treating `decltype` as being
different from any other unevaluated operand here. Example:
template constexpr T f() { return 0; }
decltype(char{f()}
mgehre marked an inline comment as done.
Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:53
@@ +52,3 @@
+ } else {
+diag(MatchedCast->getOperatorLoc(), "do not use static_cast to cast from
base class to derived class.");
+ }
aaro
Eugene.Zelenko added a subscriber: Eugene.Zelenko.
Eugene.Zelenko added a comment.
Will be good idea to review checks one by one.
Checks should be named after function, not after author. If existing categories
too wide, new one could be introduced, like performance
(clocky-inefficient-container
loladiro updated this revision to Diff 36565.
loladiro added a comment.
Address review comment re loop structure. Reword comment that had a typo to
both fix the typo and make the intent of the code more clear.
Repository:
rL LLVM
http://reviews.llvm.org/D13419
Files:
lib/AST/Decl.cpp
li
mgehre updated this revision to Diff 36567.
mgehre marked 2 inline comments as done.
mgehre added a comment.
Simplify logic to check for BaseToDerived cast. Add test for object to
reference cast. Fixed comments
http://reviews.llvm.org/D13368
Files:
clang-tidy/cppcoreguidelines/CMakeLists.txt
mgehre added inline comments.
Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33
@@ +32,3 @@
+ const auto *SourceDecl = SourceType->getPointeeCXXRecordDecl();
+ if(!SourceDecl)
+SourceDecl = SourceType->getAsCXXRecordDecl();
aaron
hintonda created this revision.
hintonda added a reviewer: chapuni.
hintonda added a subscriber: cfe-commits.
Always generate and install cmake config files.
Currently, cmake config files are only generated and installed when
CLANG_BUILD_STANDALONE set, which means config file will not be genera
Author: marshall
Date: Mon Oct 5 18:27:10 2015
New Revision: 249363
URL: http://llvm.org/viewvc/llvm-project?rev=249363&view=rev
Log:
Mark 2259 and 2473 as complete. Add some more notes
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/ll
rsmith added inline comments.
Comment at: include/clang/AST/DeclOpenMP.h:95
@@ +94,3 @@
+/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in)
+/// initializer (omp_priv = 0)
+/// \endcode
I think automatic formatting has messed up your example.
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
This seems reasonable.
I wonder if it might be better to also suppress warnings for
dynamically-unreachable code (you can do this by changing the `Diag` calls
inside `CheckNonNullArguments` t
EricWF added a comment.
I think thing change will help us close a number out outstanding bugs. I don't
have any fundamental objections to this approach. However the size of this
patch scares me. I understand the changes are mostly mechanical but their size
can hide things. For example has an
EricWF added a comment.
`DiagRuntimeBehavior` seems like a better way to do this. I'll commit that
change.
http://reviews.llvm.org/D13408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: ericwf
Date: Mon Oct 5 23:12:30 2015
New Revision: 249372
URL: http://llvm.org/viewvc/llvm-project?rev=249372&view=rev
Log:
Add comments for LWG issues 2219 and 2367
Modified:
libcxx/trunk/www/kona.html
Modified: libcxx/trunk/www/kona.html
URL:
http://llvm.org/viewvc/llvm-project/l
101 - 113 of 113 matches
Mail list logo
