mgehre added inline comments. ================ Comment at: clang-tidy/cppcoreguidelines/ProTypeStaticCastDowncastCheck.cpp:33 @@ +32,3 @@ + const auto *SourceDecl = SourceType->getPointeeCXXRecordDecl(); + if(!SourceDecl) + SourceDecl = SourceType->getAsCXXRecordDecl(); ---------------- aaron.ballman wrote: > In the event it's not a pointer or a reference, why are you getting the > source as a value type? Source type could be no pointer nor ref like in: Base B0; auto R0 = static_cast<Derived&>(B0);
http://reviews.llvm.org/D13368 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits