Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

RKSimon updated this revision to Diff 32514. RKSimon added a comment. Added ia32 builtin undef intrinsics (I didn't bother with the mmx as I can't find any evidence of an undefined intrinsic for it). Added the avx512 intrinsics referenced in the intel intrinsics guide. Technically there's nothi

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

alexfh added a comment. Looks good. Thanks for the fix! Repository: rL LLVM http://reviews.llvm.org/D9286 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12076: Add loop-convert check to clang-tidy.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Awesome! Thanks for converting this to a clang-tidy check! I'll submit the patch for you. http://reviews.llvm.org/D12076 ___ cfe-commits mailing

Re: [PATCH] D12076: Add loop-convert check to clang-tidy.

alexfh closed this revision. alexfh added a comment. Committed revision 245427. http://reviews.llvm.org/D12076 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added a comment. In http://reviews.llvm.org/D11781#227446, @EricWF wrote: > This patch has a long way to go but it has also come a long way. Here are a > couple of problems I see with it. > > 2. This patch adds a lot of headers. libc++ has historically tried to keep > the number

Re: [PATCH] D11781: Refactored pthread usage in libcxx

espositofulvio added inline comments. Comment at: include/__mutex_base:36 @@ -35,3 +37,3 @@ #else - mutex() _NOEXCEPT {__m_ = (pthread_mutex_t)PTHREAD_MUTEX_INITIALIZER;} #endif EricWF wrote: > Why was the cast insignificant? The cast was significant, but it

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

mkuper added a comment. I think this is slightly less elegant than having a generic builtin, but I'm just fine with it, especially if David/Eric prefer it to the generic version. Repository: rL LLVM http://reviews.llvm.org/D12052 ___ cfe-commits

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

mkuper added a comment. Actually, thinking about it a bit more, a generic builtin most probably won't be more elegant. LGTM. Repository: rL LLVM http://reviews.llvm.org/D12052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

alexfh added a comment. Sorry for the delay. Here are some more comments. Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:33 @@ -30,2 +32,3 @@ Opts["modernize-pass-by-value.IncludeStyle"] = "llvm"; // Also: "google". +Opts["modernize-use-nullptr.UserNullMacros"

Re: [PATCH] D10933: Add new IdentifierNaming check

alexfh added a comment. Another couple of comments (fine for a follow-up). Comment at: test/clang-tidy/readability-identifier-naming.cpp:72 @@ +71,3 @@ + +namespace FOO_NS { +// CHECK-MESSAGES: :[[@LINE-1]]:1: warning: invalid case style for namespace 'FOO_NS' [readability-iden

Re: [PATCH] D11361: [OpenMP] Target directive host codegen

ABataev added inline comments. Comment at: lib/CodeGen/CGExpr.cpp:1969-1970 @@ -1945,4 +1968,4 @@ else - return EmitCapturedFieldLValue(*this, CapturedStmtInfo->lookup(VD), - CapturedStmtInfo->getContextValue()); +

[PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

RKSimon created this revision. RKSimon added reviewers: qcolombet, craig.topper, ab, spatel, silvas. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Sister patch to D10555 As discussed on D10555, this patch replaces the use of the avx2.vbroadcast

[clang-tools-extra] r245429 - [clang-tidy] Add new IdentifierNaming check

Author: alexfh Date: Wed Aug 19 06:15:36 2015 New Revision: 245429 URL: http://llvm.org/viewvc/llvm-project?rev=245429&view=rev Log: [clang-tidy] Add new IdentifierNaming check This check will try to enforce coding guidelines on the identifiers naming. It supports lower_case, UPPER_CASE, camelBac

Re: [PATCH] D10933: Add new IdentifierNaming check

alexfh closed this revision. alexfh added a comment. Committed revision 245429. http://reviews.llvm.org/D10933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12144: Fix 4 typos in lib/Analysis/

loverszhaokai created this revision. loverszhaokai added reviewers: delesley, krememek. loverszhaokai added a subscriber: cfe-commits. Fix 4 typos: "Intialize" -> "Initialize" "accessable" -> "accessible" "modeled" -> "modelled" http://reviews.llvm.org/D12144 Files: lib/Analy

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

angelgarcia updated this revision to Diff 32539. angelgarcia marked 13 inline comments as done. angelgarcia added a comment. Fix comments. http://reviews.llvm.org/D12081 Files: clang-tidy/modernize/CMakeLists.txt clang-tidy/modernize/ModernizeTidyModule.cpp clang-tidy/modernize/UseNullptr

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Looks good! I'll fix the last issue (see the comment below) and commit the patch for you. Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:80 @@ +79,3 @@ + bool NeedsSpa

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

angelgarcia added a comment. Ok, thanks! :) http://reviews.llvm.org/D12081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12081: Add use-nullptr check to clang-tidy.

alexfh closed this revision. alexfh added a comment. Committed revision 245434. http://reviews.llvm.org/D12081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Author: alexfh Date: Wed Aug 19 08:13:12 2015 New Revision: 245434 URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev Log: [clang-tidy] Add use-nullptr check to clang-tidy. Move UseNullptr from clang-modernize to modernize module in clang-tidy. http://reviews.llvm.org/D12081 Patch by

[PATCH] D12147: Fix typos in lib/AST

loverszhaokai created this revision. loverszhaokai added reviewers: gbenyei, krememek, rsmith, ABataev, majnemer. loverszhaokai added a subscriber: cfe-commits. Fix typos: "modeled" -> "modelled" "protcol"-> "protocol" "overriden"-> "overridden" "endianess" ->"endiannes

[clang-tools-extra] r245435 - clang-tools-extra/test/clang-tidy/readability-identifier-naming.cpp: Appease targeting msvc.

Author: chapuni Date: Wed Aug 19 08:22:58 2015 New Revision: 245435 URL: http://llvm.org/viewvc/llvm-project?rev=245435&view=rev Log: clang-tools-extra/test/clang-tidy/readability-identifier-naming.cpp: Appease targeting msvc. Modified: clang-tools-extra/trunk/test/clang-tidy/readability-ide

[PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 created this revision. olista01 added a subscriber: cfe-commits. olista01 set the repository for this revision to rL LLVM. Herald added subscribers: rengolin, aemerson. The ACLE (ARM C Language Extensions) 2.0 allows the __fp16 type to be used as a functon argument or return type (ACLE 1.

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

alexfh added a comment. Sorry for the long delay. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:40 @@ +39,3 @@ + for (const auto *Ctor : CopyCtor->getParent()->ctors()) { +if (Ctor->isMoveConstructor() && +Ctor->getAccess() <= AS_protected &&

[PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

ABataev created this revision. ABataev added reviewers: hans, fraggamuffin, ejstotzer, hfinkel. ABataev added a subscriber: cfe-commits. http://reviews.llvm.org/D12152 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --

Re: [Diffusion] rL245435: clang-tools-extra/test/clang-tidy/readability-identifier-naming.cpp: Appease…

chapuni added a subscriber: cfe-commits. chapuni added a comment. Targeting msvc (-triple *-win32) implies a few -f options. You can reproduce the failure with -fdelayed-template-parsing, or -triple i686-win32. Eyes might be increased if python version of check_clang_tidy.sh were introduced. Fo

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman added inline comments. Comment at: clang-tidy/misc/MoveConstructorInitCheck.cpp:40 @@ +39,3 @@ + for (const auto *Ctor : CopyCtor->getParent()->ctors()) { +if (Ctor->isMoveConstructor() && +Ctor->getAccess() <= AS_protected && alexfh wro

Re: [PATCH] D11845: Properly pass through the PIC mode to the integrated assembler when doing assembly-only, and unify the Driver's PIC argument parsing.

jyknight added a comment. Joerg said LGTM on #llvm; going ahead with commit. http://reviews.llvm.org/D11845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245445 - [ARM] Proper generic cpus handling

Author: vsukharev Date: Wed Aug 19 09:50:18 2015 New Revision: 245445 URL: http://llvm.org/viewvc/llvm-project?rev=245445&view=rev Log: [ARM] Proper generic cpus handling "generic" cpu was wrongly handled as exact real CPU name of ARMv8.1A architecture. This has been fixed, now it is abstract n

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

eliben accepted this revision. eliben added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D12122 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

Re: [PATCH] D11845: Properly pass through the PIC mode to the integrated assembler when doing assembly-only, and unify the Driver's PIC argument parsing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245447: Properly pass through the PIC mode to the integrated assembler when (authored by jyknight). Changed prior to commit: http://reviews.llvm.org/D11845?vs=32216&id=32552#toc Repository: rL LLVM

r245447 - Properly pass through the PIC mode to the integrated assembler when

Author: jyknight Date: Wed Aug 19 10:12:02 2015 New Revision: 245447 URL: http://llvm.org/viewvc/llvm-project?rev=245447&view=rev Log: Properly pass through the PIC mode to the integrated assembler when doing assembly-only, and unify the Driver's PIC argument parsing. On a few architectures, pars

[libcxxabi] r245449 - [AArch64] Quick fix for cxa demangler

Author: rengolin Date: Wed Aug 19 10:24:03 2015 New Revision: 245449 URL: http://llvm.org/viewvc/llvm-project?rev=245449&view=rev Log: [AArch64] Quick fix for cxa demangler This makes all libcxxabi tests pass on AArch64. Further changes and new tests to come. Patch by Keith Walker. Modified:

FunctionDecl::getBody() returning nullptr

When I run the following test code through clang-tidy -checks=*, I get a crash from some relatively strange behavior with FunctionDecl. template struct remove_reference {typedef T type;}; template struct remove_reference {typedef T type;}; template struct remove_reference {typedef T type;

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

jmolloy added a subscriber: jmolloy. Comment at: lib/CodeGen/TargetInfo.cpp:4717 @@ -4716,1 +4716,3 @@ + // __fp16 gets passed as if it were an int or float, but with the top 32 bits + // unspecified. "Top 16 bits"? Comment at: lib/CodeGen/Ta

Re: [PATCH] D12144: Fix 4 typos in lib/Analysis/

delesley added a comment. Looks good for the thread safety stuff. http://reviews.llvm.org/D12144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12144: Fix 4 typos in lib/Analysis/

krememek added a comment. Looks fine in UninitializedValues. http://reviews.llvm.org/D12144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12148: [ARM] Allow passing/returning of __fp16 arguments

olista01 updated this revision to Diff 32558. olista01 added a comment. Fixed typo Repository: rL LLVM http://reviews.llvm.org/D12148 Files: lib/Basic/Targets.cpp lib/CodeGen/TargetInfo.cpp lib/Driver/Tools.cpp test/CodeGen/arm-fp16-arguments.c test/Preprocessor/arm-acle-6.5.c te

Re: [PATCH] D11555: [libcxx] Allow use of in C++03. Try 3.

mclow.lists accepted this revision. mclow.lists added a comment. This revision is now accepted and ready to land. I think this is ready to land now. Thanks, Eric. http://reviews.llvm.org/D11555 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#227444, @EricWF wrote: > I also just realized that this change will currently likely play havoc with > how libc++ and libc++abi build together. In order to build libc++ and > libc++abi together we would need to > > 1. Configure libc++

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman updated this revision to Diff 32559. aaron.ballman added a comment. Addressed review comments. I re-ran the updated patch against LLVM and Clang, and there were some more false positives that I would like to address if possible. It seems my previous run against the source base was

Re: [PATCH] D11784: [PATCH] clang-tidy check for incorrect move constructor initializers

aaron.ballman marked 5 inline comments as done. aaron.ballman added a comment. http://reviews.llvm.org/D11784 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12155: ARM: Error out on apple darwin platforms if float-abi is "hard"

ahatanak created this revision. ahatanak added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. Error out if user provides -mfloat-abi=hard or -mhard-float on the command line since hard float abi isn't supported on apple platforms (except for non-darwin platforms). http

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#227441, @EricWF wrote: > @jroelofs What do you think of an approach like this? Having two copies of the __config_site file makes me uncomfortable, but I could put up with that given that they're effectively the same for 99% of people

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

On Tue, Aug 18, 2015 at 6:11 PM, Richard Smith wrote: > On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote: >> >> Richard, I tried to ping you on the review thread but I'm not sure it >> got through. Martell requested this be merged to 3.7. What do you >> think? > > > LGTM Thanks! r245456. >

[PATCH] D12157: Fix LoopConvertCheck bug.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: klimek, cfe-commits. angelgarcia changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Fix LoopConvertCheck bug: StringRef to temporaries. http

[clang-tools-extra] r245458 - [clang-tidy] Fix LoopConvertCheck bug.

Author: alexfh Date: Wed Aug 19 11:54:51 2015 New Revision: 245458 URL: http://llvm.org/viewvc/llvm-project?rev=245458&view=rev Log: [clang-tidy] Fix LoopConvertCheck bug. Fix LoopConvertCheck bug: StringRef to temporaries. Also add LLVM_ATTRIBUTE_UNUSED to ModernizeModuleAnchorDestination. htt

Re: [PATCH] D12152: [OPENMP] Info about OpenMP Support in Users Manual

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. Thanks! Comment at: docs/UsersManual.rst:1860 @@ +1859,3 @@ + +clang fully implements all of standard OpenMP 3.1 directives and clauses + some +features of OpenMP 4.0, including `

Re: [PATCH] D12157: Fix LoopConvertCheck bug.

alexfh closed this revision. alexfh added a comment. Committed revision 245458. http://reviews.llvm.org/D12157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

ab added a comment. Heh, this is http://reviews.llvm.org/D10556, no? :P Repository: rL LLVM http://reviews.llvm.org/D12143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Author: yrnkrn Date: Wed Aug 19 12:02:32 2015 New Revision: 245459 URL: http://llvm.org/viewvc/llvm-project?rev=245459&view=rev Log: According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes. See https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html Added: cf

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

beanz accepted this revision. beanz added a reviewer: beanz. beanz added a comment. This revision is now accepted and ready to land. You are right, and I apparently don't know how to read documentation... Patch LGTM as is. http://reviews.llvm.org/D11682 __

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#227951, @jroelofs wrote: > In http://reviews.llvm.org/D11963#227441, @EricWF wrote: > > > @jroelofs What do you think of an approach like this? > > > Having two copies of the __config_site file makes me uncomfortable, but I > could put up

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

EricWF added a comment. In http://reviews.llvm.org/D11963#227933, @jroelofs wrote: > In http://reviews.llvm.org/D11963#227444, @EricWF wrote: > > > I also just realized that this change will currently likely play havoc with > > how libc++ and libc++abi build together. In order to build libc++ an

[libcxxabi] r245461 - [libcxxabi] Add "install-libcxxabi" target.

Author: ericwf Date: Wed Aug 19 12:17:21 2015 New Revision: 245461 URL: http://llvm.org/viewvc/llvm-project?rev=245461&view=rev Log: [libcxxabi] Add "install-libcxxabi" target. Summary: Currently you can't install libc++abi from within the LLVM tree without installing all of LLVM. This patch add

r245462 - Add REQUIRES: x86-registered-target to test since it's required.

Author: yrnkrn Date: Wed Aug 19 12:18:32 2015 New Revision: 245462 URL: http://llvm.org/viewvc/llvm-project?rev=245462&view=rev Log: Add REQUIRES: x86-registered-target to test since it's required. Modified: cfe/trunk/test/CodeGen/mingw-long-double-size.c Modified: cfe/trunk/test/CodeGen/mi

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Sorry to notice late (just diagnosed the issue from a failing boost::math test), according to i686 ABI, long double size on x86 is 12 bytes (the memory allocated, not the underlying 80 bits register), see https://gcc.gnu.org/onlinedocs/gcc-3.2/gcc/i386-and-x86-64-Options.html -m128bit-long-double

[libcxx] r245463 - [libcxx] Allow use of in C++03. Try 3.

Author: ericwf Date: Wed Aug 19 12:21:46 2015 New Revision: 245463 URL: http://llvm.org/viewvc/llvm-project?rev=245463&view=rev Log: [libcxx] Allow use of in C++03. Try 3. Summary: After putting this question up on cfe-dev I have decided that it would be best to allow the use of `` in C++03. Al

Re: FunctionDecl::getBody() returning nullptr

On Wed, Aug 19, 2015 at 11:33 AM, Aaron Ballman wrote: > When I run the following test code through clang-tidy -checks=*, I get > a crash from some relatively strange behavior with FunctionDecl. > > template struct remove_reference {typedef T type;}; > template struct remove_reference {typ

Re: [PATCH] D12002: Initial WebAssembly support in clang

jfb added a comment. Still lgtm, with minor comments. Comment at: lib/CodeGen/ItaniumCXXABI.cpp:364 @@ +363,3 @@ +ItaniumCXXABI(CGM, /* UseARMMethodPtrABI = */ true, + /* UseARMGuardVarABI = */ true) {} + It's more common to have no spaces f

Re: [PATCH] D12128: Generating available_externally vtables bugfix

rjmccall added a comment. LGTM. http://reviews.llvm.org/D12128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12117: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()

This revision was automatically updated to reflect the committed changes. Closed by commit rL245467: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback() (authored by samsonov). Changed prior to commit: http://reviews.llvm.org/D12117?vs=32456&id=32572#toc Repository: rL

[libcxx] r245467 - Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()

Author: samsonov Date: Wed Aug 19 12:28:01 2015 New Revision: 245467 URL: http://llvm.org/viewvc/llvm-project?rev=245467&view=rev Log: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback() Summary: We are going to remove the former soon. Reviewers: EricWF Subscribers: cfe-c

Re: [PATCH] D11697: [libcxx] Add "install-libcxx" target.

EricWF accepted this revision. EricWF added a reviewer: EricWF. EricWF added a comment. This revision is now accepted and ready to land. http://reviews.llvm.org/D11682 got accepted and this patch is almost identical. Accepting this patch so it can be committed. http://reviews.llvm.org/D11697

[PATCH] D12162: Remove reference.

angelgarcia created this revision. angelgarcia added a reviewer: alexfh. angelgarcia added subscribers: cfe-commits, klimek. angelgarcia changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users". Remove a reference where a value was intended (its being

[libcxx] r245468 - Remove test_atomic.h header

Author: ericwf Date: Wed Aug 19 12:37:34 2015 New Revision: 245468 URL: http://llvm.org/viewvc/llvm-project?rev=245468&view=rev Log: Remove test_atomic.h header Because can now be used in C++03 there is no need for the test_atomic.h header. This commit removes the header and converts all usages

Re: [PATCH] D12162: Remove reference.

alexfh added inline comments. Comment at: clang-tidy/modernize/UseNullptrCheck.cpp:178 @@ -177,3 +177,3 @@ CastSequenceVisitor(ASTContext &Context, SmallVector UserNullMacros, ClangTidyCheck &check) Please use Array

[libcxx] r245470 - [libcxx] Add "install-libcxx" target.

Author: ericwf Date: Wed Aug 19 12:41:53 2015 New Revision: 245470 URL: http://llvm.org/viewvc/llvm-project?rev=245470&view=rev Log: [libcxx] Add "install-libcxx" target. Summary: Currently you can't install libc++ from within the LLVM tree without installing all of LLVM. This patch adds an inst

[PATCH] D12163: [Patch] [Analyzer] BugReporter.cpp:2869: Assertion failed: !RemainingNodes.empty() && "No error node found in the trimmed graph" (PR 24184)

MaggieYi created this revision. MaggieYi added a reviewer: krememek. MaggieYi added a subscriber: cfe-commits. Dear All, I would like to propose a patch to solve an assertion failure reported by Dmitry in https://llvm.org/bugs/show_bug.cgi?id=24184. The assertion is caused by reusing a “filler”

Re: [PATCH] D11740: ABI versioning macros for libc++

EricWF added a comment. Some more questions: - Should bumping the ABI major version bump the SO version? - Should bumping the ABI major version change the include path from `include/c++/v1` to `include/c++/v2`? What kind of clang support do we need to do this? Repository: rL LLVM http://re

Re: [PATCH] D12162: Remove reference.

angelgarcia changed the visibility of this Differential Revision from "All Users" to "Public (No Login Required)". angelgarcia updated this revision to Diff 32576. angelgarcia added a comment. Use ArrayRef. http://reviews.llvm.org/D12162 Files: clang-tidy/modernize/UseNullptrCheck.cpp Index

Re: r245344 - [sanitizer] Add -lutil to static runtime link flags.

On Tue, Aug 18, 2015 at 1:36 PM, Evgeniy Stepanov via cfe-commits wrote: > Author: eugenis > Date: Tue Aug 18 15:36:11 2015 > New Revision: 245344 > > URL: http://llvm.org/viewvc/llvm-project?rev=245344&view=rev > Log: > [sanitizer] Add -lutil to static runtime link flags. > > This is needed to pr

Re: [PATCH] D12162: Remove reference.

alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thanks! LG http://reviews.llvm.org/D12162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Author: alexfh Date: Wed Aug 19 12:50:22 2015 New Revision: 245471 URL: http://llvm.org/viewvc/llvm-project?rev=245471&view=rev Log: [clang-tidy] Fix a bug in UseNullptrCheck. http://reviews.llvm.org/D12162 Patch by Angel Garcia! Modified: clang-tools-extra/trunk/clang-tidy/modernize/UseNul

Re: [PATCH] D12162: Remove reference.

alexfh closed this revision. alexfh added a comment. Committed revision 245471. http://reviews.llvm.org/D12162 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12164: Stop treating -static as overriding -fPIC: they are distinct.

jyknight created this revision. jyknight added a reviewer: joerg. jyknight added subscribers: rnk, jevinskie, tberghammer, danalbert, srhines, cfe-commits. For some reason, clang had been treating a command like: clang -static -fPIC foo.c as if it should be compiled without the PIC relocation mo

Re: [PATCH] D12164: Stop treating -static as overriding -fPIC: they are distinct.

danalbert added inline comments. Comment at: lib/Driver/Tools.cpp:3025 @@ -3024,3 +3024,3 @@ - // Note that these flags are trump-cards. Regardless of the order w.r.t. the - // PIC or PIE options above, if these show up, PIC is disabled. + // Note that this flag is a trump-ca

Re: [PATCH] D11963: Create a __config_site file to capture configuration decisions.

jroelofs added a comment. In http://reviews.llvm.org/D11963#228024, @EricWF wrote: > Wouldn't it still be a mess if you build both libc++ and libc++abi > out-of-tree? The user would have to be aware of these weird requirements. Oh, yeah, true. Do we have any out-of-tree builders to make sure t

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

On Wed, Aug 19, 2015 at 10:02 AM, Yaron Keren via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: yrnkrn > Date: Wed Aug 19 12:02:32 2015 > New Revision: 245459 > > URL: http://llvm.org/viewvc/llvm-project?rev=245459&view=rev > Log: > According to i686 ABI, long double size on x86 is 12

Re: [PATCH] D12128: Generating available_externally vtables bugfix

Prazek updated this revision to Diff 32587. http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/vtable-available-externally.cpp Index: test/CodeGenCXX/vtable-available-externally.cpp =

Re: [PATCH] D12047: test/SemaObjC: Remove cruft in unused getter test

rjmccall added a comment. Sure, fine to me. http://reviews.llvm.org/D12047 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245459 - According to i686 ABI, long double size on x86 is 12 bytes not 16 bytes.

Yes, it looks like a legacy issue. Documentation says so: *https://gcc.gnu.org/onlinedocs/gcc-4.8.2/gcc/i386-and-x86-64-Options.html * -m96bit-long-double-m128bit-long-doubleThese switches control the size of long double t

Re: [PATCH] D11781: Refactored pthread usage in libcxx

EricWF added a comment. In http://reviews.llvm.org/D11781#227606, @espositofulvio wrote: > In http://reviews.llvm.org/D11781#227446, @EricWF wrote: > > > This patch has a long way to go but it has also come a long way. Here are a > > couple of problems I see with it. > > > > 2. This patch adds a

Re: [PATCH] D11815: Pass subtarget feature "force-align-stack"

ahatanak updated this revision to Diff 32592. ahatanak added a comment. This patch makes changes to record function attribute "force-align-stack" instead of recording it as a subtarget feature. http://reviews.llvm.org/D11815 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

eugenis added a comment. +cfe-commits http://reviews.llvm.org/D12022 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] r245484 - Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage.

Author: aaronballman Date: Wed Aug 19 14:29:23 2015 New Revision: 245484 URL: http://llvm.org/viewvc/llvm-project?rev=245484&view=rev Log: Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage. Modified: clang-tools-extra/tr

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

sepavloff updated this revision to Diff 32597. sepavloff added a comment. Lambda functions are now treated as local classes. http://reviews.llvm.org/D11194 Files: include/clang/AST/DeclBase.h lib/AST/DeclBase.cpp lib/Sema/SemaTemplateInstantiate.cpp lib/Sema/SemaTemplateInstantiateDecl.

Re: [PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

RKSimon abandoned this revision. RKSimon added a comment. In http://reviews.llvm.org/D12143#228006, @ab wrote: > Heh, this is http://reviews.llvm.org/D10556, no? :P Yes you're right (and you remembered to kill the builtin defs) - please can you add some more reviewers so that we can get it dea

Re: [clang-tools-extra] r245471 - [clang-tidy] Fix a bug in UseNullptrCheck.

Hi Alexander We’re still getting a green dragon failure on the null ptr check test. Mind taking a look? http://lab.llvm.org:8080/green/job/clang-stage1-configure-RA_check/10351/consoleFull#50560140149ba4694-19c4-4d7e-bec5-911270d8a58c

Re: [PATCH] D12022: Refactored dtor sanitizing into EHScopeStack

nmusgrave updated this revision to Diff 32600. nmusgrave added a comment. - CFE test for dtor aliasing, and repression of aliasing in dtor code generation. http://reviews.llvm.org/D12022 Files: lib/CodeGen/CGCXX.cpp lib/CodeGen/CGClass.cpp test/CodeGenCXX/sanitize-dtor-repress-aliasing.c

Re: [PATCH] D10556: [Headers][X86] Replace avx2.pbroadcast intrinsics with native IR.

spatel accepted this revision. spatel added a comment. This revision is now accepted and ready to land. LGTM. See discussion in http://reviews.llvm.org/D10555. http://reviews.llvm.org/D10556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

Re: [clang-tools-extra] r245434 - [clang-tidy] Add use-nullptr check to clang-tidy.

Alexander Kornienko via cfe-commits writes: > Author: alexfh > Date: Wed Aug 19 08:13:12 2015 > New Revision: 245434 > > URL: http://llvm.org/viewvc/llvm-project?rev=245434&view=rev > Log: > [clang-tidy] Add use-nullptr check to clang-tidy. > > Move UseNullptr from clang-modernize to modernize mod

r245489 - Generating available_externally vtables bugfix

Author: prazek Date: Wed Aug 19 15:09:09 2015 New Revision: 245489 URL: http://llvm.org/viewvc/llvm-project?rev=245489&view=rev Log: Generating available_externally vtables bugfix Bugfix revealed in r245264. http://reviews.llvm.org/D12128 Modified: cfe/trunk/include/clang/AST/VTableBuilder.

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository for this revision to rL LLVM. > > This patch adds a -gmodules option to the driver and a -d

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

I assume this is a merge request? Richard: what do you think about r245459+r245462? On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren wrote: > Sorry to notice late (just diagnosed the issue from a failing boost::math > test), according to i686 ABI, long double size on x86 is 12 bytes (the > memory

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

> On Aug 19, 2015, at 1:12 PM, David Blaikie wrote: > > > > On Tue, Aug 11, 2015 at 1:49 PM, Adrian Prantl > wrote: > aprantl created this revision. > aprantl added reviewers: dblaikie, echristo. > aprantl added a subscriber: cfe-commits. > aprantl set the repository

Re: r220305 - Driver: Move crash report command mangling into Command::Print

On Wed, Aug 12, 2015 at 5:00 PM, Justin Bogner wrote: > On Wed, Aug 12, 2015 at 3:09 PM, David Blaikie wrote: > > On Tue, Oct 21, 2014 at 10:24 AM, Justin Bogner > > wrote: > >> Author: bogner > >> Date: Tue Oct 21 12:24:44 2014 > >> New Revision: 220305 > >> > >> URL: http://llvm.org/viewvc/ll

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Yes, worth merging with Richard approval. 2015-08-19 23:16 GMT+03:00 Hans Wennborg : > I assume this is a merge request? > > Richard: what do you think about r245459+r245462? > > > > On Wed, Aug 19, 2015 at 10:22 AM, Yaron Keren > wrote: > > Sorry to notice late (just diagnosed the issue from a

Fwd: [PATCH] Have clang list the imported modules in the debug info

(add the right list) -- Forwarded message -- From: David Blaikie Date: Wed, Aug 19, 2015 at 1:20 PM Subject: Re: [PATCH] Have clang list the imported modules in the debug info To: Adrian Prantl Cc: Eric Christopher , Zachary Turner < ztur...@google.com>, "Robinson, Paul" , Richard

[clang-tools-extra] r245492 - Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage.

Author: aaronballman Date: Wed Aug 19 15:26:22 2015 New Revision: 245492 URL: http://llvm.org/viewvc/llvm-project?rev=245492&view=rev Log: Replacing a custom AST matcher with some builtin AST matchers; NFC, and existing tests should provide sufficient coverage. Modified: clang-tools-extra/tr

  1   2   >