Re: [PATCH] D9924: Ignore report when the argument to malloc is assigned known value

hiraditya updated this revision to Diff 32381. hiraditya added a comment. Refactored the code and check whether denominator > 0. http://reviews.llvm.org/D9924 Files: lib/StaticAnalyzer/Checkers/MallocOverflowSecurityChecker.cpp test/Analysis/malloc-overflow.c test/Analysis/malloc-overflow

RE: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

I’m not sure how much people actually use these, but the AVX-512 versions of these, at least, can be very useful internally to implement AVX-512 intrinsics. For AVX-512, we use the same GCC builtin for all 3 versions of the intrinsic (pass-through masked, set to zero masked, and unmasked). This i

r245271 - [TreeTransform] Simplify code. No functionality change.

Author: d0k Date: Tue Aug 18 03:10:39 2015 New Revision: 245271 URL: http://llvm.org/viewvc/llvm-project?rev=245271&view=rev Log: [TreeTransform] Simplify code. No functionality change. Modified: cfe/trunk/lib/Sema/TreeTransform.h Modified: cfe/trunk/lib/Sema/TreeTransform.h URL: http://llv

Re: [PATCH] D11797: [libclang] Expose the ElaboratedType

skalinichev added a comment. Ping? Can someone commit it? http://reviews.llvm.org/D11797 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

RE: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

Please see updated patch file attached, which now includes a fixed/added regression test. Sjoerd. From: Sjoerd Meijer Sent: 17 August 2015 13:34 To: 'Gabriel Dos Reis'; Richard Smith Cc: Marshall Clow; cfe-commits Subject: RE: [PATCH] RE: [cfe-dev] missing return statement for non-void func

RE: [PATCH] RE: [cfe-dev] missing return statement for non-void functions in C++

> Please see updated patch file attached, which now includes a fixed/added > regression test. I think it's a good idea; two minor remarks: +if (!CGM.getCodeGenOpts().OptimizeSize) { Should this be 'else if'? I imagine there's no use emitting a trap after the sanitizer has emitted a missing_

Re: [PATCH] D12036: We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245304: We shouldn't need to pass -fno-strict-aliasing when building clang with clang. (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D12036?vs=32349&id=32420#toc Repository:

r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Author: cbieneman Date: Tue Aug 18 11:15:44 2015 New Revision: 245304 URL: http://llvm.org/viewvc/llvm-project?rev=245304&view=rev Log: We shouldn't need to pass -fno-strict-aliasing when building clang with clang. Summary: The code comments in the Makefile indicate this was put in place to supp

Re: [PATCH] D12076: Add loop-convert check to clang-tidy.

alexfh added a comment. In http://reviews.llvm.org/D12076#226476, @angelgarcia wrote: > Split the tests in several files. Thank you! Seems better like this. A few more comments. Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:293 @@ +292,3 @@ +return nullptr; + co

[clang-tools-extra] r245310 - [clang-tidy] Fixed typos and formatting in a comment. NFC

Author: alexfh Date: Tue Aug 18 11:43:07 2015 New Revision: 245310 URL: http://llvm.org/viewvc/llvm-project?rev=245310&view=rev Log: [clang-tidy] Fixed typos and formatting in a comment. NFC Modified: clang-tools-extra/trunk/clang-tidy/misc/AssertSideEffectCheck.h Modified: clang-tools-extra

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

sepavloff added inline comments. Comment at: lib/AST/DeclBase.cpp:273 @@ +272,3 @@ +return true; + if (const CXXRecordDecl *ClassD = dyn_cast(LDC)) +return ClassD->isLocalClass() && !ClassD->isLambda();; rsmith wrote: > It's not necessary for this change,

Re: [PATCH] Have clang list the imported modules in the debug info

(ping.) > On Aug 10, 2015, at 5:03 PM, Adrian Prantl wrote: > > [resending because I accidentally sent this to the old mailing list]. > >> On Jul 24, 2015, at 12:33 PM, David Blaikie > > wrote: >> >> *reads back through the thread* > > appreciated, it’s long :-) >

Re: [PATCH] D11958: Add a -gmodules option to the clang driver.

aprantl added a comment. Ping. Repository: rL LLVM http://reviews.llvm.org/D11958 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Tue Aug 18 11:15:44 2015 > New Revision: 245304 > > URL: http://llvm.org/viewvc/llvm-project?rev=245304&view=rev > Log: > We shouldn't need to pass -fno-strict-aliasing

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

The problems from my earlier mail still stand, even with trunk r245199. 1) Various configure scripts (e.g. lame and others) try to check for intrinsics using fragments similar to the following: #include then running that through "clang -E". If preprocessing succeeds, the intrinsics are assum

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

On Tue, Aug 18, 2015 at 10:51 AM Dimitry Andric wrote: > The problems from my earlier mail still stand, even with trunk r245199. > > 1) Various configure scripts (e.g. lame and others) try to check for > intrinsics using fragments similar to the following: > > #include > > then running that thro

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

No, it does not occur in the 3.7 branch, thanks for reverting those changes. :) -Dimitry > On 18 Aug 2015, at 01:09, Hans Wennborg wrote: > > The 3.7 branch does have the include guards; they were re-added in > http://llvm.org/viewvc/llvm-project?rev=243925&view=rev. That happened > after rc2,

r245320 - Update to reflect the library set in LLVM changing.

Author: chandlerc Date: Tue Aug 18 12:59:33 2015 New Revision: 245320 URL: http://llvm.org/viewvc/llvm-project?rev=245320&view=rev Log: Update to reflect the library set in LLVM changing. Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified: cfe/trunk/tools/driver/CMakeLists.txt URL: ht

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

> On 18 Aug 2015, at 19:52, Eric Christopher wrote: > > > > On Tue, Aug 18, 2015 at 10:51 AM Dimitry Andric wrote: > The problems from my earlier mail still stand, even with trunk r245199. > > 1) Various configure scripts (e.g. lame and others) try to check for > intrinsics using fragments s

Re: [PATCH] D9285: Add a KeepVirtual option to misc-use-override

alexfh added a comment. In http://reviews.llvm.org/D9285#224690, @ehsan wrote: > Sorry, I kind of dropped the ball here! > > At Mozilla we ended up deciding on allowing only a maximum of one of virtual, > final or override per function declaration, similar to the Google coding > style, so we wo

Re: [PATCH] D9286: Insert override at the same line as the end of the function declaration

alexfh added a comment. In http://reviews.llvm.org/D9286#224691, @ehsan wrote: > I should land this, but let's wait to see if we want > http://reviews.llvm.org/D9285 or not, since this patch is built on top of it. > If not, I can rebase it on top of master as well. We don't want http://revie

Re: r239883 - Update the intel intrinsic headers to use the target attribute support.

On Tue, Aug 18, 2015 at 11:05 AM Dimitry Andric wrote: > > On 18 Aug 2015, at 19:52, Eric Christopher wrote: > > > > > > > > On Tue, Aug 18, 2015 at 10:51 AM Dimitry Andric > wrote: > > The problems from my earlier mail still stand, even with trunk r245199. > > > > 1) Various configure scripts

r245323 - Make __builtin_object_size always answer correctly

Author: gbiv Date: Tue Aug 18 13:18:27 2015 New Revision: 245323 URL: http://llvm.org/viewvc/llvm-project?rev=245323&view=rev Log: Make __builtin_object_size always answer correctly __builtin_object_size would return incorrect answers for many uses where type=3. This fixes the inaccuracy by makin

[PATCH] D12109: [WinEH] Update to new EH pad/ret signatures (with tokens required)

JosephTremoulet created this revision. JosephTremoulet added reviewers: majnemer, rnk. JosephTremoulet added a subscriber: cfe-commits. The signatures of the methods in LLVM for creating EH pads/rets are changing to require token arguments on rets and assume token return type on pads. Update creat

Re: [PATCH] D12000: Bugfix - Clang handles __builtin_object_size in wrong way

george.burgess.iv closed this revision. george.burgess.iv added a comment. r245323 http://reviews.llvm.org/D12000 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] Fix out-of-bounds array access when setting arm float registers

Hi, Please find attached a patch fixing an out-of-bounds array access present in the current libunwind top of tree code. The problem is caused by subtracting the wrong base register in Registers_arm::SetFloatRegister and should become obvious after taking a quick look to the code. Could someone

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

> On Aug 18, 2015, at 10:48 AM, Nico Weber wrote: > > On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits > mailto:cfe-commits@lists.llvm.org>> wrote: > Author: cbieneman > Date: Tue Aug 18 11:15:44 2015 > New Revision: 245304 > > URL: http://llvm.org/viewvc/llvm-project?rev=245304

[libcxxabi] r245325 - Revert r243752, it broke running tests on OS X (PR24491).

Author: nico Date: Tue Aug 18 13:29:33 2015 New Revision: 245325 URL: http://llvm.org/viewvc/llvm-project?rev=245325&view=rev Log: Revert r243752, it broke running tests on OS X (PR24491). Modified: libcxxabi/trunk/test/lit.cfg Modified: libcxxabi/trunk/test/lit.cfg URL: http://llvm.org/vie

Re: [PATCH] D11932: [OPENMP] Link libomp.lib on Windows

rnk accepted this revision. rnk added a comment. lgtm http://reviews.llvm.org/D11932 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

On Tue, Aug 18, 2015 at 11:26 AM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > I don’t have access to gcc to test removing the flag there. I see no > reason not to remove it for gcc, but I haven’t and can’t test it. Someone > else will need to test it before committing.

[libcxx] r245330 - implement more of N4258 - Cleaning up noexcept in the standard library. Specifically add new noexcept stuff to vector and string's move-assignment operations

Author: marshall Date: Tue Aug 18 13:57:00 2015 New Revision: 245330 URL: http://llvm.org/viewvc/llvm-project?rev=245330&view=rev Log: implement more of N4258 - Cleaning up noexcept in the standard library. Specifically add new noexcept stuff to vector and string's move-assignment operations Mo

r245332 - Removing useless whitespace; NFC.

Author: aaronballman Date: Tue Aug 18 14:11:07 2015 New Revision: 245332 URL: http://llvm.org/viewvc/llvm-project?rev=245332&view=rev Log: Removing useless whitespace; NFC. Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h Modified: cfe/trunk/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D12110: [SemaExpr] Re-enable missing assertion

davide created this revision. davide added a reviewer: rsmith. davide added a subscriber: cfe-commits. This has been disabled for a long time, but: 1) Initializers work (and apparently they're re reason why this was disabled). 2) various tests happen to hit this code path and the invariant seems t

RE: Second Lit tests C++11 compatibility patch: using preprocessor to filter expected-error

Hi Justin and Richard, >> +// RUN: %clang_cc1 -E -C -P -triple x86_64-apple-darwin10 %s > %t1.c >> +// RUN: %clang_cc1 -fsyntax-only -verify -triple >> +x86_64-apple-darwin10 %t1.c > I think you forgot to switch this one to stop preprocessing first. Thank you for catching this. I have removed

[libcxx] r245333 - [libcxx] Disable -Wnon-virtual-dtor warning in

Author: ericwf Date: Tue Aug 18 14:39:35 2015 New Revision: 245333 URL: http://llvm.org/viewvc/llvm-project?rev=245333&view=rev Log: [libcxx] Disable -Wnon-virtual-dtor warning in Summary: Normally people won't see warnings in libc++ headers, but if they compile with "-Wsystem-headers -Wnon-vir

[libcxx] r245334 - [libc++] Fix PR22606 - Leak pthread_key with static storage duration to ensure all of thread-local destructors are called.

Author: ericwf Date: Tue Aug 18 14:40:38 2015 New Revision: 245334 URL: http://llvm.org/viewvc/llvm-project?rev=245334&view=rev Log: [libc++] Fix PR22606 - Leak pthread_key with static storage duration to ensure all of thread-local destructors are called. Summary: See https://llvm.org/bugs/show_

[libcxx] r245335 - [libcxx] Fix PR23589: std::function doesn't recognize null pointer to varargs function.

Author: ericwf Date: Tue Aug 18 14:41:51 2015 New Revision: 245335 URL: http://llvm.org/viewvc/llvm-project?rev=245335&view=rev Log: [libcxx] Fix PR23589: std::function doesn't recognize null pointer to varargs function. Summary: This patch fixes __not_null's detection of nullptr by breaking it

[libcxx] r245336 - Broke C++03 compatibility in 245330. Fix that.

Author: marshall Date: Tue Aug 18 14:51:37 2015 New Revision: 245336 URL: http://llvm.org/viewvc/llvm-project?rev=245336&view=rev Log: Broke C++03 compatibility in 245330. Fix that. Modified: libcxx/trunk/include/memory Modified: libcxx/trunk/include/memory URL: http://llvm.org/viewvc/llvm-

Re: [PATCH] D12110: [SemaExpr] Re-enable missing assertion

While at it, maybe the assertion can be modernized removing the != 0 part. On Tue, Aug 18, 2015 at 3:09 PM, Davide Italiano wrote: > davide created this revision. > davide added a reviewer: rsmith. > davide added a subscriber: cfe-commits. > > This has been disabled for a long time, but: > 1) Ini

Re: r244416 - [modules] PR22534: Load files specified by -fmodule-file= eagerly. In particular, this avoids the need to re-parse module map files when using such a module.

Sorry, I sent the original message to the wrong list. -- Forwarded message -- From: Gábor Horváth Date: 18 August 2015 at 12:59 Subject: Re: r244416 - [modules] PR22534: Load files specified by -fmodule-file= eagerly. In particular, this avoids the need to re-parse module map file

r245339 - Simplify Diagnostic's ctors a bit by using in-class initializers for its members

Author: dblaikie Date: Tue Aug 18 15:24:06 2015 New Revision: 245339 URL: http://llvm.org/viewvc/llvm-project?rev=245339&view=rev Log: Simplify Diagnostic's ctors a bit by using in-class initializers for its members Modified: cfe/trunk/include/clang/Basic/Diagnostic.h Modified: cfe/trunk/inc

[clang-tools-extra] r245340 - We no longer need a custom matcher for this; use the builtin AST matcher instead. NFC, and existing tests should cover this change.

Author: aaronballman Date: Tue Aug 18 15:27:44 2015 New Revision: 245340 URL: http://llvm.org/viewvc/llvm-project?rev=245340&view=rev Log: We no longer need a custom matcher for this; use the builtin AST matcher instead. NFC, and existing tests should cover this change. Modified: clang-tools

r245342 - Revert r245323, it caused PR24493.

Author: nico Date: Tue Aug 18 15:32:55 2015 New Revision: 245342 URL: http://llvm.org/viewvc/llvm-project?rev=245342&view=rev Log: Revert r245323, it caused PR24493. Modified: cfe/trunk/lib/AST/ExprConstant.cpp cfe/trunk/test/CodeGen/object-size.c cfe/trunk/test/Sema/const-eval.c Mod

[libcxx] r245343 - GC empty directory.

Author: joerg Date: Tue Aug 18 15:34:33 2015 New Revision: 245343 URL: http://llvm.org/viewvc/llvm-project?rev=245343&view=rev Log: GC empty directory. Removed: libcxx/trunk/src/support/newlib/ ___ cfe-commits mailing list cfe-commits@lists.llvm.or

r245344 - [sanitizer] Add -lutil to static runtime link flags.

Author: eugenis Date: Tue Aug 18 15:36:11 2015 New Revision: 245344 URL: http://llvm.org/viewvc/llvm-project?rev=245344&view=rev Log: [sanitizer] Add -lutil to static runtime link flags. This is needed to prevent breakage of -Wl,-as-needed link when interceptors for functions in libutil are added

r245346 - Initialize the AST consumer as soon as we have both an ASTConsumer and an

Author: rsmith Date: Tue Aug 18 15:39:29 2015 New Revision: 245346 URL: http://llvm.org/viewvc/llvm-project?rev=245346&view=rev Log: Initialize the AST consumer as soon as we have both an ASTConsumer and an ASTContext. Fixes some cases where we could previously initialize the AST consumer more tha

r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

Author: dblaikie Date: Tue Aug 18 15:54:26 2015 New Revision: 245352 URL: http://llvm.org/viewvc/llvm-project?rev=245352&view=rev Log: Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor. Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Se

Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

Richard, do you think there's anything we could do better here? It seems difficult to support proper move semantic behavior for [Sema]DiagnosticBuilder across the two common use cases: DiagnosticBuilder D; D << x; D << y; return D; and return DiagnosticBuilder() << x << y; The only t

[libcxx] r245354 - Move atomic_support.h and config_elast.h into src/include

Author: ericwf Date: Tue Aug 18 16:08:54 2015 New Revision: 245354 URL: http://llvm.org/viewvc/llvm-project?rev=245354&view=rev Log: Move atomic_support.h and config_elast.h into src/include Added: libcxx/trunk/src/include/ libcxx/trunk/src/include/atomic_support.h libcxx/trunk/src/in

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

- Original Message - > From: "Chris Bieneman via cfe-commits" > To: cfe-commits@lists.llvm.org > Sent: Tuesday, August 18, 2015 11:15:44 AM > Subject: r245304 - We shouldn't need to pass -fno-strict-aliasing when > building clang with clang. > > Author: cbieneman > Date: Tue Aug 18 11:15

r245359 - [autoconf] Fixing reversed logic introduced r245304.

Author: cbieneman Date: Tue Aug 18 16:23:44 2015 New Revision: 245359 URL: http://llvm.org/viewvc/llvm-project?rev=245359&view=rev Log: [autoconf] Fixing reversed logic introduced r245304. Thanks for the catch Hal! Modified: cfe/trunk/Makefile Modified: cfe/trunk/Makefile URL: http://llvm.

Re: r245304 - We shouldn't need to pass -fno-strict-aliasing when building clang with clang.

Wow! Thank you for catching that! Fixed in r245359. -Chris > On Aug 18, 2015, at 2:15 PM, Hal Finkel wrote: > > - Original Message - >> From: "Chris Bieneman via cfe-commits" >> To: cfe-commits@lists.llvm.org >> Sent: Tuesday, August 18, 2015 11:15:44 AM >> Subject: r245304 - We shoul

Re: [PATCH] D11046: [libcxx] Add Atomic test helper and fix TSAN failures.

EricWF updated this revision to Diff 32454. EricWF added a comment. Add more explanation to the wait tests. http://reviews.llvm.org/D11046 Files: test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp test/std/thread/thread.condition/thread.condition.condvarany/wait.exception.

[PATCH] D12117: Replace __asan_set_error_exit_code() with __sanitizer_set_death_callback()

samsonov created this revision. samsonov added a reviewer: EricWF. samsonov added a subscriber: cfe-commits. We are going to remove the former soon. http://reviews.llvm.org/D12117 Files: test/libcxx/containers/sequences/vector/asan.pass.cpp Index: test/libcxx/containers/sequences/vector/asan.

Re: r244416 - [modules] PR22534: Load files specified by -fmodule-file= eagerly. In particular, this avoids the need to re-parse module map files when using such a module.

On Tue, Aug 18, 2015 at 1:52 PM, Gábor Horváth wrote: > On 18 August 2015 at 13:41, Richard Smith wrote: > >> On Tue, Aug 18, 2015 at 12:59 PM, Gábor Horváth >> wrote: >> >>> Hi! >>> >>> In r244416 you made createModuleManager to call the Initialize method >>> of the ASTConsumer. >>> Because of

r245361 - Range-based-for-convert some loops in ASTWriter. No functionality change intended.

Author: rsmith Date: Tue Aug 18 16:53:42 2015 New Revision: 245361 URL: http://llvm.org/viewvc/llvm-project?rev=245361&view=rev Log: Range-based-for-convert some loops in ASTWriter. No functionality change intended. Modified: cfe/trunk/include/clang/Basic/Module.h cfe/trunk/lib/Serializa

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits > wrote: >> Author: rnk >> Date: Mon Aug 10 14:39:01 2015 >> New Revision: 244488 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=244488&view=rev >> Log: >> [dllimport] A non

Re: r244902 - Driver: Fix include directories when not using libgcc under mingw

Richard, I tried to ping you on the review thread but I'm not sure it got through. Martell requested this be merged to 3.7. What do you think? On Thu, Aug 13, 2015 at 8:41 AM, Martell Malone via cfe-commits wrote: > Author: martell > Date: Thu Aug 13 10:41:04 2015 > New Revision: 244902 > > URL:

Re: r244266 - [ItaniumCXXABI] Don't import RTTI data for classes with key functions

On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote: > > On Thu, Aug 6, 2015 at 1:56 PM, David Majnemer via cfe-commits > > wrote: > >> Author: majnemer > >> Date: Thu Aug 6 15:56:55 2015 > >

[PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp created this revision. ismailp added reviewers: zaks.anna, krememek. ismailp added a subscriber: cfe-commits. Name `Out` refers to the parameter. It is moved into the member `Out` in ctor-init. Dereferencing null pointer will crash clang, if user passes '-analyzer-viz-egraph-ubigraph' argu

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

Richard, I tried to ping you on the review thread but I'm not sure it got through. Martell requested this be merged to 3.7. What do you think? On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits wrote: > Author: martell > Date: Fri Aug 14 14:05:56 2015 > New Revision: 245084 > > URL:

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

ismailp added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749 @@ -748,3 +748,3 @@ assert (Src != Dst && "Self-edges are not allowed."); Is Ubigraph generator actively maintained? If I run tests with '-analyzer-viz-egraph-u

Re: r244416 - [modules] PR22534: Load files specified by -fmodule-file= eagerly. In particular, this avoids the need to re-parse module map files when using such a module.

On 18 August 2015 at 14:46, Richard Smith wrote: > On Tue, Aug 18, 2015 at 1:52 PM, Gábor Horváth > wrote: > >> On 18 August 2015 at 13:41, Richard Smith wrote: >> >>> On Tue, Aug 18, 2015 at 12:59 PM, Gábor Horváth >>> wrote: >>> Hi! In r244416 you made createModuleManager to c

r245367 - Wdeprecated: Support movability of EHScopeStack::Cleanup objects as they are move constructed in ConditionalCleanup::restore

Author: dblaikie Date: Tue Aug 18 17:09:28 2015 New Revision: 245367 URL: http://llvm.org/viewvc/llvm-project?rev=245367&view=rev Log: Wdeprecated: Support movability of EHScopeStack::Cleanup objects as they are move constructed in ConditionalCleanup::restore Modified: cfe/trunk/lib/CodeGen/

r245368 - Fix for MSVC

Author: dblaikie Date: Tue Aug 18 17:10:49 2015 New Revision: 245368 URL: http://llvm.org/viewvc/llvm-project?rev=245368&view=rev Log: Fix for MSVC Modified: cfe/trunk/lib/CodeGen/EHScopeStack.h Modified: cfe/trunk/lib/CodeGen/EHScopeStack.h URL: http://llvm.org/viewvc/llvm-project/cfe/trun

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

krememek added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:784 @@ -783,3 +783,3 @@ - *Out << "('vertex_style_attribute', 0, ('shape', 'icosahedron'))\n"; - *Out << "('vertex_style', 1, 0, ('shape', 'sphere'), ('color', '#ffcc66')," + *this->O

Re: [PATCH] D12119: Analyzer: Fix a crasher in UbigraphViz

krememek added inline comments. Comment at: lib/StaticAnalyzer/Frontend/AnalysisConsumer.cpp:749 @@ -748,3 +748,3 @@ assert (Src != Dst && "Self-edges are not allowed."); ismailp wrote: > Is Ubigraph generator actively maintained? If I run tests with > '-a

[PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

tra created this revision. tra added reviewers: eliben, echristo. tra added a subscriber: cfe-commits. The patch adds appropriate __host__ or __device__ attributes to target-specific builtins so we can properly check whether they may or may not be called from particular context. http://review

[PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

dcoughlin created this revision. dcoughlin added reviewers: zaks.anna, jordan_rose, xazax.hun. dcoughlin added a subscriber: cfe-commits. Herald added a subscriber: aemerson. In Objective-C, method calls with nil receivers are essentially no-ops. They do not fault (although the returned value may

r245378 - Devirtualize EHScopeStack::Cleanup's dtor because it's never destroyed polymorphically

Author: dblaikie Date: Tue Aug 18 17:40:54 2015 New Revision: 245378 URL: http://llvm.org/viewvc/llvm-project?rev=245378&view=rev Log: Devirtualize EHScopeStack::Cleanup's dtor because it's never destroyed polymorphically Modified: cfe/trunk/lib/CodeGen/CGBlocks.cpp cfe/trunk/lib/CodeGen

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

krememek added a subscriber: krememek. krememek added a comment. I think this is a great refinement overall, with a few minor nits. It also isn't clear what the test does. Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:577 @@ -559,1 +576,3 @@ + const std::ve

Re: r244266 - [ItaniumCXXABI] Don't import RTTI data for classes with key functions

On Tue, Aug 18, 2015 at 3:00 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 14, 2015 at 11:27 AM, Hans Wennborg via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Tue, Aug 11, 2015 at 1:41 PM, Hans Wennborg wrote: >> > On Thu, Aug 6, 2015 at 1:56

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

eliben added inline comments. Comment at: include/clang/Basic/Builtins.h:85 @@ +84,3 @@ + /// \brief Return true if this function is a target-specific builtin + bool isTSBuiltin(unsigned ID) const { +return ID >= Builtin::FirstTSBuiltin; You can also use it

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

I merged both of them and tweaked the test case to make it work. On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote: > On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: > > On Mon, Aug 10, 2015 at 12:39 PM, Reid Kleckner via cfe-commits > > wrote: > >> Author: rnk > >> Date: Mon Aug 10 1

Re: [PATCH] D11046: [libcxx] Add Atomic test helper and fix TSAN failures.

EricWF updated this revision to Diff 32473. EricWF added a comment. Fix more failing TSAN tests. http://reviews.llvm.org/D11046 Files: test/std/thread/thread.condition/notify_all_at_thread_exit.pass.cpp test/std/thread/thread.condition/thread.condition.condvar/notify_one.pass.cpp test/st

Re: r244488 - [dllimport] A non-imported class with an imported key can't have a key

Awesome, thanks! On Tue, Aug 18, 2015 at 4:27 PM, Reid Kleckner wrote: > I merged both of them and tweaked the test case to make it work. > > On Tue, Aug 18, 2015 at 2:55 PM, Hans Wennborg wrote: >> >> On Tue, Aug 11, 2015 at 9:40 AM, Hans Wennborg wrote: >> > On Mon, Aug 10, 2015 at 12:39 PM,

[libcxx] r245389 - [libcxx] Add Atomic test helper and fix TSAN failures.

Author: ericwf Date: Tue Aug 18 18:29:59 2015 New Revision: 245389 URL: http://llvm.org/viewvc/llvm-project?rev=245389&view=rev Log: [libcxx] Add Atomic test helper and fix TSAN failures. Summary: This patch attempts to fix the last 3 TSAN failures on the libc++ bot (http://lab.llvm.org:8011/bui

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

EricWF added a comment. Followup on @beanz comments. Comment at: src/CMakeLists.txt:123 @@ -124,1 +122,3 @@ + LIBRARY DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi + ARCHIVE DESTINATION lib${LIBCXXABI_LIBDIR_SUFFIX} COMPONENT libcxxabi ) bea

Re: [PATCH] D12123: [analyzer] Skip Pre/Post handlers for ObjC calls when receiver is nil.

xazax.hun added a comment. Looks good to me. There are some minor nits inline. Comment at: include/clang/StaticAnalyzer/Core/CheckerManager.h:96 @@ -95,1 +95,3 @@ +enum class ObjCCheckerKind { + PreVisit, I do not really like the name ObjCCheckerKind, because

r245390 - [modules] Fix HeaderFileInfo serialization to store all the known owning modules for a header, not just the current favourite.

Author: rsmith Date: Tue Aug 18 18:42:23 2015 New Revision: 245390 URL: http://llvm.org/viewvc/llvm-project?rev=245390&view=rev Log: [modules] Fix HeaderFileInfo serialization to store all the known owning modules for a header, not just the current favourite. Modified: cfe/trunk/include/clan

r245391 - [modules] Tests for r245390.

Author: rsmith Date: Tue Aug 18 18:42:50 2015 New Revision: 245391 URL: http://llvm.org/viewvc/llvm-project?rev=245391&view=rev Log: [modules] Tests for r245390. Added: cfe/trunk/test/Modules/Inputs/explicit-build-overlap/ cfe/trunk/test/Modules/Inputs/explicit-build-overlap/a.h cfe/t

Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote: > Richard, do you think there's anything we could do better here? > > It seems difficult to support proper move semantic behavior for > [Sema]DiagnosticBuilder across the two common use cases: > > DiagnosticBuilder D; > D << x; > D << y;

Re: [PATCH] D12110: [SemaExpr] Re-enable missing assertion

rsmith added a subscriber: rsmith. rsmith added a comment. LGTM http://reviews.llvm.org/D12110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

tra updated this revision to Diff 32478. tra marked an inline comment as done. tra added a comment. used isTSBuiltin in SemaChecking.cpp http://reviews.llvm.org/D12122 Files: include/clang/Basic/Builtins.h lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp test/SemaCUDA/builtins.cu test/

Re: r244902 - Driver: Fix include directories when not using libgcc under mingw

On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Richard, I tried to ping you on the review thread but I'm not sure it > got through. Martell requested this be merged to 3.7. What do you > think? Sure, this looks fine for branch. > On Thu, A

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

beanz added a comment. The signature is: install(TARGETS targets... [EXPORT ] [[ARCHIVE|LIBRARY|RUNTIME|FRAMEWORK|BUNDLE| PRIVATE_HEADER|PUBLIC_HEADER|RESOURCE] [DESTINATION ] [INCLUDES DESTINATION [ ...]] [PERMISSIONS permissions...]

r245392 - unique_ptrify CXXBasePaths::DeclsFound & remove the then-unnecessary user-defined dtor

Author: dblaikie Date: Tue Aug 18 18:56:00 2015 New Revision: 245392 URL: http://llvm.org/viewvc/llvm-project?rev=245392&view=rev Log: unique_ptrify CXXBasePaths::DeclsFound & remove the then-unnecessary user-defined dtor Maybe this and the NumDeclsFound member should just be a std::vector inste

[PATCH] D12128: Generating available_externally vtables bugfix

Prazek created this revision. Prazek added reviewers: rsmith, majnemer, rjmccall. Prazek added a subscriber: cfe-commits. Bugfix revealed in r245264. http://reviews.llvm.org/D12128 Files: include/clang/AST/VTableBuilder.h lib/CodeGen/ItaniumCXXABI.cpp Index: lib/CodeGen/ItaniumCXXABI.cpp ==

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

tra updated this revision to Diff 32481. tra added a comment. Added a comment explaining reasoning behind attribute choice for target-specific builtins. http://reviews.llvm.org/D12122 Files: include/clang/Basic/Builtins.h lib/Sema/SemaChecking.cpp lib/Sema/SemaDecl.cpp test/SemaCUDA/bu

Re: [PATCH] D12122: [CUDA] Add appropriate host/device attribute to target-specific builtins.

tra marked an inline comment as done. Comment at: lib/Sema/SemaDecl.cpp:11166 @@ +11165,3 @@ +!FD->hasAttr() && !FD->hasAttr()) { + if (getLangOpts().CUDAIsDevice) +FD->addAttr(CUDADeviceAttr::CreateImplicit(Context, FD->getLocation())); elib

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

EricWF added a comment. What about the extra `[` at the beginning of `ARCHIVE` that spans all the way down to the last line. It seems to me that `DESTINATION` can be supplied for each library type. There is also an example in the docs that shows using two library types in one install command.

Re: r244902 - Driver: Fix include directories when not using libgcc under mingw

On Tue, Aug 18, 2015 at 4:52 PM, Richard Smith wrote: > On Tue, Aug 18, 2015 at 3:00 PM, Hans Wennborg via cfe-commits > wrote: >> >> Richard, I tried to ping you on the review thread but I'm not sure it >> got through. Martell requested this be merged to 3.7. What do you >> think? > > > Sure, th

Re: [PATCH] D11682: [libcxxabi] Add "install-libcxxabi" target.

EricWF added a comment. @beanz I tested installing both libc++abi.so and libc++abi.a at the same time with different destinations. They both installed into the correct destinations. http://reviews.llvm.org/D11682 ___ cfe-commits mailing list cfe-co

Re: [PATCH] D12128: Generating available_externally vtables bugfix

rsmith added a comment. This looks fine; can you add a testcase? http://reviews.llvm.org/D12128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D12129: [libcxx] Add new Sphinx documentation

EricWF created this revision. EricWF added reviewers: jroelofs, chandlerc, danalbert, mclow.lists. EricWF added a subscriber: cfe-commits. This patch adds Sphinx based documentation to libc++. The goal is to make it easier to write documentation for libc++ since writing new documentation in HTML

Re: r245084 - WindowsX86: long double is x87DoubleExtended on mingw

On Tue, Aug 18, 2015 at 3:01 PM, Hans Wennborg wrote: > Richard, I tried to ping you on the review thread but I'm not sure it > got through. Martell requested this be merged to 3.7. What do you > think? LGTM > On Fri, Aug 14, 2015 at 12:05 PM, Martell Malone via cfe-commits > wrote: > > Auth

Re: [PATCH] D12002: Initial WebAssembly support in clang

sunfish updated this revision to Diff 32485. sunfish marked an inline comment as done. sunfish added a comment. The patch evolved enough to prompt posting one more new version; major changes: - make constructors and destructors return this - enable -fuse-init-array - enable -fno-common - disable

Re: [PATCH] D11194: Instantiate function declarations in instantiated functions.

On Tue, Aug 18, 2015 at 10:05 AM, Serge Pavlov wrote: > sepavloff added inline comments. > > > Comment at: lib/AST/DeclBase.cpp:273 > @@ +272,3 @@ > +return true; > + if (const CXXRecordDecl *ClassD = dyn_cast(LDC)) > +return ClassD->isLocalClass() && !ClassD->isLambda()

[PATCH] D12131: Make [Sema]DiagnosticBuilder move-only, instead of having a sneaky mutating copy ctor.

dblaikie created this revision. dblaikie added a reviewer: rsmith. dblaikie added a subscriber: cfe-commits. While there wasn't much use of "return Diag(...) << x" outside Sema (one each in ARCMigrate, Lex, Parse, and 5 in ClangTidy - which were all just changed to use named local variables, then

Re: r245352 - Workaround -Wdeprecated on SemDiagnosticConsumer's tricksy copy ctor.

On Tue, Aug 18, 2015 at 4:46 PM, Richard Smith wrote: > On Tue, Aug 18, 2015 at 2:03 PM, David Blaikie wrote: > >> Richard, do you think there's anything we could do better here? >> >> It seems difficult to support proper move semantic behavior for >> [Sema]DiagnosticBuilder across the two commo

  1   2   >