alexfh added a comment. In http://reviews.llvm.org/D12076#226476, @angelgarcia wrote:
> Split the tests in several files. Thank you! Seems better like this. A few more comments. ================ Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:293 @@ +292,3 @@ + return nullptr; + const std::string Name = Member->getMemberDecl()->getName(); + const std::string TargetName = IsBegin ? "begin" : "end"; ---------------- s/const std::string/StringRef/ ================ Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:294 @@ +293,3 @@ + const std::string Name = Member->getMemberDecl()->getName(); + const std::string TargetName = IsBegin ? "begin" : "end"; + if (Name != TargetName) ---------------- ditto ================ Comment at: clang-tidy/modernize/LoopConvertCheck.cpp:448 @@ +447,3 @@ + + std::string MaybeDereference = ContainerNeedsDereference ? "*" : ""; + std::string TypeString = AutoRefType.getAsString(); ---------------- s/std::string/StringRef/ ================ Comment at: test/clang-tidy/modernize-loop-convert-basic.cpp:4 @@ +3,3 @@ + +#include "Inputs/modernize-loop-convert-structures.h" + ---------------- Relative paths to included files may not work in all test setups. Please move the header to a subdirectory (modernize-loop-convert) inside Inputs (you can also rename it to just structures.h) and specify the directory in the RUN: line using `-I %S/Inputs/modernize-loop-convert`. That will ensure an absolute path to the directory is used. The #include directive should then refer the file without path. http://reviews.llvm.org/D12076 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
