[PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

filcab created this revision. filcab added reviewers: rsmith, ABataev, rjmccall. filcab added a subscriber: cfe-commits. float_cast_overflow is the only UBSan check without a source location attached. This patch propagates SourceLocations where necessary to get them to the EmitCheck() call. http:

Re: [PATCH] D11738: Add new llvm.loop.unroll.enable metadata which is now generated by "#pragma unroll" directive

tyler.nowicki added a subscriber: tyler.nowicki. tyler.nowicki added a comment. Hi Mark, The patch LGTM! Tyler http://reviews.llvm.org/D11738 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

r244025 - [Comments] Replace custom ArrayRef copying with ArrayRef::copy. NFC.

Author: d0k Date: Wed Aug 5 04:40:04 2015 New Revision: 244025 URL: http://llvm.org/viewvc/llvm-project?rev=244025&view=rev Log: [Comments] Replace custom ArrayRef copying with ArrayRef::copy. NFC. Modified: cfe/trunk/include/clang/AST/CommentSema.h Modified: cfe/trunk/include/clang/AST/Com

r244026 - [AST] ArrayRefize template argument packs. No functionality change intended.

Author: d0k Date: Wed Aug 5 04:40:22 2015 New Revision: 244026 URL: http://llvm.org/viewvc/llvm-project?rev=244026&view=rev Log: [AST] ArrayRefize template argument packs. No functionality change intended. Modified: cfe/trunk/include/clang/AST/TemplateBase.h cfe/trunk/lib/AST/ASTContext.

r244024 - [Parse] ArrayRefize PragmaLoopHintInfo. No functionality change.

Author: d0k Date: Wed Aug 5 04:39:57 2015 New Revision: 244024 URL: http://llvm.org/viewvc/llvm-project?rev=244024&view=rev Log: [Parse] ArrayRefize PragmaLoopHintInfo. No functionality change. Modified: cfe/trunk/lib/Parse/ParsePragma.cpp Modified: cfe/trunk/lib/Parse/ParsePragma.cpp URL:

r244027 - [AST] ArrayRefize BlockDecl::setCaptures. No functionality change intended.

Author: d0k Date: Wed Aug 5 04:40:35 2015 New Revision: 244027 URL: http://llvm.org/viewvc/llvm-project?rev=244027&view=rev Log: [AST] ArrayRefize BlockDecl::setCaptures. No functionality change intended. Modified: cfe/trunk/include/clang/AST/Decl.h cfe/trunk/lib/AST/Decl.cpp cfe/tru

r244028 - [AST] ArrayRefize template param list info setters. No functionality change intended.

Author: d0k Date: Wed Aug 5 04:40:49 2015 New Revision: 244028 URL: http://llvm.org/viewvc/llvm-project?rev=244028&view=rev Log: [AST] ArrayRefize template param list info setters. No functionality change intended. Modified: cfe/trunk/include/clang/AST/Decl.h cfe/trunk/lib/AST/Decl.cpp

Re: [PATCH] D11476: Marked call instruction in thunk function with tail attribute when applicable

aaboud retitled this revision from "Marked call instruction in thunk function with musttail attribute when applicable" to "Marked call instruction in thunk function with tail attribute when applicable". aaboud updated the summary for this revision. aaboud updated this revision to Diff 31341. Rep

r244036 - Add AST matchers for narrowing constructors that are default, copy, or move constructors, as well as functionality to determine whether a ctor initializer is a base initializer.

Author: aaronballman Date: Wed Aug 5 07:11:30 2015 New Revision: 244036 URL: http://llvm.org/viewvc/llvm-project?rev=244036&view=rev Log: Add AST matchers for narrowing constructors that are default, copy, or move constructors, as well as functionality to determine whether a ctor initializer is

Re: [PATCH] AST matchers for constructors

Thank you for correcting what my contacts list hadn't picked up on yet. ;-) I've committed in r244036. ~Aaron On Wed, Aug 5, 2015 at 8:04 AM, Manuel Klimek wrote: > > > On Wed, Aug 5, 2015 at 2:02 PM Manuel Klimek wrote: >> >> LG >> >> On Wed, Aug 5, 2015 at 1:54 PM Aaron Ballman >> wrote: >>>

[PATCH] D11761: [PATCH] clang-query quit command

aaron.ballman created this revision. aaron.ballman added reviewers: klimek, alexfh. aaron.ballman added a subscriber: cfe-commits. I would like to propose adding a clang-query command called 'quit' that terminates the clang-query interactive session. While Ctrl+C works well enough to terminate t

Re: [PATCH] D11761: [PATCH] clang-query quit command

klimek added a reviewer: pcc. klimek added a comment. +pcc for the opinion of the creator :) http://reviews.llvm.org/D11761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11761: [PATCH] clang-query quit command

klimek added a comment. For what it's worth, I think this looks good, mainly curious whether pcc has any remarks code-wise. http://reviews.llvm.org/D11761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

Re: [PATCH] Fix crash in CheckObjCCircularContainer

Hi guys, any updates? -- AlexDenisov Software Engineer, http://lowlevelbits.org > On 31 Jul 2015, at 22:55, AlexDenisov <1101.deb...@gmail.com> wrote: > >> To clarify, are you saying that the warning may lead to false positives when >> used in subclasses ? > > Seems I was wrong. > Just checked

Re: [PATCH][Solaris] Clang/Driver, stop hardcoding GCC paths in crt/ld.so lookup

Please git-clang-format this patch. + // /usr/gcc/./lib/gcc/../, The code appends a triple after the "/lib/gcc". Is the comment missing it? The inner loop has no version comparison. Are you depending on the directory iteration order? Can you add a testcase? On 28 July 2015 at 12:35, Xan López

Re: [PATCH] D11582: Fix assertion failure in TransformOpaqueValueExpr

rcraik added a comment. ping! http://reviews.llvm.org/D11582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D10933: Add new IdentifierNaming check

alexfh added a comment. Some initial comments, mostly style-related. It takes some time to get used to the coding style used in LLVM/Clang. One notable thing: though we use `auto` sometimes, we don't use the almost-always-auto style. Please see the inline comments for specific cases.

Re: [PATCH] D10933: Add new IdentifierNaming check

berenm added a comment. Thanks for the review, I will fix the various style issues and come back with an updated version. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:87 @@ +86,3 @@ + auto const fromString = [](StringRef Str) { +if (Str.equals("any") || Str

[libcxx] r244047 - Update some links so that they don't point at the (private) WG21 Wiki

Author: marshall Date: Wed Aug 5 09:36:42 2015 New Revision: 244047 URL: http://llvm.org/viewvc/llvm-project?rev=244047&view=rev Log: Update some links so that they don't point at the (private) WG21 Wiki Modified: libcxx/trunk/www/ts1z_status.html Modified: libcxx/trunk/www/ts1z_status.html

r244049 - Officially end my reign as owner of the driver.

Author: mcrosier Date: Wed Aug 5 09:52:01 2015 New Revision: 244049 URL: http://llvm.org/viewvc/llvm-project?rev=244049&view=rev Log: Officially end my reign as owner of the driver. Modified: cfe/trunk/CODE_OWNERS.TXT Modified: cfe/trunk/CODE_OWNERS.TXT URL: http://llvm.org/viewvc/llvm-pro

Re: r244049 - Officially end my reign as owner of the driver.

On Wed, Aug 5, 2015 at 10:52 AM, Chad Rosier wrote: > Author: mcrosier > Date: Wed Aug 5 09:52:01 2015 > New Revision: 244049 > > URL: http://llvm.org/viewvc/llvm-project?rev=244049&view=rev > Log: > Officially end my reign as owner of the driver. Thank you for all your work with it! ~Aaron >

r244051 - Delete trailing whitespace

Author: dougk Date: Wed Aug 5 10:08:53 2015 New Revision: 244051 URL: http://llvm.org/viewvc/llvm-project?rev=244051&view=rev Log: Delete trailing whitespace Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp URL: http://llvm.org

r244052 - [SHAVE] uppercase the CHECK prefixes in 'lit' tests. NFC

Author: dougk Date: Wed Aug 5 10:08:54 2015 New Revision: 244052 URL: http://llvm.org/viewvc/llvm-project?rev=244052&view=rev Log: [SHAVE] uppercase the CHECK prefixes in 'lit' tests. NFC Modified: cfe/trunk/test/Driver/shave-toolchain.c Modified: cfe/trunk/test/Driver/shave-toolchain.c URL

RE: r244049 - Officially end my reign as owner of the driver.

Thanks, Aaron. I'm fairly proud of the crash diagnostics and script generation. Sadly, there's still much, much more to be done. -Original Message- From: aaron.ball...@gmail.com [mailto:aaron.ball...@gmail.com] On Behalf Of Aaron Ballman Sent: Wednesday, August 05, 2015 10:53 AM To: Ch

Re: [PATCH] D10933: Add new IdentifierNaming check

alexfh added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:87 @@ +86,3 @@ + auto const fromString = [](StringRef Str) { +if (Str.equals("any") || Str.equals("aNy_CasE")) + return AnyCase; berenm wrote: > alexfh wrote: > >

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

benlangmuir updated this revision to Diff 31354. benlangmuir added a comment. Sorry for the slow response, I somehow missed your original comment. Add a more cohesive comment. I don't think we can usefully specify the SDK range it affects until a fixed SDK is available (currently it's every SDK

[PATCH] D11765: [sanitizer] Enable tsan for aarch64

zatrazz created this revision. zatrazz added reviewers: rengolin, t.p.northover, aemerson, pcc. zatrazz added a subscriber: cfe-commits. Herald added subscribers: rengolin, aemerson. This patch enables the -fsanitizer=thread option for Linux/aarch64. http://reviews.llvm.org/D11765 Files: lib/D

Re: [PATCH] D11742: Add -gcodeview and -gdwarf to control which type Clang emits

rnk marked 2 inline comments as done. Comment at: test/CodeGen/dwarf-version.c:11 @@ -7,3 +10,3 @@ // RUN: %clang -target powerpc-unknown-freebsd -g -S -emit-llvm -o - %s | FileCheck %s --check-prefix=VER2 // RUN: %clang -target i386-pc-solaris -g -S -emit-llvm -o - %s | FileCh

Re: [PATCH] D11476: Marked call instruction in thunk function with tail attribute when applicable

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. The patch seems right, but I'm surprised there isn't more test fallout. Repository: rL LLVM http://reviews.llvm.org/D11476 ___ cfe-commits mailing l

Re: [PATCH] D11743: [CMake] First pass at adding support for clang bootstrap builds to CMake

beanz updated this revision to Diff 31359. beanz added a comment. - Fixed a dependency tracking issue with figuring out when to clear out the bootstrap build - Removed 'bootstrap-install' from the 'bootstrap' target - Added 'bootstrap-check' and 'bootstrap-check-all' targets http://reviews.llvm

Re: [PATCH] D11360: Proposed patch to prevent the creation of empty (forwarding) blocks resulting from nested ifs.

wolfgangp added a comment. Ping... http://reviews.llvm.org/D11360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r244049 - Officially end my reign as owner of the driver.

Thanks for all your work on it, Chad. > On Aug 5, 2015, at 7:52 AM, Chad Rosier wrote: > > Author: mcrosier > Date: Wed Aug 5 09:52:01 2015 > New Revision: 244049 > > URL: http://llvm.org/viewvc/llvm-project?rev=244049&view=rev > Log: > Officially end my reign as owner of the driver. > > Mo

RE: r244049 - Officially end my reign as owner of the driver.

Thanks, Ted!! -Original Message- From: Ted kremenek [mailto:kreme...@apple.com] Sent: Wednesday, August 05, 2015 12:40 PM To: Chad Rosier Cc: cfe-commits@lists.llvm.org Subject: Re: r244049 - Officially end my reign as owner of the driver. Thanks for all your work on it, Chad. > On Au

Re: [PATCH] D10933: Add new IdentifierNaming check

berenm added inline comments. Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:178 @@ +177,3 @@ +if (NamingStyles[Typedef].isSet()) { + KindName = "typedef"; + Style = NamingStyles[Typedef]; alexfh wrote: > berenm wrote: > > alexfh wrote:

r244063 - Add missing atomic libcall support.

Author: jyknight Date: Wed Aug 5 11:57:36 2015 New Revision: 244063 URL: http://llvm.org/viewvc/llvm-project?rev=244063&view=rev Log: Add missing atomic libcall support. Support for emitting libcalls for __atomic_fetch_nand and __atomic_{add,sub,and,or,xor,nand}_fetch was missing; add it, and so

Re: [PATCH] D11743: [CMake] First pass at adding support for clang bootstrap builds to CMake

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Totally awesome man, ship it. I've left a nit-pick below, but this is definitely the right starting place. Comment at: CMakeLists.txt:615 @@ +614,3 @@ + + set(ADDITION

Re: [PATCH] D11298: Convert a few classes over to use the new TrailingObjects helper.

jyknight marked an inline comment as done. Comment at: include/clang/AST/Decl.h:3620 @@ +3619,3 @@ + public DeclContext, + llvm::TrailingObjects { +protected: rsmith wrote: > I would prefer to see an explicit `private` access specifier here. Done here an

r244065 - Fix a tiny bug in -no-canonical-prefixes that somehow we have never

Author: chandlerc Date: Wed Aug 5 12:07:33 2015 New Revision: 244065 URL: http://llvm.org/viewvc/llvm-project?rev=244065&view=rev Log: Fix a tiny bug in -no-canonical-prefixes that somehow we have never noticed until now. The code for setting up the driver's InstalledDir didn't respect -no-canon

r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

Author: akirtzidis Date: Wed Aug 5 12:23:59 2015 New Revision: 244066 URL: http://llvm.org/viewvc/llvm-project?rev=244066&view=rev Log: [test/Index] Update libclang tests to use libclang for creating PCH files. This is consistent and tests the primary configuration we want to test, libclang crea

Re: [PATCH] D11766: "Claim" the arguments belonging to 'clang_ignored_gcc_optimization_f_Group'

mcrosier added a subscriber: mcrosier. mcrosier accepted this revision. mcrosier added a reviewer: mcrosier. mcrosier added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D11766 ___ cfe-commits mailing list

r244070 - [CMake] First pass at adding support for clang bootstrap builds to CMake

Author: cbieneman Date: Wed Aug 5 12:38:12 2015 New Revision: 244070 URL: http://llvm.org/viewvc/llvm-project?rev=244070&view=rev Log: [CMake] First pass at adding support for clang bootstrap builds to CMake Summary: This patch adds a new CLANG_ENABLE_BOOTSTRAP option to CMake which adds targets

Re: [PATCH] D11743: [CMake] First pass at adding support for clang bootstrap builds to CMake

This revision was automatically updated to reflect the committed changes. Closed by commit rL244070: [CMake] First pass at adding support for clang bootstrap builds to CMake (authored by cbieneman). Changed prior to commit: http://reviews.llvm.org/D11743?vs=31359&id=31371#toc Repository: rL

r244076 - [test] Attempt a change to see if it fixes the test for the windows bot.

Author: akirtzidis Date: Wed Aug 5 12:52:57 2015 New Revision: 244076 URL: http://llvm.org/viewvc/llvm-project?rev=244076&view=rev Log: [test] Attempt a change to see if it fixes the test for the windows bot. Modified: cfe/trunk/test/Index/TestClassForwardDecl.m Modified: cfe/trunk/test/Ind

Re: [PATCH] D2916: Add test for Python binding Index read.

modocache updated this revision to Diff 31376. modocache added a comment. Rebase onto master. http://reviews.llvm.org/D2916 Files: bindings/python/tests/cindex/test_index.py bindings/python/tests/cindex/test_translation_unit.py bindings/python/tests/cindex/util.py Index: bindings/python/

Re: [PATCH] D11740: ABI versioning macros for libc++

eugenis added a comment. I'm trying to follow this proposal (which people seem to agree with in the general): http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-December/040587.html Renaming _LIBCPP_ALTERNATE_STRING_LAYOUT is to give a unified naming scheme for all ABI-changing features, as propos

r244079 - Claim arguments that belong to 'clang_ignored_gcc_optimization_f_Group'

Author: dougk Date: Wed Aug 5 13:03:47 2015 New Revision: 244079 URL: http://llvm.org/viewvc/llvm-project?rev=244079&view=rev Log: Claim arguments that belong to 'clang_ignored_gcc_optimization_f_Group' This seems preferable to printing two warnings per unsupported option- one warning about not

Re: [PATCH] D11742: Add -gcodeview and -gdwarf to control which type Clang emits

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm http://reviews.llvm.org/D11742 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

Re: [PATCH] D11753: [X86] Add support for _MM_ALIGN16

echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. Couple of inline comments, otherwise LGTM. -eric Comment at: test/CodeGen/ms-mm-align.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility

Re: r243964 - [OPENMP] Fix compiler crash during data-sharing attributes analysis.

Sorry for the delay. Merged in r244090. Cheers, Hans On Tue, Aug 4, 2015 at 3:05 AM, Bataev, Alexey wrote: > Hans, > This patch fixes crash in clang. Could you backport it to 3.7 branch? > > Best regards, > Alexey Bataev > = > Software Engineer > Intel Compiler Team > > > 04.08.2015

r244091 - [AArch64] Enable thread sanitizer on clang

Author: rengolin Date: Wed Aug 5 13:42:41 2015 New Revision: 244091 URL: http://llvm.org/viewvc/llvm-project?rev=244091&view=rev Log: [AArch64] Enable thread sanitizer on clang With this option, clang can use -fsanitize=thread on AArch64. Patch by Adhemerval Zanella. Modified: cfe/trunk/li

Re: [PATCH] D11765: [sanitizer] Enable tsan for aarch64

rengolin accepted this revision. rengolin added a comment. This revision is now accepted and ready to land. This patch is necessary for the RT tests to compile on AArch64. http://reviews.llvm.org/D11765 ___ cfe-commits mailing list cfe-commits@lists

Re: [PATCH] D11765: [sanitizer] Enable tsan for aarch64

rengolin closed this revision. rengolin added a comment. r244091 http://reviews.llvm.org/D11765 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r244097 - Add -gcodeview and -gdwarf to control which type Clang emits

Author: rnk Date: Wed Aug 5 13:51:13 2015 New Revision: 244097 URL: http://llvm.org/viewvc/llvm-project?rev=244097&view=rev Log: Add -gcodeview and -gdwarf to control which type Clang emits Summary: By default, 'clang' emits dwarf and 'clang-cl' emits codeview. You can force emission of one or

Re: r243945 - [UB] Fix two cases of UB in copy/pasted code from SmallVector.

Richard, Chandler asked me about merging this and the other memcpy-ub patches to 3.7. I'd like to hear what you think. On the one hand, this doesn't fix a regression from previous releases and the issue it addresses is probably fairly benign at the moment. On the other hand, the patches do fix und

Re: [PATCH] D11761: [PATCH] clang-query quit command

pcc added a comment. I normally quit clang-query, or pretty much any other interactive command line program, by typing end-of-file (Ctrl-D on Unix, Ctrl-Z on Windows). If this works on Windows 10 I'd rather users do it that way. We can make this more discoverable through documentation. http:

Re: [PATCH] D11753: [X86] Add support for _MM_ALIGN16

mkuper added a comment. Thanks, Eric! Comment at: test/CodeGen/ms-mm-align.c:1 @@ +1,2 @@ +// RUN: %clang_cc1 -ffreestanding -fms-extensions -fms-compatibility -fms-compatibility-version=17.00 \ +// RUN: -triple i686--windows -Oz -emit-llvm %s -o - \ ec

Re: [PATCH] D11761: [PATCH] clang-query quit command

aaron.ballman added a comment. In http://reviews.llvm.org/D11761#218141, @pcc wrote: > I normally quit clang-query, or pretty much any other interactive command > line program, by typing end-of-file (Ctrl-D on Unix, Ctrl-Z on > Windows). If this works on Windows 10 I'd rather users do it that

Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

samsonov added a comment. Thank you for working on this! This change looks good to me, but I'll let Richard say a final word. Note that you would need to make a corresponding change in UBSan compiler-rt runtime. Also, this is an ABI-breaking change - e.g. shared objects built with older Clang

r244104 - Documentation: fix a typo, "This flag is determines" -> "This flag determines".

Author: jdennett Date: Wed Aug 5 14:44:47 2015 New Revision: 244104 URL: http://llvm.org/viewvc/llvm-project?rev=244104&view=rev Log: Documentation: fix a typo, "This flag is determines" -> "This flag determines". No functional change. Modified: cfe/trunk/include/clang/AST/PrettyPrinter.h

Re: [PATCH] D11761: [PATCH] clang-query quit command

klimek added a comment. Peter, any particular reason? In http://reviews.llvm.org/D11761#218151, @aaron.ballman wrote: > In http://reviews.llvm.org/D11761#218141, @pcc wrote: > > > I normally quit clang-query, or pretty much any other interactive command > > line program, by typing end-of-file (

r244110 - Remove unnecessary ClangLibdirSuffix variable.

Author: yrnkrn Date: Wed Aug 5 15:06:56 2015 New Revision: 244110 URL: http://llvm.org/viewvc/llvm-project?rev=244110&view=rev Log: Remove unnecessary ClangLibdirSuffix variable. Twine + const char * is supported. Modified: cfe/trunk/lib/Frontend/CompilerInvocation.cpp Modified: cfe/trunk

Re: [PATCH] Fix crash in CheckObjCCircularContainer

> Why not get the IdentifierInfo pointer for the class name from the NSAPI > object and compare that ? There are more than one way to do things, it’s just lack of knowledge about the code base. > Also there is code duplication, since the same code pattern is used in 3 > places, could you refact

r244111 - Remove unused comparison operators from the Builtin Info struct.

Author: echristo Date: Wed Aug 5 15:11:04 2015 New Revision: 244111 URL: http://llvm.org/viewvc/llvm-project?rev=244111&view=rev Log: Remove unused comparison operators from the Builtin Info struct. Modified: cfe/trunk/include/clang/Basic/Builtins.h Modified: cfe/trunk/include/clang/Basic/B

Re: r243085 - Fix the cc1as crash when it outputs assembly

Ping? On Thu, Jul 30, 2015 at 10:20 AM, Hans Wennborg wrote: > Rafael: ping? > > This is probably not terribly important, but I would like to get it off my > list. > > On Wed, Jul 29, 2015 at 10:16 AM, Hans Wennborg wrote: >> Ping? >> >> On Mon, Jul 27, 2015 at 1:29 PM, Hans Wennborg wrote: >>

Re: [PATCH] Fix crash in CheckObjCCircularContainer

> +IdentifierInfo *II = &S.Context.Idents.get(InterfaceDecl->getName()); You can just do “InterfaceDecl->getIdentifier()”, no need to lookup by string. Also this will eliminate the need to pass Sema as parameter. And ‘isSubclassOfNSClass()’ seems generally useful, how about you make it a fu

Re: r243085 - Fix the cc1as crash when it outputs assembly

Thanks! r244116. - Hans On Wed, Aug 5, 2015 at 1:23 PM, Rafael Espíndola wrote: > It is probably very safe, so fine by me. > > On 5 August 2015 at 16:19, Hans Wennborg wrote: >> Ping? >> >> On Thu, Jul 30, 2015 at 10:20 AM, Hans Wennborg wrote: >>> Rafael: ping? >>> >>> This is probably not t

r244119 - [CMake] Add USES_TERMINAL 1 to ExternalProject_Add_Step calls on 3.3.20150708 and later.

Author: cbieneman Date: Wed Aug 5 15:46:39 2015 New Revision: 244119 URL: http://llvm.org/viewvc/llvm-project?rev=244119&view=rev Log: [CMake] Add USES_TERMINAL 1 to ExternalProject_Add_Step calls on 3.3.20150708 and later. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.

Re: [Patch][LoopVectorize]Late evaluation of vectorization requirements

Hi, Could I get a review of these patches? Thanks, Tyler > On Jul 27, 2015, at 4:45 PM, Tyler Nowicki wrote: > > Please ignore the debug line in the LLVM late-evaluation patch. It won’t be > part of the commit. > > + DEBUG(dbgs() << "LV: Emitting analysis message.\n”); > > Tyler > >

r244124 - Documentation: fix another typo, "arrays types" -> "array types".

Author: jdennett Date: Wed Aug 5 15:58:23 2015 New Revision: 244124 URL: http://llvm.org/viewvc/llvm-project?rev=244124&view=rev Log: Documentation: fix another typo, "arrays types" -> "array types". Thanks to Kim Gräsman for pointing this out. Modified: cfe/trunk/include/clang/AST/PrettyP

Re: Add flags to disable profile generation.

Diego Novillo writes: > This patch adds flags -fno-profile-instr-generate and > -fno-profile-instr-use, and the GCC aliases -fno-profile-generate and > -fno-profile-use. > > These flags are used in situations where users need to disable profile > generation or use for specific files in a build, wi

r244125 - Remove unused function GetBuiltinNames.

Author: echristo Date: Wed Aug 5 16:04:24 2015 New Revision: 244125 URL: http://llvm.org/viewvc/llvm-project?rev=244125&view=rev Log: Remove unused function GetBuiltinNames. Modified: cfe/trunk/include/clang/Basic/Builtins.h cfe/trunk/lib/Basic/Builtins.cpp Modified: cfe/trunk/include/c

r244126 - Rename builtin_lang -> Langs to match the rest of the code a bit better.

Author: echristo Date: Wed Aug 5 16:04:28 2015 New Revision: 244126 URL: http://llvm.org/viewvc/llvm-project?rev=244126&view=rev Log: Rename builtin_lang -> Langs to match the rest of the code a bit better. Modified: cfe/trunk/include/clang/Basic/Builtins.h cfe/trunk/lib/Basic/Builtins.c

Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

filcab added a comment. In http://reviews.llvm.org/D11757#218153, @samsonov wrote: > Note that you would need to make a corresponding change in UBSan compiler-rt > runtime. I finished this late last night, so I figured I'd upload the bigger patch and start getting comments. :-) > Also, this

Re: [PATCH] D11298: Convert a few classes over to use the new TrailingObjects helper.

rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks like a really nice cleanup, thanks! Comment at: include/clang/AST/DeclTemplate.h:47-49 @@ -45,3 +46,5 @@ /// derived classes. -class LLVM_ALIGNAS(/*alignof(void*)*/ LLV

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

rsmith added inline comments. Comment at: include/clang/Basic/Module.h:203-211 @@ -202,1 +202,11 @@ + /// \brief Whether this module uses the 'requires excluded' hack to mark its + /// contents as 'textual'. + /// + /// On older Darwin SDK versions, 'requires excluded' is us

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

benlangmuir added inline comments. Comment at: include/clang/Basic/Module.h:203-211 @@ -202,1 +202,11 @@ + /// \brief Whether this module uses the 'requires excluded' hack to mark its + /// contents as 'textual'. + /// + /// On older Darwin SDK versions, 'requires excluded'

Re: [PATCH] D11757: Propagate SourceLocations through to get a Loc on float_cast_overflow

rsmith added a comment. Looks good to me too (though please hold off on this until you and samsonov have agreed on what to do about the ubsan ABI change). Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:1288 @@ -1287,3 +1287,3 @@ OpenMPDirectiveKind Kind, -

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

rsmith added inline comments. Comment at: lib/Lex/ModuleMap.cpp:1891-1908 @@ +1890,20 @@ + + if (ActiveModule->UsesRequiresExcludedHack) { +// Mark this header 'textual' (see doc comment for +// Module::UsesRequiresExcludedHack). Although iterating over the directory +

Re: Add flags to disable profile generation.

On Wed, Aug 5, 2015 at 4:04 PM, Justin Bogner wrote: > Diego Novillo writes: > > This patch adds flags -fno-profile-instr-generate and > > -fno-profile-instr-use, and the GCC aliases -fno-profile-generate and > > -fno-profile-use. > > > > These flags are used in situations where users need to di

r244153 - Add flags to disable profile generation.

Author: dnovillo Date: Wed Aug 5 16:49:51 2015 New Revision: 244153 URL: http://llvm.org/viewvc/llvm-project?rev=244153&view=rev Log: Add flags to disable profile generation. This patch adds flags -fno-profile-instr-generate and -fno-profile-instr-use, and the GCC aliases -fno-profile-generate a

Re: [PATCH] D11778: Improvements on Diagnostic in Macro Expansions

rtrieu added a comment. Some questions about your tests. Comment at: test/Misc/reduced-diags-macros-backtrace.cpp:27 @@ +26,3 @@ +// ALL-NEXT: {{.*}}:7:23: note: expanded from macro 'LEVEL4' +// ALL-NEXT: #define LEVEL4(x) ADD(p,x) +// ALL-NEXT: ^ -

Re: [PATCH] D11403: [Modules] Add Darwin-specific compatibility module map parsing hacks

benlangmuir added inline comments. Comment at: lib/Lex/ModuleMap.cpp:1891-1908 @@ +1890,20 @@ + + if (ActiveModule->UsesRequiresExcludedHack) { +// Mark this header 'textual' (see doc comment for +// Module::UsesRequiresExcludedHack). Although iterating over the directory

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

On 5 August 2015 at 18:23, Argyrios Kyrtzidis wrote: > Author: akirtzidis > Date: Wed Aug 5 12:23:59 2015 > New Revision: 244066 > > URL: http://llvm.org/viewvc/llvm-project?rev=244066&view=rev > Log: > [test/Index] Update libclang tests to use libclang for creating PCH files. Hi, This also bro

Re: r244070 - [CMake] First pass at adding support for clang bootstrap builds to CMake

Chris Bieneman writes: > Author: cbieneman > Date: Wed Aug 5 12:38:12 2015 > New Revision: 244070 > > URL: http://llvm.org/viewvc/llvm-project?rev=244070&view=rev > Log: > [CMake] First pass at adding support for clang bootstrap builds to CMake > > Summary: > This patch adds a new CLANG_ENABLE_BO

r244161 - function_ref-ize ExternalASTSource::FindExternalLexicalDecl and remove its

Author: rsmith Date: Wed Aug 5 17:41:45 2015 New Revision: 244161 URL: http://llvm.org/viewvc/llvm-project?rev=244161&view=rev Log: function_ref-ize ExternalASTSource::FindExternalLexicalDecl and remove its useless return value. Switch to using it directly when completing the redeclaration chain

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

I tentatively made a change to one of the tests and it looks like it worked, so I’ll make the same change to the rest. > On Aug 5, 2015, at 3:10 PM, Renato Golin wrote: > > On 5 August 2015 at 18:23, Argyrios Kyrtzidis wrote: >> Author: akirtzidis >> Date: Wed Aug 5 12:23:59 2015 >> New Revis

[PATCH] D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange

nwilson created this revision. nwilson added reviewers: rsmith, hubert.reinterpretcast, fraggamuffin, faisalv, aaron.ballman. nwilson added a subscriber: cfe-commits. - Store the exception specification range's begin and end SourceLocation in DeclaratorChuck::FunctionTypeInfo. These SourceLocati

Re: [PATCH] D8940: Clang changes for indirect call target profiling

ivanbaev added a subscriber: ivanbaev. Comment at: lib/CodeGen/CodeGenPGO.cpp:858 @@ +857,3 @@ + if (PGOReader && haveRegionCounts()) { +// We record the top most called five function at each call site. +// Profile metadata contains "indirect_call_targets" string identify

r244170 - Add -fno-coverage-mapping flag.

Author: dnovillo Date: Wed Aug 5 18:27:40 2015 New Revision: 244170 URL: http://llvm.org/viewvc/llvm-project?rev=244170&view=rev Log: Add -fno-coverage-mapping flag. This new flag allows the user to disable a previous instance of -fcoverage-mapping, if needed. Modified: cfe/trunk/include/cl

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

r244176. > On Aug 5, 2015, at 4:11 PM, Argyrios Kyrtzidis wrote: > > I tentatively made a change to one of the tests and it looks like it worked, > so I’ll make the same change to the rest. > >> On Aug 5, 2015, at 3:10 PM, Renato Golin wrote: >> >> On 5 August 2015 at 18:23, Argyrios Kyrtzid

r244178 - Rename DescriptionString -> DataLayoutString as it matches the actual

Author: echristo Date: Wed Aug 5 18:48:05 2015 New Revision: 244178 URL: http://llvm.org/viewvc/llvm-project?rev=244178&view=rev Log: Rename DescriptionString -> DataLayoutString as it matches the actual use of the string. Modified: cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/li

Re: [PATCH]es: algorithm: Avoid moving initial subsequences in std::inplace_merge()

> On 2015-Aug-05, at 16:43, Duncan P. N. Exon Smith > wrote: > > >> On 2015-Jul-29, at 14:34, Duncan P. N. Exon Smith >> wrote: >> >> r227808 (and r227811) changed `std::inplace_merge()` to meet the >> complexity guidelines of the standard, which strictly restricts the >> number of calls to

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna added inline comments. Comment at: test/Analysis/localization-aggressive.m:202 @@ +201,3 @@ +// EmptyLocalizationContextChecker tests +#define HOM(s) YOLOC(s) +#define YOLOC(x) NSLocalizedString(x, nil) How about something like this, where the last argum

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

Still broken here locally on my machine after updating: FAIL: Clang :: Index/print-mangled-name.cpp (3844 of 22837) TEST 'Clang :: Index/print-mangled-name.cpp' FAILED Script: -- /usr/local/google/home/echristo/builds/build-llvm/Debug+Asserts/bin/c-index-t

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

What about this change: diff --git a/test/Index/print-mangled-name.cpp b/test/Index/print-mangled-name.cpp index 6dcda70..3d74fe5 100644 --- a/test/Index/print-mangled-name.cpp +++ b/test/Index/print-mangled-name.cpp @@ -2,7 +2,7 @@ // RUN: c-index-test -write-pch %t_linux.ast -target i686-pc-li

Re: [PATCH] D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange

rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:1977 @@ -1976,1 +1976,3 @@ +def err_function_concept_exception_spec : Error< + "function concept can not have exception specifiers">; def err -> def err can not -> cannot spe

r244186 - Rename the non-coding style conformant functions in namespace Builtins

Author: echristo Date: Wed Aug 5 20:01:12 2015 New Revision: 244186 URL: http://llvm.org/viewvc/llvm-project?rev=244186&view=rev Log: Rename the non-coding style conformant functions in namespace Builtins to match the rest of their brethren and reformat the bits that need it. Modified: cfe/t

Re: r244066 - [test/Index] Update libclang tests to use libclang for creating PCH files.

Yep. That works. -eric On Wed, Aug 5, 2015 at 5:40 PM Argyrios Kyrtzidis wrote: > What about this change: > > diff --git a/test/Index/print-mangled-name.cpp > b/test/Index/print-mangled-name.cpp > index 6dcda70..3d74fe5 100644 > --- a/test/Index/print-mangled-name.cpp > +++ b/test/Index/print-m

Re: [PATCH] D11789: Modify DeclaratorChuck::getFunction to be passed an Exception Specification SourceRange

nwilson added a comment. I'll make the fixes based on the comments, but had question about the FunctionTypeInfo in the meantime. Comment at: lib/Sema/SemaDecl.cpp:7447-7450 @@ -7446,1 +7446,6 @@ + if (const FunctionProtoType *FPT = R->getAs()) { +if (FPT->hasExce

Re: r243964 - [OPENMP] Fix compiler crash during data-sharing attributes analysis.

Thanks! Best regards, Alexey Bataev = Software Engineer Intel Compiler Team 05.08.2015 21:39, Hans Wennborg пишет: Sorry for the delay. Merged in r244090. Cheers, Hans On Tue, Aug 4, 2015 at 3:05 AM, Bataev, Alexey wrote: Hans, This patch fixes crash in clang. Could you backport

  1   2   >