chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Totally awesome man, ship it. I've left a nit-pick below, but this is 
definitely the right starting place.


================
Comment at: CMakeLists.txt:615
@@ +614,3 @@
+
+  set(ADDITIONAL_TARGETS_TO_ADD check check-all)
+  foreach(target ${ADDITIONAL_TARGETS_TO_ADD})
----------------
nit pick: I'd call it 'check-llvm', 'check-clang', and 'check-all'. I'm OK if 
we have to hard code the list though, that seems a minor inconvenience.


http://reviews.llvm.org/D11743



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to