Author: dougk Date: Wed Aug 5 13:03:47 2015 New Revision: 244079 URL: http://llvm.org/viewvc/llvm-project?rev=244079&view=rev Log: Claim arguments that belong to 'clang_ignored_gcc_optimization_f_Group'
This seems preferable to printing two warnings per unsupported option- one warning about not supporting it, and one about not using it. It also makes the '-Wno-' option do what you mean. Differential Revision: http://reviews.llvm.org/D11766 Modified: cfe/trunk/lib/Driver/Tools.cpp cfe/trunk/test/Driver/clang_f_opts.c Modified: cfe/trunk/lib/Driver/Tools.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=244079&r1=244078&r2=244079&view=diff ============================================================================== --- cfe/trunk/lib/Driver/Tools.cpp (original) +++ cfe/trunk/lib/Driver/Tools.cpp Wed Aug 5 13:03:47 2015 @@ -3848,6 +3848,7 @@ void Clang::ConstructJob(Compilation &C, for (const Arg *A : Args.filtered(options::OPT_clang_ignored_gcc_optimization_f_Group)) { D.Diag(diag::warn_ignored_gcc_optimization) << A->getAsString(Args); + A->claim(); } claimNoWarnArgs(Args); Modified: cfe/trunk/test/Driver/clang_f_opts.c URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang_f_opts.c?rev=244079&r1=244078&r2=244079&view=diff ============================================================================== --- cfe/trunk/test/Driver/clang_f_opts.c (original) +++ cfe/trunk/test/Driver/clang_f_opts.c Wed Aug 5 13:03:47 2015 @@ -412,6 +412,19 @@ // CHECK-NO-WARNING1-NOT: optimization flag '-finline-limit=1000' is not supported // CHECK-NO-WARNING2-NOT: optimization flag '-finline-limit' is not supported +// Test that an ignored optimization argument only prints 1 warning, +// not both a warning about not claiming the arg, *and* about not supporting +// the arg; and that adding -Wno-ignored-optimization silences the warning. +// +// RUN: %clang -### -fprofile-correction %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-NO-WARNING3 %s +// CHECK-NO-WARNING3: optimization flag '-fprofile-correction' is not supported +// CHECK-NO-WARNING3-NOT: argument unused +// RUN: %clang -### -fprofile-correction -Wno-ignored-optimization-argument %s 2>&1 \ +// RUN: | FileCheck --check-prefix=CHECK-NO-WARNING4 %s +// CHECK-NO-WARNING4-NOT: not supported +// CHECK-NO-WARNING4-NOT: argument unused + // RUN: %clang -### -S -fsigned-char %s 2>&1 | FileCheck -check-prefix=CHAR-SIGN1 %s // CHAR-SIGN1-NOT: -fno-signed-char _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
