@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
jhuber6 wrote:
Okay, so it definitely uses the device side, however the ROCmToolChain does not
take a host ToolChain. I'm wondering why the CUDA toolchain doesn't have this
issue, it checks the HostTriple for Windows just fine.
https://github.com/llvm/llvm-project/pull/113628
_
jhuber6 wrote:
> > Is there an issue with simply using the `HostTC` for everything? I feel
> > like that's the solution to this mess, since the `HostTC` would always know
> > whether or not the target is Windows without us needing to forward a bunch
> > of stuff.
>
> Yes, that would work too.
david-salinas wrote:
> Is there an issue with simply using the `HostTC` for everything? I feel like
> that's the solution to this mess, since the `HostTC` would always know
> whether or not the target is Windows without us needing to forward a bunch of
> stuff.
Yes, that would work too. But
https://github.com/jhuber6 commented:
Is there an issue with simply using the `HostTC` for everything? I feel like
that's the solution to this mess, since the `HostTC` would always know whether
or not the target is Windows without us needing to forward a bunch of stuff.
https://github.com/llv
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From c86922536a3ef02967efbaeccd522ff8a34bafc0 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
david-salinas wrote:
ah ok. :-)
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
@@ -272,6 +277,13 @@ class RocmInstallationDetector {
return Loc->second;
}
+ void init(bool DetectHIPRuntime = true, bool DetectDeviceLib = false) {
david-salinas wrote:
Yes. We are basically just trying to avoid adding "linux like paths" on
Windows.
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
david-salinas wrote:
ok, I was just basing this off of existing tests. But I see that recently
there has been support for targets in the REQUIRES statements. I'll change
these for both the Windows and Linux tests.
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
arsenm wrote:
I don't need .cl, as in OpenCL. I mean cl as in clang-cl, the MSVC compatible
driver
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing
@@ -0,0 +1,9 @@
+// REQUIRES: system-linux
david-salinas wrote:
agreed. Will change to use target.
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists
@@ -272,6 +277,13 @@ class RocmInstallationDetector {
return Loc->second;
}
+ void init(bool DetectHIPRuntime = true, bool DetectDeviceLib = false) {
jhuber6 wrote:
I don't understand why we need this, isn't it fine just to let it fail? Let the
detect
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
TC = std::make_unique(*this, Target, Args);
break;
case llvm::Triple::AMDHSA:
- TC = std::make_unique(*this, Target, Args);
+ TC = std::make_unique(*this, Target, Args,
+
@@ -3060,6 +3060,9 @@ Generic_GCC::Generic_GCC(const Driver &D, const
llvm::Triple &Triple,
: ToolChain(D, Triple, Args), GCCInstallation(D),
CudaInstallation(D, Triple, Args), RocmInstallation(D, Triple, Args) {
getProgramPaths().push_back(getDriver().Dir);
+ llv
arsenm wrote:
Commit title should be more specific and remove the Gerrit id
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -425,6 +425,12 @@ MSVCToolChain::MSVCToolChain(const Driver &D, const
llvm::Triple &Triple,
const ArgList &Args)
: ToolChain(D, Triple, Args), CudaInstallation(D, Triple, Args),
RocmInstallation(D, Triple, Args) {
+
+ // Tell the ROCm
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
arsenm wrote:
Also add a clang-cl test?
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
@@ -0,0 +1,9 @@
+// REQUIRES: system-windows
arsenm wrote:
This doesn't require windows, use an explicit triple
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -0,0 +1,9 @@
+// REQUIRES: system-linux
arsenm wrote:
This doesn't require linux, use an explicit triple
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/arsenm edited
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: David Salinas (david-salinas)
Changes
Change-Id: Ia0b44eb1069fa631a6d5156cf5881c978e23b62d
---
Full diff: https://github.com/llvm/llvm-project/pull/113628.diff
11 Files Affected:
- (modified) clang/lib/
https://github.com/david-salinas ready_for_review
https://github.com/llvm/llvm-project/pull/113628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From a5a84991fd605630e4c37cc92518fb8dee42ab61 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 4fad2d64582471816adc18f78294288bcaee0d63 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 2ab5bea395fce329be6bbcd8c04f9a9bd9da05df Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 307e0abed8387b0bffa4b7e24e995ad7ec402749 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From ee17fe072310a55e004134bb793a18b8089b4020 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 44f610ead0ec6e497f16771234067e7d96460666 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From 80d3a80534482d9cc13b6a50e5c8026b1a9c0d11 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
https://github.com/david-salinas updated
https://github.com/llvm/llvm-project/pull/113628
>From dd7037436d90e51927fd0b7cb6f822980393a867 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remove Linux search paths on Windows
Change-Id: Ia0b44eb1
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7b9f988a535c3549b71025e951e3a36a2bf0fa03
2bcd8608ca1e00893692f1d1f8b1734204abbd15 --e
https://github.com/david-salinas created
https://github.com/llvm/llvm-project/pull/113628
Change-Id: Ia0b44eb1069fa631a6d5156cf5881c978e23b62d
>From 2bcd8608ca1e00893692f1d1f8b1734204abbd15 Mon Sep 17 00:00:00 2001
From: David Salinas
Date: Tue, 22 Oct 2024 18:58:47 +
Subject: [PATCH] Remo
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
41 matches
Mail list logo
