================
@@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args,
       TC = std::make_unique<toolchains::NVPTXToolChain>(*this, Target, Args);
       break;
     case llvm::Triple::AMDHSA:
-      TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args);
+      TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args,
+                                                       Target.isOSWindows());
----------------
jhuber6 wrote:

The `RID` already has the host triple available I thought 
https://github.com/llvm/llvm-project/blob/3734e4c0c4966f794b9588445448004fee769ab9/clang/lib/Driver/ToolChains/ROCm.h#L169.
 Is the issue the fact that we probably make one for the GPU toolchain? If it's 
an unrecognized triple it should probably just give up.

https://github.com/llvm/llvm-project/pull/113628
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to