================ @@ -6440,7 +6440,8 @@ const ToolChain &Driver::getToolChain(const ArgList &Args, TC = std::make_unique<toolchains::NVPTXToolChain>(*this, Target, Args); break; case llvm::Triple::AMDHSA: - TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args); + TC = std::make_unique<toolchains::ROCMToolChain>(*this, Target, Args, + Target.isOSWindows()); ---------------- jhuber6 wrote:
Why do we need to pass something implied by the triple when we already have the triple? Also, this is for directly targeting via `--target=amdgcn-amd-amdhsa`, which isn't Windows. https://github.com/llvm/llvm-project/pull/113628 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits