github-actions[bot] wrote:
@gerekon Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a
problem with a build,
https://github.com/sstefan1 closed
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gerekon updated
https://github.com/llvm/llvm-project/pull/118008
>From 55b08ec540d18d50011ef9fb0e301e1f7650ca9e Mon Sep 17 00:00:00 2001
From: Andrei Safronov
Date: Thu, 1 Jun 2023 00:42:37 +0300
Subject: [PATCH] [Clang][Xtensa] Add Xtensa target.
---
clang/include/clang/Ba
@@ -0,0 +1,112 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
https://github.com/gerekon updated
https://github.com/llvm/llvm-project/pull/118008
>From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001
From: Andrei Safronov
Date: Thu, 1 Jun 2023 00:42:37 +0300
Subject: [PATCH 1/3] [Clang][Xtensa] Add Xtensa target.
---
clang/include/clan
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,112 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
https://github.com/efriedma-quic approved this pull request.
LGTM with one very minor comment
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
@@ -2742,3 +2742,275 @@
// RISCV64-LINUX: #define __unix__ 1
// RISCV64-LINUX: #define linux 1
// RISCV64-LINUX: #define unix 1
+
+// RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=xtensa
< /dev/null \
+// RUN: | FileCheck -match-full-lines -check-prefix
@@ -0,0 +1,141 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -358,7 +358,10 @@ class TargetInfo : public TransferrableTargetInfo,
//void *__saved_reg_area_end_pointer;
//void *__overflow_area_pointer;
//} va_list;
-HexagonBuiltinVaList
+HexagonBuiltinVaList,
+
+// Tensilica Xtensa
+XtensaABIBuiltinV
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
https://github.com/gerekon updated
https://github.com/llvm/llvm-project/pull/118008
>From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001
From: Andrei Safronov
Date: Thu, 1 Jun 2023 00:42:37 +0300
Subject: [PATCH 1/2] [Clang][Xtensa] Add Xtensa target.
---
clang/include/clan
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
https://github.com/gerekon edited
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -0,0 +1,141 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
@@ -0,0 +1,141 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
gerekon wrote:
Hi guys,
Thanks for you comments.
> I am a little concerned that progress on the upstreaming is moving
> excessively slowly. what exactly has been happening?
> That said, if there are signs that the target is only sporadically
> maintained, reaffirming that's not the case woul
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
I don't know that we need reaffirmation; the target is already in the backend,
so unless there's a call to remove the target, I think Clang's fine to expose
it.
That said, if there are signs that the target is only sporadically maintained,
reaffirmin
@@ -2742,3 +2742,275 @@
// RISCV64-LINUX: #define __unix__ 1
// RISCV64-LINUX: #define linux 1
// RISCV64-LINUX: #define unix 1
+
+// RUN: %clang_cc1 -E -dM -ffreestanding -fgnuc-version=4.2.1 -triple=xtensa
< /dev/null \
+// RUN: | FileCheck -match-full-lines -check-prefix
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -0,0 +1,141 @@
+//===--- Xtensa.h - Declare Xtensa target feature support ---*- C++
-*-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -358,7 +358,10 @@ class TargetInfo : public TransferrableTargetInfo,
//void *__saved_reg_area_end_pointer;
//void *__overflow_area_pointer;
//} va_list;
-HexagonBuiltinVaList
+HexagonBuiltinVaList,
+
+// Tensilica Xtensa
+XtensaABIBuiltinV
@@ -9727,6 +9727,51 @@ static TypedefDecl *CreateHexagonBuiltinVaListDecl(const
ASTContext *Context) {
return Context->buildImplicitTypedef(VaListTagArrayType,
"__builtin_va_list");
}
+static TypedefDecl *
+CreateXtensaABIBuiltinVaListDecl(const ASTContext *Context) {
+ /
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
@@ -0,0 +1,62 @@
+//===--- Xtensa.cpp - Implement Xtensa target feature support
-===//
+//
+// The LLVM Compiler Infrastructure
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.
erichkeane wrote:
> For reference, the RFC for the LLVM backend was
> https://discourse.llvm.org/t/rfc-request-for-upstream-tensilica-xtensa-esp32-backend/65355
> . Given there's an LLVM backend, I don't think we need a separate clang RFC?
> Assuming the target doesn't require any exotic front
efriedma-quic wrote:
For reference, the RFC for the LLVM backend was
https://discourse.llvm.org/t/rfc-request-for-upstream-tensilica-xtensa-esp32-backend/65355
. Given there's an LLVM backend, I don't think we need a separate clang RFC?
Assuming the target doesn't require any exotic frontend
gerekon wrote:
> I don't know what this target IS, did we have an RFC to approve this in Clang
> as a target? Do we have sufficient interest in the project to maintain
> it/keep it?
This is a part of our work for upstreaming Xtensa target support.
https://github.com/espressif/llvm-project/iss
https://github.com/erichkeane commented:
I don't know what this target IS, did we have an RFC to approve this in Clang
as a target? Do we have sufficient interest in the project to maintain it/keep
it?
https://github.com/llvm/llvm-project/pull/118008
__
banach-space wrote:
I'm not active in this area, so removed myself from the list of reviewers.
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
gerekon wrote:
ping
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
gerekon wrote:
@sstefan1 @andreisfr PTAL
https://github.com/llvm/llvm-project/pull/118008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/gerekon created
https://github.com/llvm/llvm-project/pull/118008
This PR implements support for generic Xtensa target in CLang.
>From bf0488585f41d3342c5c6d289d4621e3f50195cc Mon Sep 17 00:00:00 2001
From: Andrei Safronov
Date: Thu, 1 Jun 2023 00:42:37 +0300
Subject: [PATCH]
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Alexey Gerenkov (gerekon)
Changes
This PR implements support for generic Xtensa target in CLang.
---
Patch is 28.35 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/118008.diff
9 Files A
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alexey Gerenkov (gerekon)
Changes
This PR implements support for generic Xtensa target in CLang.
---
Patch is 28.35 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/118008.diff
9 Files Affected
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
44 matches
Mail list logo
