[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc4efd04f18c7: [clangd] Use URIs instead of paths in the index file list (authored by ArcsinX). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added a comment. Thank you for review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/D97535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 328222. ArcsinX added a comment. Call `FileIndex::updateMain()` with an absolute file path in tests to avoid test failures in debug mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://review

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks (both for the patch and bearing with me :D), LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 327853. ArcsinX added a comment. - use URIs as keys - create the file list from the keys Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.org/D97535 Files: clang-tools-extra/clan

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX planned changes to this revision. ArcsinX added a comment. In D97535#2596992 , @kadircet wrote: > But until that day, I suppose the best we can do is change the contract of > `FileSymbols` to sey keys are always `URIs representing the file produci

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added a comment. Right, i see the problem you are trying to solve, and all of this is a mess working nicely in unisom, but falls apart if you try to isolate each piece :/ (hence the need for figuring out list of files while indexing instead) But until that day, I suppose the best we ca

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); kadircet wrote: > ArcsinX wrote: > > kadircet wrote: > > > i

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); ArcsinX wrote: > kadircet wrote: > > it feels weird to choo

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); kadircet wrote: > it feels weird to choose one or the other

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:292 +for (const auto &Sym : *Slab) { + if (Sym.Definition) +Files.insert(Sym.Definition.FileURI); it feels weird to choose one or the other here, why not jus

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX marked an inline comment as done. ArcsinX added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279 SymbolSlabs.push_back(FileAndSymbols.second); + for (const auto &S : *FileAndSymbols.second) { +if (S.Definition)

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX updated this revision to Diff 326903. ArcsinX added a comment. - Do not insert the keys into the file list - Iterate through refs and symbols to create the file list after releasing the lock Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D975

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

kadircet added inline comments. Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279 SymbolSlabs.push_back(FileAndSymbols.second); + for (const auto &S : *FileAndSymbols.second) { +if (S.Definition) iterating over all the symbols here

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX added reviewers: sammccall, kadircet, hokein. ArcsinX added a comment. Initial discussion D94952#inline-892421 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97535/new/ https://reviews.llvm.or

[PATCH] D97535: [clangd] Use URIs instead of paths in the index file list

ArcsinX created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. ArcsinX requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. Without this patch the file list of the index is derived from the keys, b