ArcsinX marked an inline comment as done.
ArcsinX added inline comments.
================
Comment at: clang-tools-extra/clangd/index/FileIndex.cpp:279
SymbolSlabs.push_back(FileAndSymbols.second);
+ for (const auto &S : *FileAndSymbols.second) {
+ if (S.Definition)
----------------
kadircet wrote:
> iterating over all the symbols here (and refs below) seems really
> unfortunate. But looking at the previous discussions that seems to be best of
> both worlds until we populate a file list in SymbolCollector. However, I
> think it would be better to do the looping after releasing the lock (we
> already have the information copied over to our snapshots).
>
> moreover we seem to be still inserting keys of the Symbol and RefSlabs into
> Files, but not doing that for RelationSlabs, why? (i believe we shouldn't be
> inserting the keys at all, if we indeed want to just insert URIs and keep
> treating the keys as opaque objects).
> However, I think it would be better to do the looping after releasing the
> lock (we already have the information copied over to our snapshots).
Done
> we seem to be still inserting keys of the Symbol and RefSlabs into Files, but
> not doing that for RelationSlabs
Forgot to remove these insertions, thanks, fixed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97535/new/
https://reviews.llvm.org/D97535
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
