[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:1 -// RUN: %clang -O1 -fno-unroll-loops -S -o - %s -emit-llvm | FileCheck %s +// This relies on %clang_cc1, %clang does not emit the block names in Release mode. +// RUN: %clang_cc1 -O1 -fno-unroll-loops

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a65b8c739a0: [Clang][Misc] Change run line in fragile test (authored by adpatel6). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 314195. atmnpatel added a comment. Better? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 Files: clang/test/Misc/loop-opt-setup.c Index: clang/test/Misc/loop-opt

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D93952#2475762 , @atmnpatel wrote: > Ah I see, I was never able to find clear documentation on what exactly the > -cc1 flag does other than the conceptual description. This should fix it > right? -cc1 options are implementati

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel updated this revision to Diff 314193. atmnpatel added a comment. Ah I see, I was never able to find clear documentation on what exactly the -cc1 flag does other than the conceptual description. This should fix it right? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-31 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D93952#2475526 , @atmnpatel wrote: > I can't say that I know with any certainty, I'm too inexperienced. This > failure was missed by me locally, the pre-merge bot, and by most of the > buildbots other than the ones I mentioned a

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. You can check the CMake configurations of these bots. https://github.com/llvm/llvm-zorg `buildbot/osuosl/master/config/builders.py` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel added a comment. I can't say that I know with any certainty, I'm too inexperienced. This failure was missed by me locally, the pre-merge bot, and by most of the buildbots other than the ones I mentioned above. I have no idea under what configuration of CMake options will clang not emi

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. Do you know why some bots don't emit `entry:`? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93952/new/ https://reviews.llvm.org/D93952 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D93952: [Clang][Misc] Fix fragile test

2020-12-30 Thread Atmn Patel via Phabricator via cfe-commits
atmnpatel created this revision. atmnpatel added a reviewer: MaskRay. Herald added a subscriber: pengfei. atmnpatel requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang-with-thin-lto-ubuntu, clang-with-lto-ubuntu, clang-x86_64-debian-new-