This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe123cd674c02: [OpenCL] Refactor of targets OpenCL option
settings (authored by azabaznov).
Repository:
rG LLVM Github M
Anastasia accepted this revision.
Anastasia added a comment.
Cool. Thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92277/new/
https://reviews.llvm.org/D92277
___
cfe-commits mailing list
cfe-commit
azabaznov marked an inline comment as done.
azabaznov added inline comments.
Comment at: clang/test/Misc/nvptx.languageOptsOpenCL.cl:18
// RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple
nvptx64-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES
+// XFAIL: *
azabaznov updated this revision to Diff 318458.
azabaznov added a comment.
Herald added a project: clang.
Removed getCoreFeatures() as it's not used in this change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92277/new/
https://reviews.llvm.org/D
Anastasia accepted this revision.
Anastasia added a comment.
LGTM! Thanks! Great work! The comment can be addressed before committing.
Comment at: clang/include/clang/Basic/OpenCLOptions.h:165
+static inline llvm::SmallVector
+getCoreFeatures(const LangOptions &LO) {
+ llvm::S
azabaznov updated this revision to Diff 318165.
azabaznov marked 7 inline comments as done.
azabaznov added a comment.
Thanks for feedback. I agree that providing diagnostics for unsupported core
features is enough for now (I guess I'll try to come up with something for
OpenCL C 3.0 features to
Anastasia added inline comments.
Comment at: clang/lib/Basic/TargetInfo.cpp:360
+// Set core features based on OpenCL version
+for (auto CoreExt : clang::getCoreFeatures(Opts))
+ getTargetOpts().OpenCLFeaturesMap[CoreExt] = true;
azabaznov wrote:
> A
azabaznov added inline comments.
Comment at: clang/lib/Basic/TargetInfo.cpp:360
+// Set core features based on OpenCL version
+for (auto CoreExt : clang::getCoreFeatures(Opts))
+ getTargetOpts().OpenCLFeaturesMap[CoreExt] = true;
Anastasia wrote:
> a
Anastasia added inline comments.
Comment at: clang/lib/Basic/TargetInfo.cpp:360
+// Set core features based on OpenCL version
+for (auto CoreExt : clang::getCoreFeatures(Opts))
+ getTargetOpts().OpenCLFeaturesMap[CoreExt] = true;
azabaznov wrote:
> a
azabaznov added inline comments.
Comment at: clang/lib/Basic/TargetInfo.cpp:360
+// Set core features based on OpenCL version
+for (auto CoreExt : clang::getCoreFeatures(Opts))
+ getTargetOpts().OpenCLFeaturesMap[CoreExt] = true;
azabaznov wrote:
> A
azabaznov added inline comments.
Comment at: clang/lib/Basic/TargetInfo.cpp:360
+// Set core features based on OpenCL version
+for (auto CoreExt : clang::getCoreFeatures(Opts))
+ getTargetOpts().OpenCLFeaturesMap[CoreExt] = true;
Anastasia wrote:
> a
Anastasia added inline comments.
Comment at: clang/include/clang/Basic/OpenCLOptions.h:62
- /// Check if \c Ext is supported as an (optional) OpenCL core features for
- /// the given OpenCL version.
- ///
- /// \param Ext - Extension to look up.
- /// \param LO - \c LangOp
azabaznov added inline comments.
Comment at: clang/include/clang/Basic/OpenCLExtensions.def:17
// If the extensions are to be enumerated without the supported OpenCL version,
-// define OPENCLEXT(ext) where ext is the name of the extension.
+// define OPENCLEXTNAME(ext) where ex
Anastasia added a comment.
This patch contains very useful improvements to the design along with the
behavioral fixes. I see that it opens more opportunities to bring the
implementation in line with the conventional flow and therefore simplify the
further development of new functionality. More
yaxunl added a comment.
LGTM about r600 changes. Thanks.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D92277/new/
https://reviews.llvm.org/D92277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
azabaznov marked 14 inline comments as done.
azabaznov added inline comments.
Comment at: clang/include/clang/Basic/TargetInfo.h:1431
/// Set supported OpenCL extensions and optional core features.
+ virtual void setSupportedOpenCLOpts(const LangOptions &Opts) {}
--
azabaznov updated this revision to Diff 316627.
azabaznov added a comment.
Changes in the latest patch:
1. Removed XFAIL and OpenCL C 2.0 test running for r600 and NVPTX target
2. Fixed comments.
3. Core features are being set in `TargetInfo::adjust`.
CHANGES SINCE LAST ACTION
https://revie
yaxunl added inline comments.
Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26
// RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown
-Wpedantic-core-features -DTEST_CORE_FEATURES -target-cpu turks
+// XFAIL: *
azabaznov wrote
azabaznov added inline comments.
Comment at: clang/include/clang/Basic/OpenCLOptions.h:22
-/// OpenCL supported extensions and optional core features
-class OpenCLOptions {
- struct Info {
-bool Supported; // Is this option supported
-bool Enabled; // Is this option
yaxunl requested changes to this revision.
yaxunl added inline comments.
This revision now requires changes to proceed.
Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26
// RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown
-Wpedantic-core-featu
Anastasia added a subscriber: cfe-commits.
Anastasia added a comment.
This looks much cleaner than the current flow! Thanks! We should just figure
out a better place for defining the macros (see detailed comment in
Targets.cpp).
I am adding @cfe-commits since it's an important change to be vis
21 matches
Mail list logo
