yaxunl added inline comments.
================ Comment at: clang/test/Misc/r600.languageOptsOpenCL.cl:26 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple r600-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES -target-cpu turks +// XFAIL: * ---------------- azabaznov wrote: > yaxunl wrote: > > Pls remove XFAIL > Sure. I'll guard this #ifndef check with OpenCL version in existing tests; > but however, I think adding new tests with XFAIL for r600 and NVPTX (where > #ifndef check fails) seems reasonable to me. What do you think? I think it may be reasonable to remove the run line for CL2.0 and corresponding checks for 2.0 specific core features/extensions from this lit test since r600 does not support CL2.0. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D92277 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
