azabaznov marked an inline comment as done. azabaznov added inline comments.
================ Comment at: clang/test/Misc/nvptx.languageOptsOpenCL.cl:18 // RUN: %clang_cc1 -x cl -cl-std=CL2.0 %s -verify -triple nvptx64-unknown-unknown -Wpedantic-core-features -DTEST_CORE_FEATURES +// XFAIL: * ---------------- Anastasia wrote: > We shouldn't disable the test, but only change it to check the conformant > behavior i.e. the expected diagnostics for `cl_khr_3d_image_writes` should be > guarded by the OpenCL version. Yeah, sure. This won't a problem in this case as these test contain OpenCL C 1.2 runs. OpenCL C 3.0 is backward compatible with OpenCL C 1.2 so all 1.2 runs should be tested together with 3.0. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92277/new/ https://reviews.llvm.org/D92277 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
