This revision was automatically updated to reflect the committed changes.
Closed by commit rGed424b42880e: [clangd] Cleanup dependencies around
RemoteIndex (authored by kadircet).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90746/new/
https://revi
kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: clang-tools-extra/clangd/CMakeLists.txt:115
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
kadircet wrote:
> kbobyrev wrote
kadircet updated this revision to Diff 302820.
kadircet marked 2 inline comments as done.
kadircet added a comment.
- Revert indentation changes
- Move all libraries to private to be consistent on what we link in ClangdMain.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
http
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:115
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
kbobyrev wrote:
> If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link
> `clangd` itself to `clang
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/CMakeLists.txt:115
LINK_LIBS
+ clangdRemoteIndex
clangdSupport
If we're moving `clangdRemoteIndex` to `clangDaemon` there is no need to link
`clangd` itself to `clangdRemoteIndex` anymor
kadircet created this revision.
kadircet added reviewers: sammccall, kbobyrev.
Herald added subscribers: cfe-commits, usaxena95, arphaman, mgorny.
Herald added a project: clang.
kadircet requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.
RemoteIndexClient implemen
