[PATCH] D83817: [clangd] Add option to use remote index as static index

thakis added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ hans wrote: > I'm guessing this should be @CLANGD_ENABLE_REMOTE@ > The gn build w

Re: [PATCH] D83817: [clangd] Add option to use remote index as static index

Uh, you're right, thank you for the fix! I wonder why that was building for me... Again, thank you for noticing! Kirill On Mon, Jul 27, 2020 at 2:41 PM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added inline comments. > > > > Comment at: clang-tools

Re: [PATCH] D83817: [clangd] Add option to use remote index as static index

Ah, that's why... Thank you again and apologies for inconovinience! On Mon, Jul 27, 2020 at 3:06 PM Hans Wennborg via Phabricator < revi...@reviews.llvm.org> wrote: > hans added inline comments. > > > > Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702 >} > + if (

[PATCH] D83817: [clangd] Add option to use remote index as static index

hans added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:702 } + if (RemoteIndexAddress.empty() != ProjectPath.empty()) { +llvm::errs() << "remote-index-address and project-path have to be " hokein wrote: > the new code section

[PATCH] D83817: [clangd] Add option to use remote index as static index

hans added inline comments. Comment at: clang-tools-extra/clangd/Features.inc.in:2 #define CLANGD_BUILD_XPC @CLANGD_BUILD_XPC@ +#define CLANGD_ENABLE_REMOTE @CLANGD_ENABLE_REMTE@ I'm guessing this should be @CLANGD_ENABLE_REMOTE@ The gn build was upset: http://4

[PATCH] D83817: [clangd] Add option to use remote index as static index

This revision was automatically updated to reflect the committed changes. Closed by commit rG37ac559fccd4: [clangd] Add option to use remote index as static index (authored by kbobyrev). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. looks good, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280822. kbobyrev marked 2 inline comments as done. kbobyrev added a comment. Resolve more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tool

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein added a comment. mostly good, just a concern about the linking dependence. Comment at: clang-tools-extra/clangd/CMakeLists.txt:143 clangToolingSyntax + clangdRemoteIndex ) the dependence here seems to be a layer violation. we add remote-index lib

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280593. kbobyrev added a comment. Remove unused Remote category. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-tools-extra/clangd/CMakeLists.txt cla

[PATCH] D83817: [clangd] Add option to use remote index as static index

kbobyrev updated this revision to Diff 280589. kbobyrev marked 7 inline comments as done. kbobyrev added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83817/new/ https://reviews.llvm.org/D83817 Files: clang-to

[PATCH] D83817: [clangd] Add option to use remote index as static index

hokein added inline comments. Comment at: clang-tools-extra/clangd/tool/ClangdMain.cpp:457 +"remote-index-address", +cat(Remote), +desc("Address of the remote index server"), not sure whether we need a new category, probably can live in Features? ==