[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-03-14 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. In D75001#1922789 , @jdoerfert wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this wa

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-03-14 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D75001#1922789 , @jdoerfert wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-03-13 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert added a comment. In D75001#1891284 , @Hahnfeld wrote: > In D75001#1887876 , @jdoerfert wrote: > > > I like this way better. I was hoping we could do it in our cmake only :) > > > > Give others a day or so

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. In D75001#1891966 , @tra wrote: > In D75001#1891861 , @kkwli0 wrote: > > > @tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda? > > > If you're asking whether the warning will be d

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D75001#1891861 , @kkwli0 wrote: > @tra Will it also include -fopenmp-targets=nvptx64-nvidia-cuda? If you're asking whether the warning will be disabled for OpenMP, then no. This OpenMP target appears to rely on CUDA, and I think

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. In D75001#1891742 , @tra wrote: > In D75001#1891284 , @Hahnfeld wrote: > > > In D75001#1887876 , @jdoerfert > > wrote: > > > > > I like this way bett

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D75001#1891284 , @Hahnfeld wrote: > In D75001#1887876 , @jdoerfert wrote: > > > I like this way better. I was hoping we could do it in our cmake only :) > > > > Give others a day or so to com

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 added a comment. > Somewhat related, that means Clang issues a warning for every compilation > should there be a "unsupported" CUDA version around, even if it's not used? > @tra maybe we can only issue the warning if CUDA is going to be used? Some related issues were discussed in D74571

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D75001#1887876 , @jdoerfert wrote: > I like this way better. I was hoping we could do it in our cmake only :) > > Give others a day or so to comment before your commit but I'm fine with this. Well, that doesn't really work if

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-25 Thread Kelvin Li via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe16e267bb6ee: [OpenMP][cmake] ignore warning on unknown CUDA version (authored by kkwli0). Herald added a project: OpenMP. Herald added a subscriber: openmp-commits. Repository: rG LLVM Github Monorepo

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-21 Thread Johannes Doerfert via Phabricator via cfe-commits
jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. I like this way better. I was hoping we could do it in our cmake only :) Give others a day or so to comment before your commit but I'm fine with this. CHANGES SINCE LAST ACTION https:

[PATCH] D75001: [OpenMP][cmake] ignore warning on unknown CUDA version

2020-02-21 Thread Kelvin Li via Phabricator via cfe-commits
kkwli0 created this revision. kkwli0 added reviewers: tra, ABataev, JonChesterfield, jdoerfert, ye-luo. Herald added subscribers: guansong, mgorny. With CUDA 10.2 installed on the system, the compiler issues a warning about unknown CUDA version. The warning message makes the `LIBOMP_HAVE_VERSIO