Hahnfeld added a comment. In D75001#1922789 <https://reviews.llvm.org/D75001#1922789>, @jdoerfert wrote:
> In D75001#1891284 <https://reviews.llvm.org/D75001#1891284>, @Hahnfeld wrote: > > > In D75001#1887876 <https://reviews.llvm.org/D75001#1887876>, @jdoerfert > > wrote: > > > > > I like this way better. I was hoping we could do it in our cmake only :) > > > > > > Give others a day or so to comment before your commit but I'm fine with > > > this. > > > > > > Well, that doesn't really work if `openmp-commits` is only subscribed on > > commit. That said, the solution is a bit ugly but I don't have an > > alternative right now. > > > What is the problem with `openmp-commits` here? I got the emails, didn't you? There's nothing wrong with `openmp-commits`. I wanted to say that you have to subscribe the ML **before** committing. Otherwise only the reviewers are notified and there cannot be "others" chiming in. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75001/new/ https://reviews.llvm.org/D75001 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
