tra added a comment.

In D75001#1891284 <https://reviews.llvm.org/D75001#1891284>, @Hahnfeld wrote:
> In D75001#1887876 <https://reviews.llvm.org/D75001#1887876>, @jdoerfert wrote:
>
> > I like this way better. I was hoping we could do it in our cmake only :)
> >
> > Give others a day or so to comment before your commit but I'm fine with 
> > this.
>
>
> Well, that doesn't really work if `openmp-commits` is only subscribed on 
> commit. That said, the solution is a bit ugly but I don't have an alternative 
> right now.
>
> Somewhat related, that means Clang issues a warning for every compilation 
> should there be a "unsupported" CUDA version around, even if it's not used? 
> @tra maybe we can only issue the warning if CUDA is going to be used?


This is a good point. It should only affect compilations done with `-x cuda`. 
I'll fix that.
Short-term workaround is to specify invalid path to CUDA installation with 
`--cuda-path=/does/not/exist`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75001/new/

https://reviews.llvm.org/D75001



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to