[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

This revision was automatically updated to reflect the committed changes. Closed by commit rL359233: [Windows] Separate elements in -print-search-dirs with semicolons (authored by mstorsjo, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to com

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. In D61121#1479031 , @smeenai wrote: > I feel something like `llvm::sys::path::PathListSeparator` would be nicer, > since AFAIK any path list should be separa

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

rnk added a comment. > Alternatively, this could just be a local ifdef _WIN32 in this function, or > should we generalize the existing EnvPathSeparator to e.g. a > llvm::sys::path::PathListSeparator? I think it's clear as is. We're just reusing the environment path separator, which is used for

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

smeenai added a comment. I feel something like `llvm::sys::path::PathListSeparator` would be nicer, since AFAIK any path list should be separated with semicolons on Windows and colons everywhere else. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61121/new/ htt

[PATCH] D61121: [Windows] Separate elements in -print-search-dirs with semicolons

mstorsjo created this revision. mstorsjo added reviewers: rnk, hans, smeenai, thakis. Herald added a project: clang. Path lists on windows should always be separated by semicolons, not colons. Reuse llvm::sys::EnvPathSeparator for this purpose (as that's also a path list that is separated in the