rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

In D61121#1479031 <https://reviews.llvm.org/D61121#1479031>, @smeenai wrote:

> I feel something like `llvm::sys::path::PathListSeparator` would be nicer, 
> since AFAIK any path list should be separated with semicolons on Windows and 
> colons everywhere else.


I think the dominant use case for `EnvPathSeparator` is separating a list of 
paths in environment variables. We have other use cases for it in lists of 
paths that aren't environment variables (-print-search-dirs), but renaming it 
just seems like a minor improvement, which seems like it should be separate 
from this change.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61121/new/

https://reviews.llvm.org/D61121



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to