rnk added a comment. > Alternatively, this could just be a local ifdef _WIN32 in this function, or > should we generalize the existing EnvPathSeparator to e.g. a > llvm::sys::path::PathListSeparator?
I think it's clear as is. We're just reusing the environment path separator, which is used for INCLUDE, LIBS, PATH, and other path list environment variables. > Does this change need a test? If we don't already have tests for the colon separator, I don't think we need new tests to verify we get `:` on posix and `;` on Windows. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61121/new/ https://reviews.llvm.org/D61121 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
