[PATCH] D59759: [clangd] Add .cu files to VSCode extension

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE356916: [clangd] Add .cu files to VSCode extension (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D59759?vs=192109&id=192124#toc Repository: rCTE Clang To

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

ilya-biryukov updated this revision to Diff 192109. ilya-biryukov added a comment. - Added a comments about CUDA files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59759/new/ https://reviews.llvm.org/D59759 Files: clang-tools-extra/clangd/clien

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

hokein accepted this revision. hokein added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts:72 const filePattern: string = '**/*.{' + -['cpp', 'c', 'cc', 'cxx', 'c++', 'm',

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

ilya-biryukov added a comment. In D59759#1441402 , @hokein wrote: > Taking a closer look, it seems cuda is not supported by default in vscode :( > > vscode provides a way to add a new language in the extension, see > https://code.visualstudio.com/api/refe

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

hokein added a comment. In D59759#1441349 , @ilya-biryukov wrote: > In D59759#1441321 , @hokein wrote: > > > Do we need to add an entry `"onLanguage:cuda"` for cuda in the extension > > package.json? > > > Yeah, s

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

ilya-biryukov added a comment. In D59759#1441321 , @hokein wrote: > Do we need to add an entry `"onLanguage:cuda"` for cuda in the extension > package.json? Yeah, sounds reasonable, but I don't see cuda in the list of languages in VSCode, nor does it t

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

hokein added a comment. Do we need to add an entry `"onLanguage:cuda"` for cuda in the extension package.json? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59759/new/ https://reviews.llvm.org/D59759

[PATCH] D59759: [clangd] Add .cu files to VSCode extension

ilya-biryukov created this revision. ilya-biryukov added a reviewer: hokein. Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay, ioeric. Herald added a project: clang. clangd should be able to handle those with a proper compilation database. However, users using 'nvcc' migh