ilya-biryukov updated this revision to Diff 192109.
ilya-biryukov added a comment.
- Added a comments about CUDA files
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59759/new/
https://reviews.llvm.org/D59759
Files:
clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
Index: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
@@ -68,8 +68,18 @@
}
const serverOptions: vscodelc.ServerOptions = clangd;
+ // Note that CUDA ('.cu') files are special. When opening files of all
other
+ // extensions, VSCode would load clangd automatically. This is achieved by
+ // having a corresponding 'onLanguage:...' activation event in
package.json.
+ // However, VSCode does not have CUDA as a supported language yet, so we
+ // cannot add a corresponding activationEvent for CUDA files and clangd
will
+ // *not* load itself automatically on '.cu' files. When any of the files
+ // with other extensions are open, clangd will load itself and will also
+ // work on '.cu' files.
const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cxx', 'c++', 'm', 'mm', 'h', 'hh', 'hpp', 'hxx',
'inc'].join() + '}';
+ ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
+ 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
+ + '}';
const clientOptions: vscodelc.LanguageClientOptions = {
// Register the server for C/C++ files
documentSelector: [{ scheme: 'file', pattern: filePattern }],
Index: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
@@ -68,8 +68,18 @@
}
const serverOptions: vscodelc.ServerOptions = clangd;
+ // Note that CUDA ('.cu') files are special. When opening files of all other
+ // extensions, VSCode would load clangd automatically. This is achieved by
+ // having a corresponding 'onLanguage:...' activation event in package.json.
+ // However, VSCode does not have CUDA as a supported language yet, so we
+ // cannot add a corresponding activationEvent for CUDA files and clangd will
+ // *not* load itself automatically on '.cu' files. When any of the files
+ // with other extensions are open, clangd will load itself and will also
+ // work on '.cu' files.
const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cxx', 'c++', 'm', 'mm', 'h', 'hh', 'hpp', 'hxx', 'inc'].join() + '}';
+ ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
+ 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
+ + '}';
const clientOptions: vscodelc.LanguageClientOptions = {
// Register the server for C/C++ files
documentSelector: [{ scheme: 'file', pattern: filePattern }],
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
