ilya-biryukov created this revision.
ilya-biryukov added a reviewer: hokein.
Herald added subscribers: jdoerfert, kadircet, arphaman, jkorous, MaskRay,
ioeric.
Herald added a project: clang.
clangd should be able to handle those with a proper compilation
database. However, users using 'nvcc' might start seeing spurious errors
in '.cu' files after this change.
My plan is to land and release this, but be ready to revert in
case of negative user feedback.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D59759
Files:
clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
Index: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
@@ -69,7 +69,9 @@
const serverOptions: vscodelc.ServerOptions = clangd;
const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cxx', 'c++', 'm', 'mm', 'h', 'hh', 'hpp', 'hxx',
'inc'].join() + '}';
+ ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
+ 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
+ + '}';
const clientOptions: vscodelc.LanguageClientOptions = {
// Register the server for C/C++ files
documentSelector: [{ scheme: 'file', pattern: filePattern }],
Index: clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
===================================================================
--- clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
+++ clang-tools-extra/clangd/clients/clangd-vscode/src/extension.ts
@@ -69,7 +69,9 @@
const serverOptions: vscodelc.ServerOptions = clangd;
const filePattern: string = '**/*.{' +
- ['cpp', 'c', 'cc', 'cxx', 'c++', 'm', 'mm', 'h', 'hh', 'hpp', 'hxx', 'inc'].join() + '}';
+ ['cpp', 'c', 'cc', 'cu', 'cxx', 'c++', 'm', 'mm',
+ 'h', 'hh', 'hpp', 'hxx', 'inc'].join()
+ + '}';
const clientOptions: vscodelc.LanguageClientOptions = {
// Register the server for C/C++ files
documentSelector: [{ scheme: 'file', pattern: filePattern }],
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
