smeenai added inline comments.
Comment at: lib/CodeGen/CGCXXABI.h:248
+llvm_unreachable("Only needed for the Microsoft ABI");
+ }
rjmccall wrote:
> Should you just generalize the existing method to only take a VarDecl* so it
> can be used for either kind
rjmccall added a comment.
In https://reviews.llvm.org/D47988#1135929, @rnk wrote:
> In https://reviews.llvm.org/D47988#1135533, @rjmccall wrote:
>
> > In general, it's unfortunate that this has to leave so many
> > C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
> > t
rnk added a comment.
In https://reviews.llvm.org/D47988#1135533, @rjmccall wrote:
> In general, it's unfortunate that this has to leave so many
> C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
> though, I'm not sure I can see a great alternative here, especially beca
rjmccall added a comment.
In general, it's unfortunate that this has to leave so many
C++-runtime-specific tendrils in the ObjC code. Unlike the EH type patch,
though, I'm not sure I can see a great alternative here, especially because of
the semantic restrictions required by outlining.
===
smeenai added a comment.
Ping.
Repository:
rC Clang
https://reviews.llvm.org/D47988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk added a comment.
In https://reviews.llvm.org/D47988#1127432, @smeenai wrote:
> Any idea why we would see inlining in one case and not the other? i686 vs.
> x86-64 doesn't make any difference, and neither does -Os vs. -O1 vs. -O2.
My theory is that the inliner is attempting to avoid inlinin
smeenai added a comment.
@rnk remember how I was asking you about inlining into catchpads on IRC a few
days back? It was in relation to this change.
If I have a file `finally1.m`:
void f(void);
void g() {
@try {
f();
} @finally {
f();
}
}
and compile it with:
c
smeenai created this revision.
smeenai added reviewers: DHowett-MSFT, compnerd, majnemer, rjmccall, rnk.
We're implementing funclet-compatible code generation for Obj-C
exceptions when using the MSVC ABI. The idea is that the Obj-C runtime
will wrap Obj-C exceptions inside C++ exceptions, which al
