rjmccall added a comment.

In general, it's unfortunate that this has to leave so many 
C++-runtime-specific tendrils in the ObjC code.  Unlike the EH type patch, 
though, I'm not sure I can see a great alternative here, especially because of 
the semantic restrictions required by outlining.



================
Comment at: lib/CodeGen/CGCXXABI.h:248
+    llvm_unreachable("Only needed for the Microsoft ABI");
+  }
 
----------------
Should you just generalize the existing method to only take a VarDecl* so it 
can be used for either kind of catch?


Repository:
  rC Clang

https://reviews.llvm.org/D47988



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to