smeenai added inline comments.
================
Comment at: lib/CodeGen/CGCXXABI.h:248
+ llvm_unreachable("Only needed for the Microsoft ABI");
+ }
----------------
rjmccall wrote:
> Should you just generalize the existing method to only take a VarDecl* so it
> can be used for either kind of catch?
The Itanium version of emitBeginCatch actually uses the statement for location
info (it calls `getLocStart` on it). I suppose I could generalize the existing
method to take both a VarDecl* and a SourceLocation though.
Repository:
rC Clang
https://reviews.llvm.org/D47988
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
