This revision was automatically updated to reflect the committed changes.
Closed by commit rL330272: [NVPTX] Emit debug info in DWARF-2 by default for
Cuda devices. (authored by ABataev, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D
ABataev added a comment.
Thanks, will commit it after the commit of the LLVM part
Repository:
rC Clang
https://reviews.llvm.org/D42581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rC Clang
https://reviews.llvm.org/D42581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:436-437
assert(Output.isNothing() && "Invalid output.");
- if (Args.hasArg(options::OPT_g_Flag))
+ if (mustEmitDebugInfo(Args) == FullDebug)
CmdArgs.push_back("-g");
tra wrote
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:436-437
assert(Output.isNothing() && "Invalid output.");
- if (Args.hasArg(options::OPT_g_Flag))
+ if (mustEmitDebugInfo(Args) == FullDebug)
CmdArgs.push_back("-g");
Do we need to
ABataev updated this revision to Diff 132016.
ABataev added a comment.
1. Updated after review.
2. Changed the default behavior of --[no]cuda-noopt-device-debug. If the
optimization level is not specified or is O0 and debug info must be emitted,
the device debug info is emitted. If optimization
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
tra wrote:
> ABataev wr
ABataev added a comment.
In https://reviews.llvm.org/D42581#989760, @probinson wrote:
> If you want to force DWARF 2, probably clamping the version in LLVM would be
> simpler? Although most of the debug-info tests are architecture-specific and
> wouldn't run for an NVPTX target anyway.
Hi, I
probinson added a comment.
If you want to force DWARF 2, probably clamping the version in LLVM would be
simpler? Although most of the debug-info tests are architecture-specific and
wouldn't run for an NVPTX target anyway.
Repository:
rC Clang
https://reviews.llvm.org/D42581
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
ABataev wrote:
> tra wrote:
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
tra wrote:
> ABataev wr
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
ABataev wrote:
> tra wrote:
ABataev added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
tra wrote:
> There's mo
tra added inline comments.
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+CmdArgs.push_back("-g");
There's more than one -g op
ABataev created this revision.
ABataev added reviewers: tra, jlebar.
Herald added subscribers: JDevlieghere, aprantl.
NVPTX target supports debug info in DWARF-2 format. Patch adds emission
of debug info in DWARF-2 by default.
Repository:
rC Clang
https://reviews.llvm.org/D42581
Files:
lib
15 matches
Mail list logo
