ABataev added inline comments.
================
Comment at: lib/Driver/ToolChains/Cuda.cpp:353
CmdArgs.push_back(Args.MakeArgString(Output.getFilename()));
+ if (mustEmitDebugInfo(Args) && Args.hasArg(options::OPT_g_Flag))
+ CmdArgs.push_back("-g");
----------------
tra wrote:
> There's more than one -g option. Presumably you still want -g here for
> -g{1,2,3} or -ggdb{1,2,3} or -gdwarf2.
>
> Speaking of dwarf, what's going to happen if someone passes -gdwarf5? Should
> we downgrade it to -gdwarf2 on device side and issue a warning?
>
That's exactly what I want to avoid. I think we can ignore these options and
handle only `-g` option.
Or I can add a function to ToolChain class to force using the default settings
for debugger tuning and DWARF version rather than take them from the driver
options.
================
Comment at: test/Driver/cuda-dwarf-2.cu:6-11
+// DEFAULT: "-fcuda-is-device"
+// DEFAULT-SAME: "-dwarf-version=2"
+// DEFAULT: ptxas
+// DEFAULT-NOT: "-g"
+// DEFAULT: fatbinary
+// DEFAULT-NOT: "-g"
----------------
tra wrote:
> Nit: you could probably collapse all test cases into two: HAS_DEBUG/NO_DEBUG
Ok, will do
Repository:
rC Clang
https://reviews.llvm.org/D42581
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
