kcc added a comment.
Please also write a lit test for test/DeepRecursionTest.cpp (e.g.
test/deep-recursion.test)
Repository:
rL LLVM
https://reviews.llvm.org/D36839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
This revision was automatically updated to reflect the committed changes.
Closed by commit rL311186: [SanitizerCoverage] Add stack depth tracing
instrumentation. (authored by morehouse).
Changed prior to commit:
https://reviews.llvm.org/D36839?vs=111570&id=111718#toc
Repository:
rL LLVM
htt
vitalybuka accepted this revision.
vitalybuka added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D36839
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
morehouse updated this revision to Diff 111570.
morehouse added a comment.
- Extract shared condition.
- Add ATTRIBUTE_INTERFACE.
- Rename variable to __sancov_lowest_stack.
- Add driver test for -fsanitize-coverage=stack-depth.
https://reviews.llvm.org/D36839
Files:
clang/include/clang/Drive
morehouse added inline comments.
Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:31
ATTRIBUTE_INTERFACE
uintptr_t __sancov_trace_pc_pcs[fuzzer::TracePC::kNumPCs];
vitalybuka wrote:
> Why this does not need ATTRIBUTE_INTERFACE?
Not sure why it works without it.
vitalybuka added inline comments.
Comment at: clang/lib/Driver/SanitizerArgs.cpp:559
// trace-pc w/o func/bb/edge implies edge.
if ((CoverageFeatures &
Extract
if (!(CoverageFeatures & InsertionPointTypes)) {
}
Comment at: clang/l
morehouse created this revision.
Herald added subscribers: hiraditya, kubamracek.
Augment SanitizerCoverage to insert maximum stack depth tracing for
use by libFuzzer. The new instrumentation is enabled by the flag
-fsanitize-coverage=stack-depth and is compatible with the existing
trace-pc-guard
