morehouse added inline comments.
================ Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:31 ATTRIBUTE_INTERFACE uintptr_t __sancov_trace_pc_pcs[fuzzer::TracePC::kNumPCs]; ---------------- vitalybuka wrote: > Why this does not need ATTRIBUTE_INTERFACE? Not sure why it works without it. Maybe the default build doesn't use `-fvisibility=hidden`? But seems like a good idea to add. ================ Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:35 +// Used by -fsanitize-coverage=stack-depth to track stack depth +thread_local uintptr_t __sanitizer_cov_lowest_stack; + ---------------- vitalybuka wrote: > Should this be __sancov_lowest_stack or even __sancov_stack_depth? It looks like the current convention is to use `__sancov_*` for variables and `__sanitizer_cov_*` for functions. I'll modify the name here to reflect that. I think `__sancov_lowest_stack` would be the more descriptive choice since the "lowest stack" gets smaller as the "max stack depth" gets larger. https://reviews.llvm.org/D36839 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
