vitalybuka added inline comments.
================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:559
// trace-pc w/o func/bb/edge implies edge.
if ((CoverageFeatures &
----------------
Extract
if (!(CoverageFeatures & InsertionPointTypes)) {
....
}
================
Comment at: clang/lib/Driver/SanitizerArgs.cpp:673
std::make_pair(CoverageTracePCGuard, "-fsanitize-coverage-trace-pc-guard"),
std::make_pair(CoverageInline8bitCounters,
"-fsanitize-coverage-inline-8bit-counters"),
std::make_pair(CoveragePCTable, "-fsanitize-coverage-pc-table"),
----------------
Could you please add new flag into tools/clang/test/Driver/fsanitize-coverage.c
================
Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:31
ATTRIBUTE_INTERFACE
uintptr_t __sancov_trace_pc_pcs[fuzzer::TracePC::kNumPCs];
----------------
Why this does not need ATTRIBUTE_INTERFACE?
================
Comment at: llvm/lib/Fuzzer/FuzzerTracePC.cpp:35
+// Used by -fsanitize-coverage=stack-depth to track stack depth
+thread_local uintptr_t __sanitizer_cov_lowest_stack;
+
----------------
Should this be __sancov_lowest_stack or even __sancov_stack_depth?
https://reviews.llvm.org/D36839
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
