[PATCH] D31168: Set FMF for -ffp-contract=fast

This revision was automatically updated to reflect the committed changes. Closed by commit rL299469: Set FMF for -ffp-contract=fast (authored by anemet). Changed prior to commit: https://reviews.llvm.org/D31168?vs=93882&id=94121#toc Repository: rL LLVM https://reviews.llvm.org/D31168 Files:

[PATCH] D31168: Set FMF for -ffp-contract=fast

rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land. Yes, thank you, that's great. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/c

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet added a comment. Thanks, Aaron! @rjmccall, does it look good to you too? https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31168: Set FMF for -ffp-contract=fast

aaron.ballman added a comment. LGTM. but you should wait for someone more familiar with this part of codegen before committing. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet updated this revision to Diff 93882. anemet added a comment. Address John's comment. https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ffp-contract-fast-option.cpp Index: test/CodeGen/ffp-contract-fast-option.cpp ==

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet added a comment. In https://reviews.llvm.org/D31168#716153, @rjmccall wrote: > I may have missed earlier steps in this patch series. Why is this being done > statefully and contextually in the IRBuilder instead of just applying the > flag from the BinaryOperator to the instruction when

[PATCH] D31168: Set FMF for -ffp-contract=fast

rjmccall added a comment. I may have missed earlier steps in this patch series. Why is this being done statefully and contextually in the IRBuilder instead of just applying the flag from the BinaryOperator to the instruction when building it? It's not like ScalarExprEmitter doesn't know that

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet added a comment. Ping. This is the only patch in the series now that wasn't approved. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31168: Set FMF for -ffp-contract=fast

anemet updated this revision to Diff 93487. anemet added a comment. Also add 'contract' for CompoundAssignOperator (+= and -=). For l-values, these don't go through the expr-visitor in ScalarExprEmitter::Visit. This again piggybacks on how debug-locations are added. https://reviews.llvm.org/D3

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet updated this revision to Diff 92564. anemet added a comment. Address Akira's comments https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp test/CodeGen/ffp-contract-fast-option.c Index: test/CodeGen/ffp-contract-fast-option.c =

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet added a comment. Thanks, Akira. You're right on both accounts. I actually had a test written but failed to git add it. https://reviews.llvm.org/D31168 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

ahatanak added a comment. I think you can add a test case in this patch (after the llvm changes are checked in)? Comment at: lib/CodeGen/CGExprScalar.cpp:262 +ApplyFPFeatures(llvm::IRBuilderBase &Builder, Expr *E) +: CGBuilderTy::FastMathFlagGuard(Builder) { +

[PATCH] D31168: Set FMF for -ffp-contract=fast rather than a TargetConfig

anemet created this revision. This is toward moving fp-contraction=fast from an LLVM TargetOption to a FastMathFlag in order to fix PR25721. https://reviews.llvm.org/D31168 Files: lib/CodeGen/CGExprScalar.cpp Index: lib/CodeGen/CGExprScalar.cpp ==